j...@google.com
unread,Feb 6, 2012, 4:25:52 PM2/6/12Sign in to reply to author
Sign in to forward
You do not have permission to delete messages in this group
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to bra...@worldviewsoftware.com, google-web-tool...@googlegroups.com, re...@gwt-code-reviews-hr.appspotmail.com
There appears to be some problem in how this was created -- the
side-by-side diffs don't work, and Publish+Mail Comments doesn't work.
Basically:
- you need tests
- copyright and code style should match GWT standards
- the limitation on non-empty maps seems too limiting. The GWT
emulation can reach a full set of enum values via keySet, so that could
be used on the client side to avoid this limitation
- the server doesn't appear to read the exemplar value from the stream
http://gwt-code-reviews.appspot.com/1634804/