gwtproject.org link tree broken
108 views
Skip to first unread message
Colin Alworth
Jan 23, 2014, 8:00:43 PM1/23/14
to google-web-tool...@googlegroups.com
Something funny has happened to the dont-reload-the-page code on gwtproject.org, but I'm not seeing any obvious commit that should have done this.
Steps to repro:
1) visit http://gwtproject.org/, or any *top level* document
2) observe that any link you hover looks to be correct, and visiting any link will work correctly (including opening it from a new tab
3) Click on any *nested* link (such as something inside of "articles >" or "documentation > latest >").
4) Now, hover over any link, and notice that the subdirectory you are currently in will be prepended to the link url
5) Open that link in a new tab, observe that you get a 404.
Example:
Go to http://gwtproject.org/.
Expand Documentation, Latest, and click on Overview.
Right-click Accessibility, and select 'open in a new tab'
Observe 404 error page, and obviously broken url: http://www.gwtproject.org/doc/latest/doc/latest/DevGuideA11y.html
The source at https://gwt.googlesource.com/gwt-site-webapp/+/master/ hasn't been updated since early December, and I can't imagine this has been broken that long, and none of the recent commits to gwt-site itself seem capable of this, so I'm at a bit of a loss as to how this could have happened. Were there perhaps any changes made that didn't go through googlesource.com, or has this really been broken for months?
Steps to repro:
1) visit http://gwtproject.org/, or any *top level* document
2) observe that any link you hover looks to be correct, and visiting any link will work correctly (including opening it from a new tab
3) Click on any *nested* link (such as something inside of "articles >" or "documentation > latest >").
4) Now, hover over any link, and notice that the subdirectory you are currently in will be prepended to the link url
5) Open that link in a new tab, observe that you get a 404.
Example:
Go to http://gwtproject.org/.
Expand Documentation, Latest, and click on Overview.
Right-click Accessibility, and select 'open in a new tab'
Observe 404 error page, and obviously broken url: http://www.gwtproject.org/doc/latest/doc/latest/DevGuideA11y.html
The source at https://gwt.googlesource.com/gwt-site-webapp/+/master/ hasn't been updated since early December, and I can't imagine this has been broken that long, and none of the recent commits to gwt-site itself seem capable of this, so I'm at a bit of a loss as to how this could have happened. Were there perhaps any changes made that didn't go through googlesource.com, or has this really been broken for months?
Julien Dramaix
Jan 24, 2014, 5:56:04 AM1/24/14
to google-web-tool...@googlegroups.com
I guess it's broken since the beginning.
As you mentioned the bug only occurs when you start the navigation from http://gwtproject.org/ or any top level document and you try to open a link of the menu in a new tab.
Anyway good catch :-)
I will fix that.
Julien
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Julien Dramaix
Apr 9, 2014, 6:02:14 AM4/9/14
to google-web-tool...@googlegroups.com
FYI, I've uploaded a patch to fix this issue : https://gwt-review.googlesource.com/#/c/6941/1
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages