GWTproject site menu

320 views
Skip to first unread message

Manuel Carrasco Moñino

unread,
Apr 7, 2014, 10:35:54 AM4/7/14
to google-web-tool...@googlegroups.com
Hi all

I was thinking on modify a couple of things in the menu structure:

- Remove useless 'Latest' branch inside 'Documentation'
- Move 'Tutorial' inside 'Documentation' to the top menu and sort each step.
- Make some groups inside 'Documentation': 'Coding Basics' 'Html5' 'I18n' 'Testing' 'UI' 'FAQ' and 'Ref' so as Documentation section is easier to navigate.


WDYT?

- Manolo


Jens

unread,
Apr 7, 2014, 10:53:01 AM4/7/14
to google-web-tool...@googlegroups.com
Sounds reasonable :)

-- J.

Daniel Kurka

unread,
Apr 7, 2014, 2:40:29 PM4/7/14
to google-web-tool...@googlegroups.com
If you move stuff around you will need to make sure that links (also external) won't break. (we still get a lot of traffic from external links)

But I think working on the navigation menu of the page is quite overdue.

-Daniel


On Mon, Apr 7, 2014 at 4:53 PM, Jens <jens.ne...@gmail.com> wrote:
Sounds reasonable :)

-- J.

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--
Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens

Julien Dramaix

unread,
Apr 9, 2014, 3:28:54 AM4/9/14
to google-web-tool...@googlegroups.com
Hi Manolo,

It's something I wanted to do for a while. Let's organize a conf call to talk about that.

Julien

Manuel Carrasco Moñino

unread,
Apr 9, 2014, 7:36:10 AM4/9/14
to google-web-tool...@googlegroups.com
Hi all,

Julien and me have created a document with some plans about the gwtproject.org site.
Please, feel free to add any comment you have.


Manuel Carrasco Moñino

unread,
Apr 9, 2014, 7:36:53 AM4/9/14
to google-web-tool...@googlegroups.com

Manuel Carrasco Moñino

unread,
May 6, 2014, 11:57:55 AM5/6/14
to google-web-tool...@googlegroups.com
Hello,

I have committed some patches, and deployed a demo version  so as you guys can test the new menu distribution.

What I've done based on Thomas suggestion is to maintain a toc file instead of moving or renaming pages.

Apart from the menu distribution, the demo includes some navigation fixes, small css changes, and the ability to adapt to mobile screens when the window is narrowed.

Once this distribution is reviewed I want to focus on updating some contents, especially outdated pages.

Feel free to give feedback.

- Manolo





Goktug Gokdogan

unread,
May 6, 2014, 2:33:32 PM5/6/14
to google-web-toolkit-contributors
Looks better; thanks for the work.

Some suggestions:
 - Removes the versions submenu from Downloads as it is already included as a link from Downloads page.
 - Move GWT surveys under resources
 - Perhaps we can group Making GWT Better, Life of an Issue, Steering Committee under a submenu
 - Release Notes -> drop it from menu? its already linked from Downloads page.
 - In Documentation menu:
    - We need to re-order stuff for people who are reading documentation in a sequential manner.
      e.g. Communicate with a server should probably earlier, maybe in basics?
   - We may want Organize Projects and Compile/Debug to be part of coding basics.
   - Drop IE9 specific page from menu
   - Perhaps group RequestFactory, Act.&Places, Validation, Access., I18N etc. in "Advanced Topics"



Jamie Nelson

unread,
May 8, 2014, 11:07:23 AM5/8/14
to google-web-tool...@googlegroups.com
Looks really slick.

My only suggestion is that we turn the animations down to a quarter second or less.
They look good on big menus, but for single items, it feels needlessly slow when the animation takes any amount of time.



This message and any attachments are solely for the intended recipient. If you are not the intended recipient, disclosure, copying, use, or distribution of the information included in this message is prohibited -- please immediately and permanently delete this message.

Jens

unread,
May 8, 2014, 12:19:20 PM5/8/14
to google-web-tool...@googlegroups.com
I noticed that it is not possible anymore to close a menu category by clicking on the menu item text again. You can now only close a category by using the triangle icon.

-- J.

Manuel Carrasco Moñino

unread,
May 8, 2014, 4:56:03 PM5/8/14
to google-web-tool...@googlegroups.com
I will deploy a new demo with these changes tomorrow.


Manuel Carrasco Moñino

unread,
May 8, 2014, 4:56:07 PM5/8/14
to google-web-tool...@googlegroups.com
On Thu, May 8, 2014 at 5:07 PM, Jamie Nelson <james....@appian.com> wrote:
Looks really slick.

My only suggestion is that we turn the animations down to a quarter second or less.

It is set to 300ms, I will change it to 200 when deploy the demo again.
 
They look good on big menus, but for single items, it feels needlessly slow when the animation takes any amount of time.



This message and any attachments are solely for the intended recipient. If you are not the intended recipient, disclosure, copying, use, or distribution of the information included in this message is prohibited -- please immediately and permanently delete this message.

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.

Manuel Carrasco Moñino

unread,
May 8, 2014, 4:56:14 PM5/8/14
to google-web-tool...@googlegroups.com
On Thu, May 8, 2014 at 6:19 PM, Jens <jens.ne...@gmail.com> wrote:
I noticed that it is not possible anymore to close a menu category by clicking on the menu item text again. You can now only close a category by using the triangle icon.

-- J.

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.

Manuel Carrasco Moñino

unread,
May 8, 2014, 4:59:03 PM5/8/14
to google-web-tool...@googlegroups.com
That's intentional, it is the same behavior than tree menus in google wikis and GWT trees.
Now the parent item link is only clickable when it has a page associated (it was not possible in the last version), so the click is handled to load that page.


On Thu, May 8, 2014 at 6:19 PM, Jens <jens.ne...@gmail.com> wrote:
I noticed that it is not possible anymore to close a menu category by clicking on the menu item text again. You can now only close a category by using the triangle icon.

-- J.

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.

Brian Slesinsky

unread,
May 8, 2014, 5:27:44 PM5/8/14
to GWTcontrib
If you click "Tutorial" and then "Documentation" the animation is a bit unfortunate. Because the previous menu closes at the same time that the new one opens, the new menu expands both up and down so that your cursor ends up pointing to the middle of the new menu, and then you have to wait until it stops moving to figure out where to move the mouse next. In the old UI, the menu item you just clicked on never moves.

But I'm not sure what to do about it. Maybe skip animating closing a menu when it's not the one you clicked on?

Also, it's not in the demo, but we should make sure sourcemap debugging works with the new version. I sometimes include a link to gwtproject.org in browser bug reports since I don't know any other public websites that have GWT with sourcemaps on. Unfortunately this is going to break any specific directions I put into the bug reports, but hopefully something equivalent should work.

- Brian

Ray Cromwell

unread,
May 8, 2014, 6:12:57 PM5/8/14
to google-web-toolkit-contributors
While not part of this CL, the bottom footer being in the center of the page on some short pages looks ugly. The footer should always be at least at the bottom, or offscreen.



Manuel Carrasco Moñino

unread,
May 9, 2014, 7:03:51 PM5/9/14
to google-web-tool...@googlegroups.com
@Goktug I have deployed a new demo with the changes in the menu you suggested. http://gwtproject.gquery.org/v2/

@Jamie In this version I've set 200ms for animations

@Brian, the fact of collapsing unrelated branches is intentional in order to focus on the active branch. You can open branches clicking on the arrow, but once you click on a subject, that branch is selected. I've been playing a long with the menu and see this behaviour much more usable since I don't have click on other branches for closing them. Anyway I have deployed another version in http://gwtproject.gquery.org/v3/ with the feature of collapse-unrelated-branches disabled so as other people can give an opinion.
In this demo sourcemaps are disabled, but in gwtproject they should be enabled

@Ray, I think that what you say is something called 'sticky footer' which means that the footer is at the bottom unless the content is large enough. I have fixed the css in both demos.


Julien and me want to deploy this version at the beginning of next week.

Please check it in desktop and mobile and let us know if you have any suggestion.

Thanks
- Manolo





Goktug Gokdogan

unread,
May 9, 2014, 8:33:14 PM5/9/14
to google-web-toolkit-contributors
Pretty cool. Thanks for all the work. Also special kudos for fixing the styling for download page, it is much more elegant now!

Footer:
 - We are now missing the extra space in the bottom of the pages (the one before the footer)
 - The area for the footer is larger and the text is closer to the bottom - I think the original spacing was better. Also if you take a look at the overview page you will see the footer hides part of the image.

Others:
 - Clicking images shows blank page - perhaps just a deployment issue
 - There is a broken "Advanced Topics" menu item - I think it is mixed up with the Logging menu item.
 - I would put "Optimize" to Advanced topics. Perhaps security and i18n as well.
 - Perhaps move Community -> Developer Spotlight under Resources?
 - In Resources, we can move gwt surveys to the end of the list

 
Below are other issues that doesn't look like regressions. Perhaps we can have some other quick wins before publishing the final version?

Menu:
 - Ideally the arrows shouldn't indent the menu items and instead menu items should be aligned by text (e.g. gmail). I'm not sure if you are reusing any widgets here; if you aren't reusing we might want to change that.
- We might want to change how menus behave. I actually like GWT Developer pages (e.g. https://developers.google.com/appengine/pricing) where menu items that are parents of the other menu items are not used as links to a content, instead they serve as a placeholder and collapses/expands based when clicked. Also it won't auto collapse existing items. I think all together that is more useable.

General:
 - We have smaller size font for links (probably regular text font is larger than it suppose to be).
 - Looks like you made the body wider which I think is good but making the whole page right aligned (i.e. all extra space goes to left) is not a good idea. It looks really bad in widescreen (which many developers has). We should probably follow a different approach for distributing the space (e.g. add the extra space to left until a max value is reached).
 - All code samples lost formatting and even some lost line wrapping after site migration.



Manuel Carrasco Moñino

unread,
May 10, 2014, 11:02:48 AM5/10/14
to google-web-tool...@googlegroups.com
On Sat, May 10, 2014 at 2:33 AM, 'Goktug Gokdogan' via GWT Contributors <google-web-tool...@googlegroups.com> wrote:
Pretty cool. Thanks for all the work. Also special kudos for fixing the styling for download page, it is much more elegant now!

Footer:
 - We are now missing the extra space in the bottom of the pages (the one before the footer)
 
done 

 - The area for the footer is larger and the text is closer to the bottom - I think the original spacing was better. Also if you take a look at the overview page you will see the footer hides part of the image.

fixed css
 

Others:
 - Clicking images shows blank page - perhaps just a deployment issue

Don't see this issue, what images do you mean?
 
 - There is a broken "Advanced Topics" menu item - I think it is mixed up with the Logging menu item.

Fixed, the logging item was indented wrong
 
 - I would put "Optimize" to Advanced topics. Perhaps security and i18n as well.

Done, I think i18n could be out. But anyway is difficult to put the edge about what are or not advanced topics
 
 - Perhaps move Community -> Developer Spotlight under Resources?

done 

 - In Resources, we can move gwt surveys to the end of the list

done 


 
Below are other issues that doesn't look like regressions. Perhaps we can have some other quick wins before publishing the final version?

Menu:
 - Ideally the arrows shouldn't indent the menu items and instead menu items should be aligned by text (e.g. gmail). I'm not sure if you are reusing any widgets here; if you aren't reusing we might want to change that.

done. We dont use any widget, just html+css. gquery enhances the list adding handlers using selectors.
 
- We might want to change how menus behave. I actually like GWT Developer pages (e.g. https://developers.google.com/appengine/pricing) where menu items that are parents of the other menu items are not used as links to a content, instead they serve as a placeholder and collapses/expands based when clicked. Also it won't auto collapse existing items. I think all together that is more useable.

I have changed parents with not content (href = #)  to expand/collapse menu (See 'Advance topics' in docs).

Having parent-items with content makes the menu shorter and easy to use, like 'side bars' in google code wikis https://code.google.com/p/support/wiki/WikiSyntax#Side_navigation

I'd rather auto-collapse on, but I have set it off as you prefer.
 

General:
 - We have smaller size font for links (probably regular text font is larger than it suppose to be).

Fixed
 
 - Looks like you made the body wider which I think is good but making the whole page right aligned (i.e. all extra space goes to left) is not a good idea. It looks really bad in widescreen (which many developers has). We should probably follow a different approach for distributing the space (e.g. add the extra space to left until a max value is reached).

I dont know if I understand correctly. The width is adjusted based on media sizes, and I have set 3 sizes: wide desktop, small desktop & tablets and mobile. Also I have changed the font size (16 -> 14px) so as there is more text in the same place, and text alignment (left -> justify).

I have adjusted content padding for big desktop, I see correctly the pages, let me know if that works for you.
 
 - All code samples lost formatting and even some lost line wrapping after site migration.

Code styling has not changed for code blocks, I see these pages (current site, demo site) in the same way, maybe there is some other page wrong or some style interfering


Can you check if you see them in the same way? or send me a link or screenshot of the page which works wrong?


You can test new changes at http://gwtproject.gquery.org


- Manolo

 

Goktug Gokdogan

unread,
May 12, 2014, 3:54:09 PM5/12/14
to google-web-toolkit-contributors
On Sat, May 10, 2014 at 8:02 AM, Manuel Carrasco Moñino <man...@apache.org> wrote:



On Sat, May 10, 2014 at 2:33 AM, 'Goktug Gokdogan' via GWT Contributors <google-web-tool...@googlegroups.com> wrote:
Pretty cool. Thanks for all the work. Also special kudos for fixing the styling for download page, it is much more elegant now!

Footer:
 - We are now missing the extra space in the bottom of the pages (the one before the footer)
 
done 

 - The area for the footer is larger and the text is closer to the bottom - I think the original spacing was better. Also if you take a look at the overview page you will see the footer hides part of the image.

fixed css
 

Others:
 - Clicking images shows blank page - perhaps just a deployment issue

Don't see this issue, what images do you mean?
 

 
 - There is a broken "Advanced Topics" menu item - I think it is mixed up with the Logging menu item.

Fixed, the logging item was indented wrong
 
 - I would put "Optimize" to Advanced topics. Perhaps security and i18n as well.

Done, I think i18n could be out. But anyway is difficult to put the edge about what are or not advanced topics
 
 - Perhaps move Community -> Developer Spotlight under Resources?

done 

 - In Resources, we can move gwt surveys to the end of the list

done 


 
Below are other issues that doesn't look like regressions. Perhaps we can have some other quick wins before publishing the final version?

Menu:
 - Ideally the arrows shouldn't indent the menu items and instead menu items should be aligned by text (e.g. gmail). I'm not sure if you are reusing any widgets here; if you aren't reusing we might want to change that.

done. We dont use any widget, just html+css. gquery enhances the list adding handlers using selectors.
 
- We might want to change how menus behave. I actually like GWT Developer pages (e.g. https://developers.google.com/appengine/pricing) where menu items that are parents of the other menu items are not used as links to a content, instead they serve as a placeholder and collapses/expands based when clicked. Also it won't auto collapse existing items. I think all together that is more useable.

I have changed parents with not content (href = #)  to expand/collapse menu (See 'Advance topics' in docs).

Having parent-items with content makes the menu shorter and easy to use, like 'side bars' in google code wikis https://code.google.com/p/support/wiki/WikiSyntax#Side_navigation

I'd rather auto-collapse on, but I have set it off as you prefer.
 

Even if you look at the menu in that wiki page, you will see that parent menu items are not acting as links to their own content instead they are just placeholders for grouping and  will collapse/expand on click. I think that is the most intuitive and what we should do in the long run, however that might require some work to move the content to child pages.

Nevertheless I think the last version is problematic:
 - Having menu item sometimes collapse sometimes not collapse when clicked is not user friendly as they will behave inconsistently.
 - As it is difficult and not easy to discover how to collapse a menu with content after it is expanded, it can become annoying for users to not have auto-collapse enabled on navigation.

So I think we should either keep the old behavior (i.e. auto-collapse) or move the new behavior (no content association for ALL parent menus, expand and collapse on click,  NO auto-collapse).
Again the second option is ideal from my point of view but we may want to do it later for reducing the amount work.

 

General:
 - We have smaller size font for links (probably regular text font is larger than it suppose to be).

Fixed
 
 - Looks like you made the body wider which I think is good but making the whole page right aligned (i.e. all extra space goes to left) is not a good idea. It looks really bad in widescreen (which many developers has). We should probably follow a different approach for distributing the space (e.g. add the extra space to left until a max value is reached).

I dont know if I understand correctly. The width is adjusted based on media sizes, and I have set 3 sizes: wide desktop, small desktop & tablets and mobile. Also I have changed the font size (16 -> 14px) so as there is more text in the same place, and text alignment (left -> justify).

I have adjusted content padding for big desktop, I see correctly the pages, let me know if that works for you.

LGTM. It looks like it distributes the spacing evenly for left and right sight. I would use less padding before the leftnav but this is mostly ok.

I'm not sure if this is a new problem or not but now when you switch through menu items, left nav sometimes jumps around. It looks this is related to scrollbar being shown on the right or not. Perhaps you can use the scrollbar only for the content bar to prevent that from happening.
 
 
 - All code samples lost formatting and even some lost line wrapping after site migration.

Code styling has not changed for code blocks, I see these pages (current site, demo site) in the same way, maybe there is some other page wrong or some style interfering


Can you check if you see them in the same way? or send me a link or screenshot of the page which works wrong?


I know this is not a regression - as I noted earlier, all of my comments on the second part are already existing problems. The code examples was broken when we moved to gwtproject.org.
 - We don't have syntax highlighting for example code (you can see that in the pages that you have linked)
 - Content is not formatted at all in some sample codes (see http://gwtproject.gquery.org/doc/latest/tutorial/JUnit.html#write) - I guess I only saw a few of them.

We can defer all these stuff, just pointed in case if they are easy to fix.
 

You can test new changes at http://gwtproject.gquery.org


- Manolo

 

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.

Julien Dramaix

unread,
May 13, 2014, 7:26:43 AM5/13/14
to google-web-tool...@googlegroups.com
>>> Others:
>>>  - Clicking images shows blank page - perhaps just a deployment issue
>>
>>
>> Don't see this issue, what images do you mean?
>>  
>
> Click devmode screenshot in http://gwtproject.gquery.org/gettingstarted.html
 
This issue already exists in the production website. I created a bug to track it and I propose to fix it later in another patch : https://code.google.com/p/google-web-toolkit/issues/detail?id=8707

> So I think we should either keep the old behavior (i.e. auto-collapse) or move the new behavior (no content association for ALL parent menus, expand and collapse on click,  NO auto-collapse).
> Again the second option is ideal from my point of view but we may want to do it later for reducing the amount work.

I'm more in favor of the second option also.


> I know this is not a regression - as I noted earlier, all of my comments on the second part are already existing problems. The code examples was broken when we moved to gwtproject.org.
> - We don't have syntax highlighting for example code (you can see that in the pages that you have linked)
> - Content is not formatted at all in some sample codes (see http://gwtproject.gquery.org/doc/latest/tutorial/JUnit.html#write) - I guess I only saw a few of them.

> We can defer all these stuff, just pointed in case if they are easy to fix.

Indeed we should defer these stuff. During the gwt-meetup, I would like to propose and discuss of a possible revamp of the website. During this revamp, we could fixe all these problems.

I propose that Manolo (thanks again for the good job) fixes the behavior of the menu according to the Goktug second option and then merge his patches in order that we can deploy this version in production. This version improves a lot the existing web site and I would like to add a search box (using google custom search) asap.

Julien


Goktug Gokdogan

unread,
May 13, 2014, 3:23:25 PM5/13/14
to google-web-toolkit-contributors

Manuel Carrasco Moñino

unread,
May 21, 2014, 5:08:19 AM5/21/14
to google-web-tool...@googlegroups.com
All your suggestions are done and committed to gerrit.

Demo instance has been updated with those changes: http://gwtproject.gquery.org 

- Manolo


Julien Dramaix

unread,
May 21, 2014, 6:34:39 AM5/21/14
to google-web-tool...@googlegroups.com
Thanks for the good job Manolo ! The mobile version of the site is really better now.

I've deployed the new version in production : http://www.gwtproject.org/ 

Julien


Manuel Carrasco Moñino

unread,
May 21, 2014, 1:11:09 PM5/21/14
to google-web-tool...@googlegroups.com
Hi Julien, it seems sourcemap has not been uploaded, Brian uses them.

- Manolo


Goktug Gokdogan

unread,
May 21, 2014, 1:40:35 PM5/21/14
to google-web-toolkit-contributors
Great job! Everything looks/behaves flawlessly. Much appreciated!


Julien Dramaix

unread,
May 21, 2014, 1:59:26 PM5/21/14
to google-web-tool...@googlegroups.com

Julien Dramaix

unread,
May 21, 2014, 5:45:03 PM5/21/14
to google-web-tool...@googlegroups.com
> Hi Julien, it seems sourcemap has not been uploaded, Brian uses them.
It should be ok now.

Julien


Reply all
Reply to author
Forward
0 new messages