Last call for GWT 2.8.0 RC2

454 views
Skip to first unread message

Daniel Kurka

unread,
Aug 9, 2016, 9:37:59 PM8/9/16
to google-web-tool...@googlegroups.com
Hi all,

I think we have all patches in place for putting out an RC2.
If you feel strongly that something should make RC2 please raise this on this thread. I will be cutting RC2 tomorrow PST time.

-Daniel

Kay-Uwe Janssen

unread,
Aug 10, 2016, 3:29:47 AM8/10/16
to GWT Contributors
I thought I have read somewhere that you added support for default methods in request factory proxy interfaces. Am I wrong with this or is there just something broken?

I just tried to add a default method to one of my proxies using gwt 2.8.0-rc1 and it tells me that only getter and setter are allowed and that there is no domain method similar to *signature*.

Thanks,
Kay

Jens

unread,
Aug 10, 2016, 4:13:45 AM8/10/16
to GWT Contributors

If you feel strongly that something should make RC2 please raise this on this thread. I will be cutting RC2 tomorrow PST time.

To avoid incorrect warnings: https://gwt-review.googlesource.com/#/c/16540/ 

Colin Alworth

unread,
Aug 10, 2016, 12:25:05 PM8/10/16
to GWT Contributors
Kay, can you offer a reproducible example of this, and confirm that you have no older copy of GWT (like gwt-user/gwt-dev from 2.8.0-beta1) on your classpath? To test this, I just built some quick autobeans in a simple project (so that I didn't need a full server to back it):

public DefaultMethodInGeneratorTest implements EntryPoint {
    @Override
    public void onModuleLoad() {
        ABF abf = GWT.create(ABF.class);
        abf.bean().as().buildName();
    }

    public interface ABF extends AutoBeanFactory {
        AutoBean<SampleBean> bean();
    }


    public interface SampleBean {
        String getFirstName();
        String getLastName();
        default String buildName() {
            return getLastName() + ", " + getFirstName();
        }
    }
}

This compiles correctly (for me, with 2.8.0-RC1), even though in prior GWT versions you would need to list buildName() as a @Category.

On Wed, Aug 10, 2016 at 3:13 AM Jens <jens.ne...@gmail.com> wrote:

If you feel strongly that something should make RC2 please raise this on this thread. I will be cutting RC2 tomorrow PST time.

To avoid incorrect warnings: https://gwt-review.googlesource.com/#/c/16540/ 

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/0f8eca73-e432-4074-bb26-019f12b724a3%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Kay-Uwe Janssen

unread,
Aug 11, 2016, 2:46:01 AM8/11/16
to GWT Contributors
I just tested your example. THIS compiles and works but when trying to add a default (or static) i get the said errors. maybe the requestfactory apt processor is not correctly updated to the new features?

I have checked that I have all gwt-* dependencies (including requestfactory-apt and requestfactory-server) with version 2.8-rc1. 


Am Mittwoch, 10. August 2016 18:25:05 UTC+2 schrieb Colin Alworth:
Kay, can you offer a reproducible example of this, and confirm that you have no older copy of GWT (like gwt-user/gwt-dev from 2.8.0-beta1) on your classpath? To test this, I just built some quick autobeans in a simple project (so that I didn't need a full server to back it):

public DefaultMethodInGeneratorTest implements EntryPoint {
    @Override
    public void onModuleLoad() {
        ABF abf = GWT.create(ABF.class);
        abf.bean().as().buildName();
    }

    public interface ABF extends AutoBeanFactory {
        AutoBean<SampleBean> bean();
    }


    public interface SampleBean {
        String getFirstName();
        String getLastName();
        default String buildName() {
            return getLastName() + ", " + getFirstName();
        }
    }
}

This compiles correctly (for me, with 2.8.0-RC1), even though in prior GWT versions you would need to list buildName() as a @Category.

On Wed, Aug 10, 2016 at 3:13 AM Jens <jens.ne...@gmail.com> wrote:

If you feel strongly that something should make RC2 please raise this on this thread. I will be cutting RC2 tomorrow PST time.

To avoid incorrect warnings: https://gwt-review.googlesource.com/#/c/16540/ 

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.

Kay-Uwe Janssen

unread,
Aug 11, 2016, 2:58:22 AM8/11/16
to GWT Contributors
> I just tested your example. THIS compiles and works but when trying to add a default (or static) i get the said errors. maybe the requestfactory apt processor is not correctly updated to the new features?

fixed missing words:
I just tested your example. THIS compiles and works but when trying to add a default (or static) to a requestfactory proxy i get the said errors. maybe the requestfactory apt processor is not correctly updated to the new features?


e.g. this inteface:
@ProxyFor(value = Test.class)
public interface TextProxy extends ValueProxy {

default String getTest() {
return "";
}

static String getTest2() {
return "";
}

}


generates the following errors:
Could not find domain method similar to java.lang.String getTest()
Could not find domain method similar to java.lang.String getTest2()

when removing the "get" ( having "test()" and "test2()") it has those errros:
Could not find domain method similar to java.lang.String test()
Could not find domain method similar to java.lang.String test2()
Only getters and setters allowed
Only getters and setters allowed

Kirill Prazdnikov

unread,
Aug 11, 2016, 4:47:46 AM8/11/16
to GWT Contributors
I would be nice to have performance of String(char[],int,int) fixed as suggested.

Kay-Uwe Janssen

unread,
Aug 12, 2016, 2:00:30 AM8/12/16
to GWT Contributors
This issue is still present with RC2. :(

I'll try to build a small repro project.

Kay-Uwe Janssen

unread,
Aug 12, 2016, 3:02:16 AM8/12/16
to GWT Contributors
here is a small project to reproduce the issue: https://github.com/issuerepro/gwt-rf-default-static

just run: mvnw compile

Thomas Broyer

unread,
Aug 12, 2016, 9:51:24 AM8/12/16
to GWT Contributors
I believe the ValidationTool would need to be updated, but you can probably get it to work by adding the appropriate annotation (can't remember the exact name)

Kay-Uwe Janssen

unread,
Aug 15, 2016, 4:15:05 AM8/15/16
to GWT Contributors
Hello Thomas,

thank you for the hint. I just found the  @SkipInterfaceValidation annotation in com.google.web.bindery.requestfactory.shared. 

This compiles and works but if possible it would still be nice to have the ValidationTool / APT-Processor updated for 2.8.0.

Thank you! :)
Reply all
Reply to author
Forward
0 new messages