Re: Added new public static method to Window.Location: reloadParameterMap. (issue1859804)

8 views
Skip to first unread message

skyb...@google.com

unread,
Nov 8, 2012, 1:49:32 PM11/8/12
to per...@google.com, cromw...@gmail.com, google-web-tool...@googlegroups.com, re...@gwt-code-reviews-hr.appspotmail.com

http://gwt-code-reviews.appspot.com/1859804/diff/7001/user/src/com/google/gwt/user/client/Window.java
File user/src/com/google/gwt/user/client/Window.java (right):

http://gwt-code-reviews.appspot.com/1859804/diff/7001/user/src/com/google/gwt/user/client/Window.java#newcode322
user/src/com/google/gwt/user/client/Window.java:322: listParamMap =
buildListParamMap(currentQueryString);
since the query string has changed, you need to set paramMap to null (or
rebuild it). Otherwise, the next time ensureParameterMap is called, it
will think that nothing needs to be done.

http://gwt-code-reviews.appspot.com/1859804/diff/7001/user/src/com/google/gwt/user/client/Window.java#newcode344
user/src/com/google/gwt/user/client/Window.java:344: cachedQueryString =
currentQueryString;
since the query string has changed, you need to set listParamMap to null
(or rebuild it).

I'm not sure why we have two separate variables, actually. Perhaps
paramMap can go away and getParameter() could use listParamMap?

http://gwt-code-reviews.appspot.com/1859804/
Reply all
Reply to author
Forward
0 new messages