UiBinder. Add tests for horizontal/vertical alignment parsers. (issue633801)

2 views
Skip to first unread message

Konstanti...@gmail.com

unread,
Jun 17, 2010, 4:52:37 AM6/17/10
to Konstanti...@gmail.com, google-web-tool...@googlegroups.com, re...@gwt-code-reviews.appspotmail.com
Reviewers: ,

Description:
I would like to start contributing small changes into UiBinder, mostly
to make it better for GWT Designer.

For beginning I want to contribute two tests.

BTW, why these parsers use so unfriendly names for alignments?
"ALIGN_RIGHT" looks not very good in XML. Why not just "right"?


http://code.google.com/p/google-web-toolkit/issues/detail?id=5028

Please review this at http://gwt-code-reviews.appspot.com/633801/show

Affected files:
user/test/com/google/gwt/uibinder/UiBinderJreSuite.java

user/test/com/google/gwt/uibinder/attributeparsers/HorizontalAlignmentConstantParser_Test.java

user/test/com/google/gwt/uibinder/attributeparsers/VerticalAlignmentConstantParser_Test.java


j...@google.com

unread,
Jun 21, 2010, 9:24:09 AM6/21/10
to Konstanti...@gmail.com, google-web-tool...@googlegroups.com, re...@gwt-code-reviews.appspotmail.com
On 2010/06/17 08:52:37, Konstantin.Scheglov wrote:


Thanks, LGTM. Submitted at r8281.


http://gwt-code-reviews.appspot.com/633801/show

Reply all
Reply to author
Forward
0 new messages