Re: ValueListBox should implement HasEnabled (6112) (issue1832803)

[tuck...@gmail.com]

On 2012/09/16 02:36:41, Patrick Tucker wrote:

Anybody?

http://gwt-code-reviews.appspot.com/1832803/

[mdem...@google.com]

Thanks for the patch! But do you mind reuploading it to
https://gwt-review.googlesource.com/gwt so we can review and merge it
there?

http://gwt-code-reviews.appspot.com/1832803/

[mdem...@google.com]

On 2013/05/16 19:35:21, mdempsky wrote:
> Thanks for the patch! But do you mind reuploading it to
> https://gwt-review.googlesource.com/gwt so we can review and merge it
there?

Oops, sorry, the link is just https://gwt-review.googlesource.com

http://gwt-code-reviews.appspot.com/1832803/

[Patrick Tucker]

I would be more than happy to but I can't seem to get gwt-dev, gwt-servlet, gwt-user,... under master to work when I check them out in eclipse.  Eclipse tells me the source folders do not exist when they do.  I'm not familiar with GIT so I'm at a loss.

[John A. Tamplin]

On Fri, May 17, 2013 at 6:11 AM, Patrick Tucker <tuck...@gmail.com> wrote:

I would be more than happy to but I can't seem to get gwt-dev, gwt-servlet, gwt-user,... under master to work when I check them out in eclipse.  Eclipse tells me the source folders do not exist when they do.  I'm not familiar with GIT so I'm at a loss. 

Did you setup Eclipse correctly, as documented in eclipse/README.txt?

--
John A. Tamplin

[Patrick Tucker]

I'm not sure where to find the file that you are referring to, it is not in my eclipse install folder?

 

I'm using a 64 bit version of Juno, have been since it was released.  I have had no issues with the other 12 or so projects that are loaded.

 

I was playing with the settings and tried removing one of the source folders so that I could add it back and got an error saying the file system is read only.  Any idea why it would do that?

 

When I cloned the repository, I entered the username and password that was provided by the "HTTP Password" site.

 

Thanks,

Pat

[Matthew Dempsky]

On Fri, May 17, 2013 at 9:45 AM, Patrick Tucker <tuck...@gmail.com> wrote:

I'm not sure where to find the file that you are referring to, it is not in my eclipse install folder?

John was referring to the "eclipse" directory in the GWT source code tree: https://gwt.googlesource.com/gwt/+/master/eclipse/README.txt

I was playing with the settings and tried removing one of the source folders so that I could add it back and got an error saying the file system is read only.  Any idea why it would do that?

Not sure, that sounds odd to me.  Just out of curiosity, what OS are you using?

When you prepared the patch from Rietveld, did you checkout the code from Subversion or use the 2.5.1 SDK release zip file?  If you were already using Subversion, I would expect using Git shouldn't be any different to setup in Eclipse since the source tree should be the same.

[Patrick Tucker]

Windows 7 Pro

[Patrick Tucker]

I started from scratch and was able to get it mostly working.  Is there a doc that explains the right way to submit a patch?

[Thomas Broyer]

Should be http://gwtproject.org/makinggwtbetter.html

[Patrick Tucker]

From the gwtproject "Making GWT Better" page section "Gerrit Setup" step 3:

Make a change and commit it locally using git (e.g., edit a file foo and then run ?git commit -m ?my first change? foo?).

 

What does foo represent?

 

Thanks,

Pat

[Daniel Kurka]

Hi Patrick,

foo is often used as a place holder, so something like:

git add foo 

should mean:

git add my_cool_edited_file

-Daniel

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

--

Google Germany GmbH

Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens

[Patrick Tucker]

Thanks for the quick response, but that doesn't answer my question.

 

I realize foo is a place holder, I'm trying to figure out what it represents.  A file, a message to the reviewers, ...  I'm trying to figure out what I should replace it with.

 

Thanks again,

Pat

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to a topic in the Google Groups "GWT Contributors" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit-contributors/hJzwtP-zEZw/unsubscribe?hl=en-US.
To unsubscribe from this group and all its topics, send an email to google-web-toolkit-co...@googlegroups.com.

[Patrick Tucker]

Well I just wasted another few hours this morning trying to figure out how to commit something to this new system.

 

Are these instructions complete??

 

Currently when I try to do a "git push" it tells me I have to provide a Change-Id.  I copied the hook file to the hooks folder and the message did not go away.  The command that GIT tells me to run executes chmod in it, being that I am on a windows machine it obviously fails.  The online help page also tells me to execute the same command.

 

I'm at a loss.

To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.
 
 

--

Google Germany GmbH

Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to a topic in the Google Groups "GWT Contributors" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit-contributors/hJzwtP-zEZw/unsubscribe?hl=en-US.

To unsubscribe from this group and all its topics, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.

[Thomas Broyer]

On Mon, Jun 10, 2013 at 3:35 PM, Patrick Tucker <tuck...@gmail.com> wrote:

> From the gwtproject "Making GWT Better" page section "Gerrit Setup" step 3:
>>
>> Make a change and commit it locally using git (e.g., edit a file foo and
>> then run ?git commit -m ?my first change? foo?).
>
>
> What does foo represent?

The file(s) you want to commit (automatically does a "git add")
http://git-scm.com/docs/git-commit


--
Thomas Broyer
/tɔ.ma.bʁwa.je/

[Brian Slesinsky]

+mdempsky

Hi, I think you're going to have more trouble than most because you're using Windows and that's not so common for GWT development. The code to automatically add the Change-Id line is specific to Unix but you can do it manually by editing the changelist yourself. To fix your most recent commit, run "git commit --amend" and cut and paste the Change-Id line from the error message to the end of the commit message.

(I believe each commit has to have its own Change-Id line and will be reviewed separately? Not sure how that works.)

- Brian

To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.