Compiler Faiure

[Manuel Carrasco Moñino]

Hi all,

Do anyone knows what could change lately which makes the compiler fail if jetty annotations is in your classpath.

The way to reproduce is compiling any project which jetty-annotations.jar before  before gwt-dev.jar.

Attached trace.

[Roberto Lublinerman]

This seems to be the error:

java.lang.IncompatibleClassChangeError: class com.google.gwt.dev.javac.asm.CollectMethodData has interface org.objectweb.asm.MethodVisitor as super class

and the problem seems to be that you have ASM < 5 in your class path. (It seems that MethodVisitor was an interface in ASM < 4 and is now an abstract class.

2.7 no longer rebases ASM

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAM28XAtxtLYTr43FBqwm7-CLFMkGVcS2Oi9-vPP6MdpkqqPw_w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Manuel Carrasco Moñino]

Thank Roberto, that is the key, everything works if I exclude the asm transitive dependency in my pom

      <dependency>

            <groupId>org.eclipse.jetty</groupId>

            <artifactId>jetty-annotations</artifactId>

            <exclusions>

                <exclusion>

                        <artifactId>org.objectweb.asm</artifactId>

                        <groupId>org.eclipse.jetty.orbit</groupId>

                </exclusion>

            </exclusions>

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAC7T7gmTDSDYfCPzVg5o1AEXzHNcrXhLL91iWv_n%2BJsVJ-oNxA%40mail.gmail.com.

[Ray Cromwell]

We kind of knew this sort of incompatibility would happen, but I still
think GWT should continue get out of the business of rebasing
everything. We should even have a version of the JAR that can use
dynamic dependencies.



On Wed, Oct 1, 2014 at 3:16 PM, Manuel Carrasco Moñino

> https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAM28XAvmpneRqr1LLry_C612U7PsdY-raj9fPo_5ysAJ3qoGaw%40mail.gmail.com.

[Manuel Carrasco Moñino]

On Thu, Oct 2, 2014 at 12:28 AM, 'Ray Cromwell' via GWT Contributors <google-web-tool...@googlegroups.com> wrote:

We kind of knew this sort of incompatibility would happen, but I still
think GWT should continue get out of the business of rebasing
everything.

 

We should even have a version of the JAR that can use
dynamic dependencies.

I think this is a good option. Can we go with it? 

 

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAPVRV7fUFGt8ksPPoPTwhxUN2xBjVLLoJ%2B%3DbooMpDoy6cN5wWg%40mail.gmail.com.

[Thomas Broyer]

On Thursday, October 2, 2014 2:33:29 PM UTC+2, Manuel Carrasco Moñino wrote:

On Thu, Oct 2, 2014 at 12:28 AM, 'Ray Cromwell' via GWT Contributors <google-web-toolkit-contri...@googlegroups.com> wrote:

We kind of knew this sort of incompatibility would happen, but I still
think GWT should continue get out of the business of rebasing
everything.

 

We should even have a version of the JAR that can use
dynamic dependencies.

I think this is a good option. Can we go with it? 

I'm currently updating the scripts that push JARs to Maven to unbundle ASM, along with the POMs to add the dependency on ASM.

I'll also add dependencyManagement to com.google.gwt:gwt and com.google.web.bindery:requestfactory (aka make them "bills of material") so you could use them with <scope>import</scope> in your dependencyManagement to make sure you use everything with the same version, even when some deps are transitive (e.g. you use a lib that depends on gwt-dev with a version different than the one you use for gwt-user; dependencyManagement helps solve these issues).

Other deps we could easily replace with non-rebased ones are Guava and Protobuf.

[Manuel Carrasco Moñino]

Thank Thomas for fixing this.

--

You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/7b0c9a48-094a-4782-a362-52828a9505ee%40googlegroups.com.