Changes to maven dependencies makes GwtTest fail

[Ignacio Baca Moreno-Torres]

I'm updating the old mojo plugin and one of the IT throws this stacktrace. I'm investigating, but I post it here now just in case that anyone are already aware. I see that some dependencies and source code has been excluded from gwt-dev, and looks like org/apache/commons has been excluded but commons-lang3 has not been added as a maven dependency, is this in purpose?

[INFO] testSetTranslation(fr.salvadordiaz.gwt.client.FailTestGwt)  Time elapsed: 0.618 sec  <<< ERROR!
[INFO] java.lang.NoClassDefFoundError: org/apache/commons/lang3/builder/HashCodeBuilder
[INFO]     at com.gargoylesoftware.htmlunit.BrowserVersion.hashCode(BrowserVersion.java:731)
[INFO]     at java.util.HashMap.hash(HashMap.java:338)
[INFO]     at java.util.HashMap.put(HashMap.java:611)
[INFO]     at com.google.gwt.junit.RunStyleHtmlUnit.addBrowser(RunStyleHtmlUnit.java:211)
[INFO]     at com.google.gwt.junit.RunStyleHtmlUnit.<clinit>(RunStyleHtmlUnit.java:202)
[INFO]     at java.lang.Class.forName0(Native Method)
[INFO]     at java.lang.Class.forName(Class.java:264)
[INFO]     at com.google.gwt.junit.JUnitShell.createRunStyle(JUnitShell.java:1179)
[INFO]     at com.google.gwt.junit.JUnitShell.doStartup(JUnitShell.java:940)
[INFO]     at com.google.gwt.dev.DevModeBase.startUp(DevModeBase.java:913)
[INFO]     at com.google.gwt.junit.JUnitShell.getUnitTestShell(JUnitShell.java:696)
[INFO]     at com.google.gwt.junit.JUnitShell.runTest(JUnitShell.java:670)
[INFO]     at com.google.gwt.junit.client.GWTTestCase.runTest(GWTTestCase.java:421)
[INFO]     at junit.framework.TestCase.runBare(TestCase.java:134)
[INFO]     at junit.framework.TestResult$1.protect(TestResult.java:110)
[INFO]     at junit.framework.TestResult.runProtected(TestResult.java:128)
[INFO]     at junit.framework.TestResult.run(TestResult.java:113)
[INFO]     at junit.framework.TestCase.run(TestCase.java:124)
[INFO]     at com.google.gwt.junit.client.GWTTestCase.run(GWTTestCase.java:247)
[INFO]     at junit.framework.TestSuite.runTest(TestSuite.java:232)
[INFO]     at junit.framework.TestSuite.run(TestSuite.java:227)
[INFO]     at junit.framework.TestSuite.runTest(TestSuite.java:232)
[INFO]     at junit.framework.TestSuite.run(TestSuite.java:227)
[INFO]     at junit.framework.TestSuite.runTest(TestSuite.java:232)
[INFO]     at junit.framework.TestSuite.run(TestSuite.java:227)
[INFO]     at org.codehaus.mojo.gwt.test.MavenTestRunner.doRun(MavenTestRunner.java:105)
[INFO]     at junit.textui.TestRunner.start(TestRunner.java:180)
[INFO]     at org.codehaus.mojo.gwt.test.MavenTestRunner.main(MavenTestRunner.java:63)
[INFO] Caused by: java.lang.ClassNotFoundException: org.apache.commons.lang3.builder.HashCodeBuilder
[INFO]     at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
[INFO]     at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
[INFO]     at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
[INFO]     at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
[INFO]     ... 28 more
[INFO] Caused by: java.lang.ClassNotFoundException: org.apache.commons.lang3.builder.HashCodeBuilder
[INFO]     at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
[INFO]     at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
[INFO]     at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
[INFO]     at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
[INFO]     ... 28 more

[Thomas Broyer]

Oops? Will fix asap.

(how about excluding HTMLUnit as a whole? only keeping JDT bundled as we're using a patched version)

[Thomas Broyer]

Oh, BTW, please file an issue: we must not release RC1 before this is fixed.

+daniel

[Thomas Broyer]

https://gwt-review.googlesource.com/15352

Tested locally by running the integration tests from my gwt-maven-plugin, which includes GWTTestCase.

Notice the followup change at https://gwt-review.googlesource.com/15353: interestingly, the jdtCompilerAdapter.jar including within gwt-dev is not actually needed (we also include java_cup which I'm not sure is actually needed (anymore?); I've removed it from Maven jar and it didn't break my tests)

On Wednesday, June 29, 2016 at 10:12:08 PM UTC+2, Ignacio Baca Moreno-Torres wrote: