Move non-GWTTestCase tests in RpcSuite to RpcSuiteNoBrowser, (issue1868803)

15 views
Skip to first unread message

skyb...@google.com

unread,
Nov 15, 2012, 4:42:42 PM11/15/12
to mdem...@google.com, google-web-tool...@googlegroups.com, re...@gwt-code-reviews-hr.appspotmail.com
Reviewers: mdempsky,

Description:
Move non-GWTTestCase tests in RpcSuite to RpcSuiteNoBrowser,
so they don't unnecessarily get run multiple times in different browser
environments.
Also fix the build to handle running *SuiteNoBrowser suites.

Review by: mdem...@google.com

Please review this at http://gwt-code-reviews.appspot.com/1868803/

Affected files:
M user/build.xml
M user/test/com/google/gwt/user/RPCSuite.java
A user/test/com/google/gwt/user/RpcSuiteNoBrowser.java


mdem...@google.com

unread,
Nov 15, 2012, 4:43:21 PM11/15/12
to skyb...@google.com, google-web-tool...@googlegroups.com, re...@gwt-code-reviews-hr.appspotmail.com
LGTM

http://gwt-code-reviews.appspot.com/1868803/

Thomas Broyer

unread,
Nov 16, 2012, 3:20:20 AM11/16/12
to google-web-tool...@googlegroups.com, mdem...@google.com, re...@gwt-code-reviews-hr.appspotmail.com, skyb...@google.com
Should we rename the *JreSuite in e.g. RequestFactory to *SuiteNoBrowser too? I kind of like this naming scheme, easier to deal with than *Suite vs. *JreSuite.

Brian Slesinsky

unread,
Nov 16, 2012, 3:37:36 PM11/16/12
to Thomas Broyer, google-web-tool...@googlegroups.com, mdem...@google.com, re...@gwt-code-reviews-hr.appspotmail.com
On Fri, Nov 16, 2012 at 12:20 AM, Thomas Broyer <t.br...@gmail.com> wrote:
> Should we rename the *JreSuite in e.g. RequestFactory to *SuiteNoBrowser
> too? I kind of like this naming scheme, easier to deal with than *Suite vs.
> *JreSuite.

Good point, I hadn't seen those. Yes I like my name better :-)

- Brian
Reply all
Reply to author
Forward
0 new messages