tools SVN repository

89 views
Skip to first unread message

Manuel Carrasco Moñino

unread,
Mar 23, 2014, 6:56:12 AM3/23/14
to google-web-tool...@googlegroups.com

I have not found any info about what the the to update the tools repository, are there some conventions/proceedings?

Thanks
- Manolo 

Thomas Broyer

unread,
Mar 23, 2014, 6:35:42 PM3/23/14
to google-web-tool...@googlegroups.com
Only Google has commit rights. Generally, changes are proposed on Gerrit that need new JARs in tools (so the precheck fails), and if the reviewers think it's worth it, they add the JARs to the tools repo before merging.

Jens

unread,
Mar 31, 2014, 4:01:09 PM3/31/14
to google-web-tool...@googlegroups.com
Only Google has commit rights. Generally, changes are proposed on Gerrit that need new JARs in tools (so the precheck fails), and if the reviewers think it's worth it, they add the JARs to the tools repo before merging.

Any chance to move the svn tools repo to git (and maybe make it a submodule of gwt)? With the svn repo being obsolete it is already missing a 2.6.0 tag. It might become difficult in the future to build older GWT versions if svn tools continue to change without tagging.

-- J.

Thomas Broyer

unread,
Apr 1, 2014, 5:23:35 AM4/1/14
to google-web-tool...@googlegroups.com


On Monday, March 31, 2014 10:01:09 PM UTC+2, Jens wrote:
Only Google has commit rights. Generally, changes are proposed on Gerrit that need new JARs in tools (so the precheck fails), and if the reviewers think it's worth it, they add the JARs to the tools repo before merging.

Any chance to move the svn tools repo to git (and maybe make it a submodule of gwt)?

Please no!
Git is not made to store binaries; and any DVCS would mean that you copy the whole repo, whereas SVN allows checking out only a subdir if you want.
(that said, GWT_TOOLS is managed as an "append only" repo, so it's a bit less of a problem if one would migrate it to some DVCS like Git)

What we need (and I'm working towards that) is to get rid of GWT_TOOLS, at least as a "svn checkout" preliminary step before you can build.
We should be able to use many libs right from Central (e.g. Jetty, HtmlUnit, JUnit), and for others, either we deploy them to Central (Vaadin already deployed a few of them) or make sure the build tool can download them from GWT_TOOLS as needed.
 
With the svn repo being obsolete it is already missing a 2.6.0 tag. It might become difficult in the future to build older GWT versions if svn tools continue to change without tagging.

GWT_TOOLS was never tagged.
It's "append only" so you should be able to build any revision of GWT against the latest revision of GWT_TOOLS. You should never need to checkout a specific revision of GWT_TOOLS.

Jens

unread,
Apr 1, 2014, 5:42:12 AM4/1/14
to google-web-tool...@googlegroups.com
GWT_TOOLS was never tagged.
It's "append only" so you should be able to build any revision of GWT against the latest revision of GWT_TOOLS. You should never need to checkout a specific revision of GWT_TOOLS.

Didn't know that. Then there isn't a problem anyways. 

-- J.
Reply all
Reply to author
Forward
0 new messages