Possible bug in DOMImplMozilla

0 views
Skip to first unread message

Thomas Broyer

unread,
Jan 3, 2010, 2:37:26 PM1/3/10
to Google Web Toolkit Contributors
Hi googlers,

In DOMImplMozilla's initSyntheticMouseUpEvents is a reference to
$wnd.__captureElem, which is never set (or read) anywhere, making the
workaround fail as being no-op in practice.
Shouldn't it be
@com.google.gwt.user.client.impl.DOMImplStandard::captureElem instead?

Joel Webber

unread,
Jan 4, 2010, 2:37:32 PM1/4/10
to google-web-tool...@googlegroups.com, John LaBanca
Looks like you're right about that.
@jlabanca: Correct me if I'm wrong, but didn't you refactor this stuff a while back? Mind having a look to make sure I'm not missing something?

John LaBanca

unread,
Jan 4, 2010, 4:39:54 PM1/4/10
to Joel Webber, google-web-tool...@googlegroups.com
I'll look into it tomorrow morning.

Thanks,
John LaBanca
jlab...@google.com

John LaBanca

unread,
Jan 5, 2010, 11:05:26 AM1/5/10
to Joel Webber, google-web-tool...@googlegroups.com
It looks like this was broken way back in r2661 when we switched from $wnd.__captureElement to a static field in DOMImplStandard.  I'm fixing it now and testing the code.

Thanks,
John LaBanca
jlab...@google.com

John LaBanca

unread,
Jan 5, 2010, 11:54:16 AM1/5/10
to Joel Webber, google-web-tool...@googlegroups.com
Patch sent for review:
http://gwt-code-reviews.appspot.com/128802/show

Thanks for pointing out this bug.

Thanks,
John LaBanca
jlab...@google.com

John LaBanca

unread,
Jan 5, 2010, 12:57:02 PM1/5/10
to Joel Webber, google-web-tool...@googlegroups.com
committed as r7355

Thanks,
John LaBanca
jlab...@google.com
Reply all
Reply to author
Forward
0 new messages