Fixed issue 1394 : Need a new getSplitter() method in SplitPanel (issue1398801)

[jlab...@google.com]

LGTM

A couple of minor nits, but looks good. I'll submit it the next time I
make a pass over external submissions. I can fix the nits that I noted.

http://gwt-code-reviews.appspot.com/1398801/diff/1/user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java
File user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java
(right):

http://gwt-code-reviews.appspot.com/1398801/diff/1/user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java#newcode102
user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java:102: public
boolean hidden;
Am I correct that the hidden field always existed but is never used?

http://gwt-code-reviews.appspot.com/1398801/diff/1/user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java
File user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java
(right):

http://gwt-code-reviews.appspot.com/1398801/diff/1/user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java#newcode108
user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java:108:
private Date lastClick = new Date(0);
You can use the Duration class instead of Date to measure time.

http://gwt-code-reviews.appspot.com/1398801/diff/1/user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java#newcode151
user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java:151: if
(now.getTime() - this.lastClick.getTime() < 500) {
500 should be moved to a static constant.

http://gwt-code-reviews.appspot.com/1398801/

[tuck...@gmail.com]

Do you guys have any objections to setting hidden child widget's size to
0 instead of actually changing their display value? Changing the
display value causes Firefox, Chrome and what not to destroy child flash
objects... and setting its size to 0 seems to have caused 0 problems for
me.

http://gwt-code-reviews.appspot.com/1398801/

[jlab...@google.com]

Sounds reasonable to me.

http://gwt-code-reviews.appspot.com/1398801/

[tuck...@gmail.com]

That would be great!

It looks like this fix is also going to take care of issue 5264 via the
addition of setWidgetHidden(Widget, boolean).

Thanks!

http://gwt-code-reviews.appspot.com/1398801/