Re: Adds {moz,webkit}RequestAnimationFrame support to animations. (issue1355805)

6 views
Skip to first unread message

jlab...@google.com

unread,
Apr 7, 2011, 2:22:49 PM4/7/11
to t.br...@gmail.com, google-web-tool...@googlegroups.com, re...@gwt-code-reviews.appspotmail.com
LGTM

I'll test this out and submit it.


http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gwt/user/client/ui/DeckPanel.java
File user/src/com/google/gwt/user/client/ui/DeckPanel.java (right):

http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gwt/user/client/ui/DeckPanel.java#newcode125
user/src/com/google/gwt/user/client/ui/DeckPanel.java:125: // the rest
of the page, even if it's not visible to the user, .
extra comma

http://gwt-code-reviews.appspot.com/1355805/

jlab...@google.com

unread,
Apr 7, 2011, 2:52:51 PM4/7/11
to t.br...@gmail.com, google-web-tool...@googlegroups.com, re...@gwt-code-reviews.appspotmail.com
I verified that the animations work on IE (timer version), Chrome 10
(verified the "time" fix is needed and works) and 11, Safari 5 (which
does not support animation frames and uses the timer version), firefox
3.6 (timer version) and firefox 4.0 (moz animation frame).

I'll submit this change soon. Thanks again for the patch.


http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gwt/animation/Animation.gwt.xml
File user/src/com/google/gwt/animation/Animation.gwt.xml (right):

http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gwt/animation/Animation.gwt.xml#newcode62
user/src/com/google/gwt/animation/Animation.gwt.xml:62:
<when-property-is name="user.agent" value="webkit"/>
The user agent value should be safari instead of webkit.

http://gwt-code-reviews.appspot.com/1355805/

Reply all
Reply to author
Forward
0 new messages