jUnit Tests

[Walt Javins]

Howdy all,

I have fixes ready for issues 18 and 19.  But before I commit them, I wanted to breach the subject of jUnit tests, as I have some ready.

1) Are tests something we'd be interested in adding to the project?

+ Test cases will help prevent regression as new contributors add to the library.

+ Testing will provide a way to verify behavior without making a round trip to google voice via test.java, which can take a couple second.

+ The project will seem more respectable (?)

- jUnit is yet another dependency for development (Though, we should ignore the test suite in the build).

- Potentially slower development if contributors feel compelled to write tests.

If we do start adding test cases:

2) Should we bundle a jUnit library with the project? Or are we still assuming that everyone will continue to use Eclipse to build, and thus have access to jUnit?

3) Should the tests be intermixed with the source code or in a parallel file hierarchy (a la Maven's standard setup)? E.g.:

If tests are intermixed we'd have something like:

~/src/com/techventus/server/voice/util/SMSParser.java

~/src/com/techventus/server/voice/util/SMSParserTest.java

 

If tests are in a parallel structure it would look like:

~/src/com/techventus/server/voice/util/SMSParser.java

~/test/com/techventus/server/voice/util/SMSParserTest.java

 

Personally, I prefer the latter, as it doesn't clutter the working tree with tests.  And it arguably makes it easier to package up a .jar without the test cases (thinking about it from an ANT/Maven perspective).

Let me know what you all think!

Walt

[Matthew Blanchette]

Hi Walt,

For 1, I definitely think unit tests should be added to the project and hopefully become part of the normal development cycle.
I agree with your points and having any unit tests would be an improvement.

For 2, it depends if developers still want the build to depend on Eclipse. My advice would be to include the JUnit library in the project if using an Ant build, allowing for automated builds and testing.

For 3, I also agree to keep the test source files separate.

-Matt

--
You received this message because you are subscribed to the Google Groups "Google Voice Java" group.
To post to this group, send email to google-v...@googlegroups.com.
To unsubscribe from this group, send email to google-voice-j...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/google-voice-java?hl=en.

[Joseph Malone]

Are you guys all Committers?

[Walt Javins]

Yes.  We're both committers, according to the people list on the site.

Walt

[Tobias Eisentrager]

I am for the unit tests as well, and please keep them seperate. I will always use eclipse so I don't care so much about external builds.

Toby

>>>> ~/*src*/com/techventus/server/voice/util/SMSParser.java
>>>
>>> ~/*src*/com/techventus/server/voice/util/SMSParserTest.java

>>>
>>>
>>> If tests are in a parallel structure it would look like:
>>>

>>>> ~/*src*/com/techventus/server/voice/util/SMSParser.java
>>>
>>> ~/*test*/com/techventus/server/voice/util/SMSParserTest.java

[Jeferson Lesbao]

without doubt unit test are indispensable for a good software project. yet Google Voice. the unit tests and integration test has become a international pattern, in my opinion we must start with the tests as soon as possible;
Jeferson L Siqueira. a.k.a - aajjbb

[Jeferson Lesbao]

just to accomplish.. about the eclipse build and the separated test sources. i made Matthew my words

[JM]

I am still waiting for someone to post some unit test code!!!