[google-toolbox-for-mac] r558 committed - [Author: dmaclach]...

3 views
Skip to first unread message

google-tool...@googlecode.com

unread,
Jul 26, 2012, 4:30:24 PM7/26/12
to google-tool...@googlegroups.com
Revision: 558
Author: gtm.daemon
Date: Thu Jul 26 13:30:11 2012
Log: [Author: dmaclach]

Fix up another case of bad format string handling by various versions of
Xcode.

R=thomasvl
DELTA=15 (15 added, 0 deleted, 0 changed)
http://code.google.com/p/google-toolbox-for-mac/source/detail?r=558

Modified:
/trunk/UnitTesting/GTMUnitTestDevLog.m

=======================================
--- /trunk/UnitTesting/GTMUnitTestDevLog.m Thu Jun 14 05:00:40 2012
+++ /trunk/UnitTesting/GTMUnitTestDevLog.m Thu Jul 26 13:30:11 2012
@@ -22,6 +22,16 @@
#import "GTMRegex.h"
#import "GTMSenTestCase.h"

+#if !defined(__clang__) && (__GNUC__*10+__GNUC_MINOR__ >= 42)
+// Some versions of GCC (4.2 and below AFAIK) aren't great about supporting
+// -Wmissing-format-attribute
+// when the function is anything more complex than foo(NSString *fmt, ...).
+// You see the error inside the function when you turn ... into va_args and
+// attempt to call another function (like vsprintf for example).
+// So we just shut off the warning for this file. We reenable it at the
end.
+#pragma GCC diagnostic ignored "-Wmissing-format-attribute"
+#endif // !__clang__
+
#if !GTM_IPHONE_SDK
// Add support for grabbing messages from Carbon.
#import <CoreServices/CoreServices.h>
@@ -281,3 +291,8 @@
}

@end
+
+#if !defined(__clang__) && (__GNUC__*10+__GNUC_MINOR__ >= 42)
+// See comment at top of file.
+#pragma GCC diagnostic error "-Wmissing-format-attribute"
+#endif // !__clang__
Reply all
Reply to author
Forward
0 new messages