Issue 49 in google-sparsehash: build fails for mingw

31 views
Skip to first unread message

google-s...@googlecode.com

unread,
Dec 14, 2009, 7:59:15 PM12/14/09
to google-s...@googlegroups.com
Status: New
Owner: ----

New issue 49 by rogerpack2005: build fails for mingw
http://code.google.com/p/google-sparsehash/issues/detail?id=49

What steps will reproduce the problem?
1. attempt to compile using msys

http://groups.google.com/group/google-
sparsehash/browse_thread/thread/b0ddb3f8c611f751


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

google-s...@googlecode.com

unread,
Dec 14, 2009, 9:01:56 PM12/14/09
to google-s...@googlegroups.com
Updates:
Status: Started
Labels: Type-Defect Priority-Medium

Comment #1 on issue 49 by csilvers: build fails for mingw
http://code.google.com/p/google-sparsehash/issues/detail?id=49

I think the right fix is to change the WIN32 #ifdef to _MSC_VER, in
hasthable_unittest.cc. I'll make that part of the next release.

google-s...@googlecode.com

unread,
Dec 15, 2009, 8:57:40 AM12/15/09
to google-s...@googlegroups.com

Comment #2 on issue 49 by rogerpack2005: build fails for mingw
http://code.google.com/p/google-sparsehash/issues/detail?id=49

#ifndef _MSC_VER

seems to do the trick thanks!
-r

google-s...@googlecode.com

unread,
Jan 11, 2010, 6:25:07 PM1/11/10
to google-s...@googlegroups.com
Updates:
Status: Fixed

Comment #3 on issue 49 by csilvers: build fails for mingw
http://code.google.com/p/google-sparsehash/issues/detail?id=49

This should be resolved in sparsehash 1.6, just released.

google-s...@googlecode.com

unread,
Jan 12, 2010, 12:37:20 PM1/12/10
to google-s...@googlegroups.com

Comment #4 on issue 49 by rogerpack2005: build fails for mingw
http://code.google.com/p/google-sparsehash/issues/detail?id=49

appears to build like a champ now

Reply all
Reply to author
Forward
0 new messages