Feedback on Validation branch?
58 views
Skip to first unread message
Eric Charles (GMail)
Apr 18, 2013, 10:51:55 AM4/18/13
to google-s...@googlegroups.com
Hi,
I have done some work on automatic validation (+ form injection via
method parameters). The pull request is on [1].
Before going further with changes (for better support multipart form), I
would love to hear your feedbacks, especially Dhanji one :)
Thx, Eric
[1] https://github.com/dhanji/sitebricks/pull/54/files
I have done some work on automatic validation (+ form injection via
method parameters). The pull request is on [1].
Before going further with changes (for better support multipart form), I
would love to hear your feedbacks, especially Dhanji one :)
Thx, Eric
[1] https://github.com/dhanji/sitebricks/pull/54/files
Dhanji R. Prasanna
Apr 18, 2013, 11:07:00 AM4/18/13
to google-s...@googlegroups.com
Hey so sorry, I have had a hellish few weeks at work. Will have a look this weekend!
--
You received this message because you are subscribed to the Google Groups "Google Sitebricks" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-sitebricks+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Dhanji R. Prasanna
Apr 18, 2013, 11:07:21 AM4/18/13
to google-s...@googlegroups.com
@jason can you also have a look if you can spare a moment?
Eric Charles (GMail)
Apr 18, 2013, 11:23:54 AM4/18/13
to google-s...@googlegroups.com
On 18/04/2013 16:07, Dhanji R. Prasanna wrote:
> Hey so sorry, I have had a hellish few weeks at work.
Welcome to the club :)
> Hey so sorry, I have had a hellish few weeks at work.
> Will have a look
> this weekend!
>
>
Eric
> On Thu, Apr 18, 2013 at 8:21 PM, Eric Charles (GMail)
> <eric.umg...@gmail.com <mailto:eric.umg...@gmail.com>> wrote:
>
> Hi,
>
> I have done some work on automatic validation (+ form injection via
> method parameters). The pull request is on [1].
>
> Before going further with changes (for better support multipart
> form), I would love to hear your feedbacks, especially Dhanji one :)
>
> Thx, Eric
>
> <https://github.com/dhanji/sitebricks/pull/54/files>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to google-sitebricks+unsubscribe@__googlegroups.com
>
> --
> You received this message because you are subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails from it,
> <mailto:google-sitebricks%2Bunsu...@googlegroups.com>.
> For more options, visit https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>.
>
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to google-sitebri...@googlegroups.com.
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails from it, send
Eric Charles (GMail)
Apr 19, 2013, 2:19:45 AM4/19/13
to google-s...@googlegroups.com
Thx for your early comment on pull-request 54.
I have answered to these and pushed back the changed.
Let's keep iterating,
Eric
I have answered to these and pushed back the changed.
Let's keep iterating,
Eric
Eric Charles (GMail)
May 15, 2013, 1:20:14 AM5/15/13
to google-s...@googlegroups.com
Hi,
I continued to work on that branch which has now the following features:
- validation (in various flavors)
- errors widget
- form and multipartform binding as method param
- support for javax.inject.Named
- @At on pages method (same logic for subpath as for the @Service)
(The page method has broken the
RestfuWebServiceWithSubpaths2AcceptanceTest, will fix it asap).
I am just now a bit worried if all those changes get a chance to go in
master. This is open since so long...
Thx, Eric
I continued to work on that branch which has now the following features:
- validation (in various flavors)
- errors widget
- form and multipartform binding as method param
- support for javax.inject.Named
- @At on pages method (same logic for subpath as for the @Service)
(The page method has broken the
RestfuWebServiceWithSubpaths2AcceptanceTest, will fix it asap).
I am just now a bit worried if all those changes get a chance to go in
master. This is open since so long...
Thx, Eric
Dhanji R. Prasanna
May 17, 2013, 5:30:26 PM5/17/13
to google-s...@googlegroups.com
Hey, sorry about that. I have been away for a month or more on other work related stuff. Let's try to merge it this week. Ideally if there are any new jars added, I would like them in a separate module rather that sitebricks-core.
Just keep bugging me I will make it happen =) Thanks for your patience.
an email to google-sitebricks+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups "Google Sitebricks" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-sitebricks+unsubscribe@googlegroups.com.
Eric Charles (GMail)
May 18, 2013, 2:43:04 AM5/18/13
to google-s...@googlegroups.com
Hi Dhanji,
The validation work is done by bval-guice. Exception are catched and
errors put as request attributes so the template can show them. It can
validate the forms as class attribute and and method parameter. Another
option would have been to rely on AOP. In that case, working with an
external module would have been possible, but that's not the road I have
taken (I am not sure all the functions I have implemented would have
been possible with AOP).
There is also an extra jar (commons-fileupload) for the multipart form.
For this, I can move that in an extra tiny module without problem.
Before doing anything, I will wait on you further reviews.
Thx again, Eric
On 17/05/2013 22:30, Dhanji R. Prasanna wrote:
> Hey, sorry about that. I have been away for a month or more on other
> work related stuff. Let's try to merge it this week. Ideally if there
> are any new jars added, I would like them in a separate module rather
> that sitebricks-core.
>
> Just keep bugging me I will make it happen =) Thanks for your patience.
>
>
> On Wed, May 15, 2013 at 3:20 PM, Eric Charles (GMail)
> <eric.umg...@gmail.com <mailto:eric.umg...@gmail.com>> wrote:
>
> Hi,
>
> I continued to work on that branch which has now the following features:
>
> - validation (in various flavors)
> - errors widget
> - form and multipartform binding as method param
> - support for javax.inject.Named
> - @At on pages method (same logic for subpath as for the @Service)
>
> (The page method has broken the
> RestfuWebServiceWithSubpaths2A__cceptanceTest, will fix it asap).
> <mailto:eric.umg.charles@__gmail.com
> <https://github.com/dhanji/__sitebricks/pull/54/files>
> <http://googlegroups.com>
>
> <mailto:google-sitebricks%__2Buns...@googlegroups.com
> <mailto:google-sitebricks%252Buns...@googlegroups.com>__>.
> For more options, visit
> https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> an email to google-sitebri...@googlegroups.com.
The validation work is done by bval-guice. Exception are catched and
errors put as request attributes so the template can show them. It can
validate the forms as class attribute and and method parameter. Another
option would have been to rely on AOP. In that case, working with an
external module would have been possible, but that's not the road I have
taken (I am not sure all the functions I have implemented would have
been possible with AOP).
There is also an extra jar (commons-fileupload) for the multipart form.
For this, I can move that in an extra tiny module without problem.
Before doing anything, I will wait on you further reviews.
Thx again, Eric
On 17/05/2013 22:30, Dhanji R. Prasanna wrote:
> Hey, sorry about that. I have been away for a month or more on other
> work related stuff. Let's try to merge it this week. Ideally if there
> are any new jars added, I would like them in a separate module rather
> that sitebricks-core.
>
> Just keep bugging me I will make it happen =) Thanks for your patience.
>
>
> On Wed, May 15, 2013 at 3:20 PM, Eric Charles (GMail)
> <eric.umg...@gmail.com <mailto:eric.umg...@gmail.com>> wrote:
>
> Hi,
>
> I continued to work on that branch which has now the following features:
>
> - validation (in various flavors)
> - errors widget
> - form and multipartform binding as method param
> - support for javax.inject.Named
> - @At on pages method (same logic for subpath as for the @Service)
>
> (The page method has broken the
>
> I am just now a bit worried if all those changes get a chance to go
> in master. This is open since so long...
>
> Thx, Eric
>
>
>
> On 19/04/2013 07:19, Eric Charles (GMail) wrote:
>
> Thx for your early comment on pull-request 54.
> I have answered to these and pushed back the changed.
>
> Let's keep iterating,
>
> Eric
>
>
> On 18/04/2013 16:23, Eric Charles (GMail) wrote:
>
> On 18/04/2013 16:07, Dhanji R. Prasanna wrote:
>
> Hey so sorry, I have had a hellish few weeks at work.
>
>
> Welcome to the club :)
>
> Will have a look
> this weekend!
>
>
>
> Cool!
>
> Eric
>
> On Thu, Apr 18, 2013 at 8:21 PM, Eric Charles (GMail)
> <eric.umg...@gmail.com
> <mailto:eric.umg...@gmail.com>
> I am just now a bit worried if all those changes get a chance to go
> in master. This is open since so long...
>
> Thx, Eric
>
>
>
> On 19/04/2013 07:19, Eric Charles (GMail) wrote:
>
> Thx for your early comment on pull-request 54.
> I have answered to these and pushed back the changed.
>
> Let's keep iterating,
>
> Eric
>
>
> On 18/04/2013 16:23, Eric Charles (GMail) wrote:
>
> On 18/04/2013 16:07, Dhanji R. Prasanna wrote:
>
> Hey so sorry, I have had a hellish few weeks at work.
>
>
> Welcome to the club :)
>
> Will have a look
> this weekend!
>
>
>
> Cool!
>
> Eric
>
> On Thu, Apr 18, 2013 at 8:21 PM, Eric Charles (GMail)
> <eric.umg...@gmail.com
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg...@gmail.com>>> wrote:
>
> Hi,
>
> I have done some work on automatic validation (+
> form injection via
> method parameters). The pull request is on [1].
>
> Before going further with changes (for better
> support multipart
> form), I would love to hear your feedbacks,
> especially Dhanji one :)
>
> Thx, Eric
>
> [1]
> https://github.com/dhanji/____sitebricks/pull/54/files
>
> Hi,
>
> I have done some work on automatic validation (+
> form injection via
> method parameters). The pull request is on [1].
>
> Before going further with changes (for better
> support multipart
> form), I would love to hear your feedbacks,
> especially Dhanji one :)
>
> Thx, Eric
>
> [1]
> <https://github.com/dhanji/__sitebricks/pull/54/files>
>
> <https://github.com/dhanji/__sitebricks/pull/54/files
> <https://github.com/dhanji/sitebricks/pull/54/files>>
>
> --
> You received this message because you are
> subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving
> emails from it,
> send an email to
> google-sitebricks+unsubscribe@____googlegroups.com
> <https://github.com/dhanji/__sitebricks/pull/54/files
> <https://github.com/dhanji/sitebricks/pull/54/files>>
>
> --
> You received this message because you are
> subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving
> emails from it,
> send an email to
> <http://googlegroups.com>
>
> <mailto:google-sitebricks%__2Buns...@googlegroups.com
> <mailto:google-sitebricks%252Buns...@googlegroups.com>__>.
> For more options, visit
> https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
Dhanji R. Prasanna
May 18, 2013, 4:13:06 PM5/18/13
to google-s...@googlegroups.com
I would instead suggest putting the bits that require bval and commons file upload behind an interface. In the normal sitebricks core you could just return true (everything validates). In the validation module we'd have a Guice module ValidationModule that overrides this interface. That way it is easy for users who want to install it.
Does that work? It should be pretty simple. Sorry, I thought I had mentioned this in one of the code reviews of the pom.xml changes...
<mailto:eric.umg.charles@gmail.com><mailto:eric.umg.charles@__gmail.com
https://github.com/dhanji/____sitebricks/pull/54/files
<mailto:eric.umg.charles@gmail.com>>> wrote:
Hi,
I have done some work on automatic validation (+
form injection via
method parameters). The pull request is on [1].
Before going further with changes (for better
support multipart
form), I would love to hear your feedbacks,
especially Dhanji one :)
Thx, Eric
[1]
<https://github.com/dhanji/__sitebricks/pull/54/files>google-sitebricks+unsubscribe@____googlegroups.com
<https://github.com/dhanji/__sitebricks/pull/54/files
<https://github.com/dhanji/sitebricks/pull/54/files>>
--
You received this message because you are
subscribed to the Google
Groups "Google Sitebricks" group.
To unsubscribe from this group and stop receiving
emails from it,
send an email to
<http://googlegroups.com>
an email to google-sitebricks+unsubscribe@googlegroups.com.
--
You received this message because you are subscribed to the Google Groups "Google Sitebricks" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-sitebricks+unsubscribe@googlegroups.com.
Eric Charles (GMail)
May 19, 2013, 2:09:16 AM5/19/13
to google-s...@googlegroups.com
That would be fine, but still javax.validation.jar is needed in core. I
guess you are ok with this.
So I can create a separate sitebricks-validation module.
For the commons-fileupload, it is needed for the multipartform
transport. Nothing to do with validation, so putting that in
sitebricks-validation does not make sense.
2 options:
- Have a single sitebricks-extensions with validation, multipartform
(and future ones).
- Upon sitebricks-validation, have a sitebricks-upload.
Any recommendation, other idea?
Thx, Eric
> <mailto:eric.umg.charles@>__gma__il.com <http://gmail.com>
>
> <mailto:eric.umg.charles@__gmail.com
> <https://github.com/dhanji/____sitebricks/pull/54/files>
> <http://googlegroups.com>
> <http://googlegroups.com>
>
>
> <mailto:google-sitebricks%____2Bun...@googlegroups.com
> <mailto:google-sitebricks%25__2Bun...@googlegroups.com>
>
> <mailto:google-sitebricks%__252Bunsubscribe@googlegroups.__com
> <mailto:google-sitebricks%25252Bun...@googlegroups.com>>__>.
> For more options, visit
> https://groups.google.com/______groups/opt_out
> <https://groups.google.com/____groups/opt_out>
> an email to google-sitebri...@googlegroups.com.
guess you are ok with this.
So I can create a separate sitebricks-validation module.
For the commons-fileupload, it is needed for the multipartform
transport. Nothing to do with validation, so putting that in
sitebricks-validation does not make sense.
2 options:
- Have a single sitebricks-extensions with validation, multipartform
(and future ones).
- Upon sitebricks-validation, have a sitebricks-upload.
Any recommendation, other idea?
Thx, Eric
> <mailto:eric.umg...@gmail.com>>> wrote:
>
> Hi,
>
> I continued to work on that branch which has now the
> following features:
>
> - validation (in various flavors)
> - errors widget
> - form and multipartform binding as method param
> - support for javax.inject.Named
> - @At on pages method (same logic for subpath as for the
> @Service)
>
> (The page method has broken the
> RestfuWebServiceWithSubpaths2A____cceptanceTest, will fix
>
> Hi,
>
> I continued to work on that branch which has now the
> following features:
>
> - validation (in various flavors)
> - errors widget
> - form and multipartform binding as method param
> - support for javax.inject.Named
> - @At on pages method (same logic for subpath as for the
> @Service)
>
> (The page method has broken the
> it asap).
>
>
> I am just now a bit worried if all those changes get a
> chance to go
> in master. This is open since so long...
>
> Thx, Eric
>
>
>
> On 19/04/2013 07:19, Eric Charles (GMail) wrote:
>
> Thx for your early comment on pull-request 54.
> I have answered to these and pushed back the changed.
>
> Let's keep iterating,
>
> Eric
>
>
> On 18/04/2013 16:23, Eric Charles (GMail) wrote:
>
> On 18/04/2013 16:07, Dhanji R. Prasanna wrote:
>
> Hey so sorry, I have had a hellish few weeks at
> work.
>
>
> Welcome to the club :)
>
> Will have a look
> this weekend!
>
>
>
> Cool!
>
> Eric
>
> On Thu, Apr 18, 2013 at 8:21 PM, Eric Charles
> (GMail)
> <eric.umg...@gmail.com
>
>
> I am just now a bit worried if all those changes get a
> chance to go
> in master. This is open since so long...
>
> Thx, Eric
>
>
>
> On 19/04/2013 07:19, Eric Charles (GMail) wrote:
>
> Thx for your early comment on pull-request 54.
> I have answered to these and pushed back the changed.
>
> Let's keep iterating,
>
> Eric
>
>
> On 18/04/2013 16:23, Eric Charles (GMail) wrote:
>
> On 18/04/2013 16:07, Dhanji R. Prasanna wrote:
>
> Hey so sorry, I have had a hellish few weeks at
> work.
>
>
> Welcome to the club :)
>
> Will have a look
> this weekend!
>
>
>
> Cool!
>
> Eric
>
> On Thu, Apr 18, 2013 at 8:21 PM, Eric Charles
> (GMail)
> <eric.umg...@gmail.com
> <mailto:eric.umg...@gmail.com>
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg...@gmail.com>>
> <mailto:eric.umg.charles@
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg...@gmail.com>>
> <mailto:eric.umg.charles@>__gma__il.com <http://gmail.com>
>
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg...@gmail.com>>>> wrote:
>
> Hi,
>
> I have done some work on automatic
> validation (+
> form injection via
> method parameters). The pull request is on
> [1].
>
> Before going further with changes (for better
> support multipart
> form), I would love to hear your feedbacks,
> especially Dhanji one :)
>
> Thx, Eric
>
> [1]
> https://github.com/dhanji/______sitebricks/pull/54/files
>
> Hi,
>
> I have done some work on automatic
> validation (+
> form injection via
> method parameters). The pull request is on
> [1].
>
> Before going further with changes (for better
> support multipart
> form), I would love to hear your feedbacks,
> especially Dhanji one :)
>
> Thx, Eric
>
> [1]
> <https://github.com/dhanji/____sitebricks/pull/54/files>
>
> <https://github.com/dhanji/____sitebricks/pull/54/files
> <https://github.com/dhanji/__sitebricks/pull/54/files>>
>
>
>
> <https://github.com/dhanji/____sitebricks/pull/54/files
> <https://github.com/dhanji/__sitebricks/pull/54/files>
>
> <https://github.com/dhanji/__sitebricks/pull/54/files
> <https://github.com/dhanji/sitebricks/pull/54/files>>>
>
> --
> You received this message because you are
> subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop
> receiving
> emails from it,
> send an email to
>
> google-sitebricks+unsubscribe@______googlegroups.com
> <https://github.com/dhanji/____sitebricks/pull/54/files
> <https://github.com/dhanji/__sitebricks/pull/54/files>>
>
>
>
> <https://github.com/dhanji/____sitebricks/pull/54/files
> <https://github.com/dhanji/__sitebricks/pull/54/files>
>
> <https://github.com/dhanji/__sitebricks/pull/54/files
> <https://github.com/dhanji/sitebricks/pull/54/files>>>
>
> --
> You received this message because you are
> subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop
> receiving
> emails from it,
> send an email to
>
> <http://googlegroups.com>
> <http://googlegroups.com>
>
>
> <mailto:google-sitebricks%____2Bun...@googlegroups.com
> <mailto:google-sitebricks%25__2Bun...@googlegroups.com>
>
> <mailto:google-sitebricks%__252Bunsubscribe@googlegroups.__com
> <mailto:google-sitebricks%25252Bun...@googlegroups.com>>__>.
> For more options, visit
> https://groups.google.com/______groups/opt_out
> <https://groups.google.com/____groups/opt_out>
> <https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>>
>
>
> <https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>>>.
>
>
>
> --
> You received this message because you are
> subscribed to
> the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop
> receiving emails
> from it, send
> an email to
>
> <https://groups.google.com/__groups/opt_out>>
>
>
> <https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>>>.
>
>
>
> --
> You received this message because you are
> subscribed to
> the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop
> receiving emails
> from it, send
> an email to
>
> google-sitebricks+unsubscribe@____googlegroups.com
> <http://googlegroups.com>
>
> <mailto:google-sitebricks%__2Buns...@googlegroups.com
> <mailto:google-sitebricks%252Buns...@googlegroups.com>__>.
> <http://googlegroups.com>
>
> <mailto:google-sitebricks%__2Buns...@googlegroups.com
> For more options, visit
> https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>>.
>
>
>
>
>
> --
> You received this message because you are subscribed to the
> Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails
> from it,
> send an email to
> https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>>.
>
>
>
>
>
> --
> You received this message because you are subscribed to the
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails
> from it,
> send an email to
> google-sitebricks+unsubscribe@____googlegroups.com
> <http://googlegroups.com>
> <mailto:google-sitebricks%__2Buns...@googlegroups.com
> <mailto:google-sitebricks%252Buns...@googlegroups.com>__>.
> <http://googlegroups.com>
> <mailto:google-sitebricks%__2Buns...@googlegroups.com
Dhanji R. Prasanna
May 19, 2013, 3:11:08 AM5/19/13
to google-s...@googlegroups.com
On Sun, May 19, 2013 at 4:09 PM, Eric Charles (GMail) <eric.umg...@gmail.com> wrote:
That would be fine, but still javax.validation.jar is needed in core. I guess you are ok with this.
How come? Isn't it enough if it's in the validation branch?
So I can create a separate sitebricks-validation module.
For the commons-fileupload, it is needed for the multipartform transport. Nothing to do with validation, so putting that in sitebricks-validation does not make sense.
I see your point.
2 options:
- Have a single sitebricks-extensions with validation, multipartform (and future ones).
Yea let's do this, and add both of them here. Later we can add more cool ideas there too.
Thanks!
Eric Charles (GMail)
May 19, 2013, 12:13:57 PM5/19/13
to google-s...@googlegroups.com
On 19/05/2013 08:11, Dhanji R. Prasanna wrote:
>
>
>
> On Sun, May 19, 2013 at 4:09 PM, Eric Charles (GMail)
> <eric.umg...@gmail.com <mailto:eric.umg...@gmail.com>> wrote:
>
> That would be fine, but still javax.validation.jar is needed in
> core. I guess you are ok with this.
>
>
> How come? Isn't it enough if it's in the validation branch?
>
I mean the core will import some javax.validation classes, so will
>
>
>
> On Sun, May 19, 2013 at 4:09 PM, Eric Charles (GMail)
> <eric.umg...@gmail.com <mailto:eric.umg...@gmail.com>> wrote:
>
> That would be fine, but still javax.validation.jar is needed in
> core. I guess you are ok with this.
>
>
> How come? Isn't it enough if it's in the validation branch?
>
depend on java.validation dependency.
I will update the 'validation' branch, it will be easier for you to
comment on the code.
Give me 2 or 3 days for this.
Thx, Eric
>
> So I can create a separate sitebricks-validation module.
>
> For the commons-fileupload, it is needed for the multipartform
> transport. Nothing to do with validation, so putting that in
> sitebricks-validation does not make sense.
>
>
> I see your point.
>
>
> 2 options:
> - Have a single sitebricks-extensions with validation, multipartform
> (and future ones).
>
>
> Yea let's do this, and add both of them here. Later we can add more cool
> ideas there too.
>
> Thanks!
>
> - Upon sitebricks-validation, have a sitebricks-upload.
>
> Any recommendation, other idea?
>
Dhanji R. Prasanna
May 19, 2013, 3:45:39 PM5/19/13
to google-s...@googlegroups.com
Sounds good, thanks again for iterating. I definitely want to see this code in SB master.
an email to google-sitebricks+unsubscribe@googlegroups.com.
--
You received this message because you are subscribed to the Google Groups "Google Sitebricks" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-sitebricks+unsubscribe@googlegroups.com.
Eric Charles (GMail)
May 21, 2013, 2:10:54 PM5/21/13
to google-s...@googlegroups.com, Dhanji R. Prasanna
I have commited the new extensions module (so core does not contain
commons-fileupload nor bval-guice).
I hope you will like this one (at least jenkins is happy with it [1]).
Thx, Eric
[1] https://buildhive.cloudbees.com/job/dhanji/job/sitebricks/169/
On 19/05/2013 20:45, Dhanji R. Prasanna wrote:
> Sounds good, thanks again for iterating. I definitely want to see this
> code in SB master.
>
>
> On Mon, May 20, 2013 at 2:13 AM, Eric Charles (GMail)
> <eric.umg...@gmail.com <mailto:eric.umg...@gmail.com>> wrote:
>
> On 19/05/2013 08:11, Dhanji R. Prasanna wrote:
>
>
>
>
> On Sun, May 19, 2013 at 4:09 PM, Eric Charles (GMail)
> an email to google-sitebricks+unsubscribe@__googlegroups.com
> <mailto:google-sitebricks%2Bunsu...@googlegroups.com>.
> For more options, visit
> https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>.
> <mailto:google-sitebricks%2Bunsu...@googlegroups.com>.
> For more options, visit https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>.
commons-fileupload nor bval-guice).
I hope you will like this one (at least jenkins is happy with it [1]).
Thx, Eric
[1] https://buildhive.cloudbees.com/job/dhanji/job/sitebricks/169/
On 19/05/2013 20:45, Dhanji R. Prasanna wrote:
> Sounds good, thanks again for iterating. I definitely want to see this
> code in SB master.
>
>
> On Mon, May 20, 2013 at 2:13 AM, Eric Charles (GMail)
> <eric.umg...@gmail.com <mailto:eric.umg...@gmail.com>> wrote:
>
> On 19/05/2013 08:11, Dhanji R. Prasanna wrote:
>
>
>
>
> On Sun, May 19, 2013 at 4:09 PM, Eric Charles (GMail)
> <mailto:google-sitebricks%2Bunsu...@googlegroups.com>.
> For more options, visit
> https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>.
>
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to google-sitebricks+unsubscribe@__googlegroups.com
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails from it,
> <mailto:google-sitebricks%2Bunsu...@googlegroups.com>.
> For more options, visit https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>.
>
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to google-sitebri...@googlegroups.com.
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails from it, send
Dhanji R. Prasanna
May 23, 2013, 2:44:43 AM5/23/13
to google-s...@googlegroups.com
great, I will take a look. Thanks.
On Wed, May 22, 2013 at 4:10 AM, Eric Charles (GMail) <eric.umg...@gmail.com> wrote:
I have commited the new extensions module (so core does not contain commons-fileupload nor bval-guice).
I hope you will like this one (at least jenkins is happy with it [1]).
Thx, Eric
[1] https://buildhive.cloudbees.com/job/dhanji/job/sitebricks/169/
On 19/05/2013 20:45, Dhanji R. Prasanna wrote:
Sounds good, thanks again for iterating. I definitely want to see this
code in SB master.
On Mon, May 20, 2013 at 2:13 AM, Eric Charles (GMail)
<eric.umg...@gmail.com <mailto:eric.umg.charles@gmail.com>> wrote:
On 19/05/2013 08:11, Dhanji R. Prasanna wrote:
On Sun, May 19, 2013 at 4:09 PM, Eric Charles (GMail)
<mailto:eric.umg.charles@__gmail.com
an email to google-sitebricks+unsubscribe@googlegroups.com.
--
You received this message because you are subscribed to the Google Groups "Google Sitebricks" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-sitebricks+unsubscribe@googlegroups.com.
Eric Charles (GMail)
Jun 2, 2013, 12:36:33 AM6/2/13
to google-s...@googlegroups.com
Hi Dhanji,
I have updated the validation branch to take into account your last
comment (the repository definitions).
Anything else I should change before you merge?
Thx, Eric
On 23/05/2013 08:44, Dhanji R. Prasanna wrote:
> great, I will take a look. Thanks.
>
>
> On Wed, May 22, 2013 at 4:10 AM, Eric Charles (GMail)
> <eric.umg...@gmail.com <mailto:eric.umg...@gmail.com>> wrote:
>
> I have commited the new extensions module (so core does not contain
> commons-fileupload nor bval-guice).
>
> I hope you will like this one (at least jenkins is happy with it [1]).
>
> Thx, Eric
>
> [1]
> https://buildhive.cloudbees.__com/job/dhanji/job/sitebricks/__169/
> For more options, visit
> https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> For more options, visit
> https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
I have updated the validation branch to take into account your last
comment (the repository definitions).
Anything else I should change before you merge?
Thx, Eric
On 23/05/2013 08:44, Dhanji R. Prasanna wrote:
> great, I will take a look. Thanks.
>
>
> On Wed, May 22, 2013 at 4:10 AM, Eric Charles (GMail)
> <eric.umg...@gmail.com <mailto:eric.umg...@gmail.com>> wrote:
>
> I have commited the new extensions module (so core does not contain
> commons-fileupload nor bval-guice).
>
> I hope you will like this one (at least jenkins is happy with it [1]).
>
> Thx, Eric
>
> [1]
> <https://buildhive.cloudbees.com/job/dhanji/job/sitebricks/169/>
>
>
> On 19/05/2013 20:45, Dhanji R. Prasanna wrote:
>
> Sounds good, thanks again for iterating. I definitely want to
> see this
> code in SB master.
>
>
> On Mon, May 20, 2013 at 2:13 AM, Eric Charles (GMail)
>
>
> On 19/05/2013 20:45, Dhanji R. Prasanna wrote:
>
> Sounds good, thanks again for iterating. I definitely want to
> see this
> code in SB master.
>
>
> On Mon, May 20, 2013 at 2:13 AM, Eric Charles (GMail)
> <mailto:eric.umg...@gmail.com>>> wrote:
>
> On 19/05/2013 08:11, Dhanji R. Prasanna wrote:
>
>
>
>
> On Sun, May 19, 2013 at 4:09 PM, Eric Charles (GMail)
> <eric.umg...@gmail.com
>
> On 19/05/2013 08:11, Dhanji R. Prasanna wrote:
>
>
>
>
> On Sun, May 19, 2013 at 4:09 PM, Eric Charles (GMail)
> <eric.umg...@gmail.com
> <mailto:eric.umg...@gmail.com>
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg...@gmail.com>>
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg...@gmail.com>>
> <mailto:eric.umg.charles@
> <mailto:eric.umg.charles@>__gma__il.com <http://gmail.com>
>
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg.charles@>__gma__il.com <http://gmail.com>
>
> <mailto:eric.umg.charles@__gmail.com
> google-sitebricks+unsubscribe@____googlegroups.com
> <http://googlegroups.com>
>
> <mailto:google-sitebricks%__2Buns...@googlegroups.com
> <mailto:google-sitebricks%252Buns...@googlegroups.com>__>.
> <http://googlegroups.com>
>
> <mailto:google-sitebricks%__2Buns...@googlegroups.com
> For more options, visit
> https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>>.
>
>
>
>
> --
> You received this message because you are subscribed to the
> Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails
> from it,
> send an email to
> <https://groups.google.com/groups/opt_out>>.
>
>
>
>
> --
> You received this message because you are subscribed to the
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails
> from it,
> send an email to
> google-sitebricks+unsubscribe@____googlegroups.com
> <http://googlegroups.com>
> <mailto:google-sitebricks%__2Buns...@googlegroups.com
> <mailto:google-sitebricks%252Buns...@googlegroups.com>__>.
> <http://googlegroups.com>
> <mailto:google-sitebricks%__2Buns...@googlegroups.com
> For more options, visit
> https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>>.
>
>
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails from
> it, send
> an email to google-sitebricks+unsubscribe@__googlegroups.com
> <mailto:google-sitebricks%2Bunsu...@googlegroups.com>.
> For more options, visit
> https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>.
>
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to google-sitebricks+unsubscribe@__googlegroups.com
> <https://groups.google.com/groups/opt_out>>.
>
>
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails from
> it, send
> an email to google-sitebricks+unsubscribe@__googlegroups.com
> <mailto:google-sitebricks%2Bunsu...@googlegroups.com>.
> For more options, visit
> https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>.
>
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails from it,
> <mailto:google-sitebricks%2Bunsu...@googlegroups.com>.
> For more options, visit https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>.
>
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to google-sitebri...@googlegroups.com.
> For more options, visit https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>.
>
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails from it, send
Dhanji R. Prasanna
Jun 2, 2013, 3:35:34 AM6/2/13
to google-s...@googlegroups.com
That sounds good I will merge presently. Thanks.
On Sun, Jun 2, 2013 at 2:36 PM, Eric Charles (GMail) <eric.umg...@gmail.com> wrote:
Hi Dhanji,
I have updated the validation branch to take into account your last comment (the repository definitions).
Anything else I should change before you merge?
Thx, Eric
On 23/05/2013 08:44, Dhanji R. Prasanna wrote:
great, I will take a look. Thanks.
On Wed, May 22, 2013 at 4:10 AM, Eric Charles (GMail)<eric.umg...@gmail.com <mailto:eric.umg.charles@gmail.com>> wrote:https://buildhive.cloudbees.__com/job/dhanji/job/sitebricks/__169/
I have commited the new extensions module (so core does not contain
commons-fileupload nor bval-guice).
I hope you will like this one (at least jenkins is happy with it [1]).
Thx, Eric
[1]
<https://buildhive.cloudbees.com/job/dhanji/job/sitebricks/169/>
On 19/05/2013 20:45, Dhanji R. Prasanna wrote:
Sounds good, thanks again for iterating. I definitely want to
see this
code in SB master.
On Mon, May 20, 2013 at 2:13 AM, Eric Charles (GMail)
<mailto:eric.umg.charles@__gmail.com
<mailto:eric.umg.charles@gmail.com>>> wrote:
On 19/05/2013 08:11, Dhanji R. Prasanna wrote:
On Sun, May 19, 2013 at 4:09 PM, Eric Charles (GMail)
<eric.umg...@gmail.com
<mailto:eric.umg.charles@gmail.com>
<mailto:eric.umg.charles@__gmail.com
<mailto:eric.umg.charles@gmail.com>>
<mailto:eric.umg.charles@__gmail.com
google-sitebricks+unsubscribe@____googlegroups.com<mailto:google-sitebricks%252Bunsubscribe@googlegroups.com>__>.
<http://googlegroups.com>
<mailto:google-sitebricks%__2Bunsu...@googlegroups.com
For more options, visit
https://groups.google.com/____groups/opt_out
<https://groups.google.com/__groups/opt_out>
<https://groups.google.com/__groups/opt_out
<https://groups.google.com/groups/opt_out>>.
--
You received this message because you are subscribed to the
Groups "Google Sitebricks" group.
To unsubscribe from this group and stop receiving emails
from it,
send an email to
google-sitebricks+unsubscribe@____googlegroups.com<mailto:google-sitebricks%252Bunsubscribe@googlegroups.com>__>.
<http://googlegroups.com>
<mailto:google-sitebricks%__2Bunsu...@googlegroups.com
an email to google-sitebricks+unsubscribe@googlegroups.com.
--
You received this message because you are subscribed to the Google Groups "Google Sitebricks" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-sitebricks+unsubscribe@googlegroups.com.
Eric Charles (GMail)
Jun 3, 2013, 1:05:47 AM6/3/13
to google-s...@googlegroups.com
Great!
Thx a lot,
Eric
On 02/06/2013 08:35, Dhanji R. Prasanna wrote:
> That sounds good I will merge presently. Thanks.
>
>
> On Sun, Jun 2, 2013 at 2:36 PM, Eric Charles (GMail)
> <eric.umg...@gmail.com <mailto:eric.umg...@gmail.com>> wrote:
>
> Hi Dhanji,
>
> I have updated the validation branch to take into account your last
> comment (the repository definitions).
>
> Anything else I should change before you merge?
>
> Thx, Eric
>
>
>
> On 23/05/2013 08:44, Dhanji R. Prasanna wrote:
>
> great, I will take a look. Thanks.
>
>
> On Wed, May 22, 2013 at 4:10 AM, Eric Charles (GMail)
> <mailto:eric.umg.charles@>>__gm__a__il.com <http://gma__il.com>
> <http://gmail.com>
> For more options, visit
> https://groups.google.com/______groups/opt_out
> <https://groups.google.com/____groups/opt_out>
> For more options, visit
> https://groups.google.com/______groups/opt_out
> <https://groups.google.com/____groups/opt_out>
> <mailto:google-sitebricks%252Buns...@googlegroups.com>__>.
> <mailto:google-sitebricks%252Buns...@googlegroups.com>__>.
> an email to google-sitebri...@googlegroups.com.
Thx a lot,
Eric
On 02/06/2013 08:35, Dhanji R. Prasanna wrote:
> That sounds good I will merge presently. Thanks.
>
>
> On Sun, Jun 2, 2013 at 2:36 PM, Eric Charles (GMail)
> <eric.umg...@gmail.com <mailto:eric.umg...@gmail.com>> wrote:
>
> Hi Dhanji,
>
> I have updated the validation branch to take into account your last
> comment (the repository definitions).
>
> Anything else I should change before you merge?
>
> Thx, Eric
>
>
>
> On 23/05/2013 08:44, Dhanji R. Prasanna wrote:
>
> great, I will take a look. Thanks.
>
>
> On Wed, May 22, 2013 at 4:10 AM, Eric Charles (GMail)
> <mailto:eric.umg...@gmail.com>>> wrote:
>
> I have commited the new extensions module (so core does not
> contain
> commons-fileupload nor bval-guice).
>
> I hope you will like this one (at least jenkins is happy
> with it [1]).
>
> Thx, Eric
>
> [1]
> https://buildhive.cloudbees.____com/job/dhanji/job/sitebricks/____169/
>
> I have commited the new extensions module (so core does not
> contain
> commons-fileupload nor bval-guice).
>
> I hope you will like this one (at least jenkins is happy
> with it [1]).
>
> Thx, Eric
>
> [1]
>
>
> <https://buildhive.cloudbees.__com/job/dhanji/job/sitebricks/__169/
> <https://buildhive.cloudbees.com/job/dhanji/job/sitebricks/169/>>
>
>
> On 19/05/2013 20:45, Dhanji R. Prasanna wrote:
>
> Sounds good, thanks again for iterating. I definitely
> want to
> see this
> code in SB master.
>
>
> On Mon, May 20, 2013 at 2:13 AM, Eric Charles (GMail)
> <eric.umg...@gmail.com
>
> <https://buildhive.cloudbees.__com/job/dhanji/job/sitebricks/__169/
> <https://buildhive.cloudbees.com/job/dhanji/job/sitebricks/169/>>
>
>
> On 19/05/2013 20:45, Dhanji R. Prasanna wrote:
>
> Sounds good, thanks again for iterating. I definitely
> want to
> see this
> code in SB master.
>
>
> On Mon, May 20, 2013 at 2:13 AM, Eric Charles (GMail)
> <eric.umg...@gmail.com
> <mailto:eric.umg...@gmail.com>
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg...@gmail.com>>
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg...@gmail.com>>
> <mailto:eric.umg.charles@
> <mailto:eric.umg.charles@>__gma__il.com <http://gmail.com>
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg.charles@>__gma__il.com <http://gmail.com>
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg...@gmail.com>>>> wrote:
>
> On 19/05/2013 08:11, Dhanji R. Prasanna wrote:
>
>
>
>
> On Sun, May 19, 2013 at 4:09 PM, Eric Charles
> (GMail)
> <eric.umg...@gmail.com
>
> On 19/05/2013 08:11, Dhanji R. Prasanna wrote:
>
>
>
>
> On Sun, May 19, 2013 at 4:09 PM, Eric Charles
> (GMail)
> <eric.umg...@gmail.com
> <mailto:eric.umg...@gmail.com>
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg...@gmail.com>>
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg...@gmail.com>>
> <mailto:eric.umg.charles@
> <mailto:eric.umg.charles@>__gma__il.com <http://gmail.com>
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg.charles@
> <mailto:eric.umg.charles@>__gma__il.com <http://gmail.com>
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg.charles@>>__gm__a__il.com <http://gma__il.com>
> <http://gmail.com>
>
> <mailto:eric.umg.charles@
> <mailto:eric.umg.charles@>__gma__il.com <http://gmail.com>
> <mailto:eric.umg.charles@__gmail.com
> <mailto:eric.umg.charles@
> <mailto:eric.umg.charles@>__gma__il.com <http://gmail.com>
> <mailto:eric.umg.charles@__gmail.com
> google-sitebricks+unsubscribe@______googlegroups.com
> <http://googlegroups.com>
> <http://googlegroups.com>
>
>
> <mailto:google-sitebricks%____2Bun...@googlegroups.com
> <mailto:google-sitebricks%25__2Bun...@googlegroups.com>
>
> <mailto:google-sitebricks%__252Bunsubscribe@googlegroups.__com
> <mailto:google-sitebricks%25252Bun...@googlegroups.com>>__>.
> <http://googlegroups.com>
> <http://googlegroups.com>
>
>
> <mailto:google-sitebricks%____2Bun...@googlegroups.com
> <mailto:google-sitebricks%25__2Bun...@googlegroups.com>
>
> <mailto:google-sitebricks%__252Bunsubscribe@googlegroups.__com
> For more options, visit
> https://groups.google.com/______groups/opt_out
> <https://groups.google.com/____groups/opt_out>
> <https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>>
>
> <https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>>>.
>
>
>
>
> --
> You received this message because you are
> subscribed to the
> Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving
> emails
> from it,
> send an email to
> <https://groups.google.com/__groups/opt_out>>
>
> <https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>>>.
>
>
>
>
> --
> You received this message because you are
> subscribed to the
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving
> emails
> from it,
> send an email to
> google-sitebricks+unsubscribe@______googlegroups.com
> <http://googlegroups.com>
> <http://googlegroups.com>
>
> <mailto:google-sitebricks%____2Bun...@googlegroups.com
> <mailto:google-sitebricks%25__2Bun...@googlegroups.com>
>
> <mailto:google-sitebricks%__252Bunsubscribe@googlegroups.__com
> <mailto:google-sitebricks%25252Bun...@googlegroups.com>>__>.
> <http://googlegroups.com>
> <http://googlegroups.com>
>
> <mailto:google-sitebricks%____2Bun...@googlegroups.com
> <mailto:google-sitebricks%25__2Bun...@googlegroups.com>
>
> <mailto:google-sitebricks%__252Bunsubscribe@googlegroups.__com
> For more options, visit
> https://groups.google.com/______groups/opt_out
> <https://groups.google.com/____groups/opt_out>
> <https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>>
>
> <https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>>>.
>
>
>
>
> --
> You received this message because you are subscribed to
> the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving
> emails from
> it, send
> an email to
> google-sitebricks+unsubscribe@____googlegroups.com
> <http://googlegroups.com>
>
> <mailto:google-sitebricks%__2Buns...@googlegroups.com
> <https://groups.google.com/__groups/opt_out>>
>
> <https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>>>.
>
>
>
>
> --
> You received this message because you are subscribed to
> the Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving
> emails from
> it, send
> an email to
> google-sitebricks+unsubscribe@____googlegroups.com
> <http://googlegroups.com>
>
> <mailto:google-sitebricks%252Buns...@googlegroups.com>__>.
> For more options, visit
> https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>>.
>
>
>
> --
> You received this message because you are subscribed to the
> Google
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails
> from it,
> send an email to
> google-sitebricks+unsubscribe@____googlegroups.com
> <http://googlegroups.com>
> <mailto:google-sitebricks%__2Buns...@googlegroups.com
> https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>>.
>
>
>
> --
> You received this message because you are subscribed to the
> Groups "Google Sitebricks" group.
> To unsubscribe from this group and stop receiving emails
> from it,
> send an email to
> google-sitebricks+unsubscribe@____googlegroups.com
> <http://googlegroups.com>
> <mailto:google-sitebricks%252Buns...@googlegroups.com>__>.
Reply all
Reply to author
Forward
0 new messages