Changing error log into logging.exception in wsgi.service. Fixes Issue 45. (issue 94001)

7 views
Skip to first unread message

dhe...@google.com

unread,
Mar 27, 2013, 10:51:24 AM3/27/13
to ra...@google.com, google-prot...@googlegroups.com, re...@google-protorpc-review.appspotmail.com
Reviewers: Rafe,

Description:
Changing error log into logging.exception in wsgi.service. Fixes Issue
45.

Please review this at http://google-protorpc-review.appspot.com/94001/

Affected files:
M python/protorpc/wsgi/service.py


Index: python/protorpc/wsgi/service.py
diff --git a/python/protorpc/wsgi/service.py
b/python/protorpc/wsgi/service.py
index
a7e8f9033c152ba6c923c2121f92d553a0626143..ab009bead9ed1ee2d8eaa510630036e688528df8
100644
--- a/python/protorpc/wsgi/service.py
+++ b/python/protorpc/wsgi/service.py
@@ -191,9 +191,9 @@ def service_mapping(service_factory,
service_path=r'.*', protocols=None):
err.message,
err.error_name)
except Exception, err:
- logging.error('Encountered unexpected error from ProtoRPC '
- 'method implementation: %s (%s)' %
(err.__class__.__name__,
- err))
+ logging.exception('Encountered unexpected error from ProtoRPC '
+ 'method implementation: %s (%s)' %
+ (err.__class__.__name__, err))
return send_rpc_error(httplib.INTERNAL_SERVER_ERROR,
remote.RpcState.SERVER_ERROR,
'Internal Server Error')


ra...@google.com

unread,
Mar 27, 2013, 4:21:18 PM3/27/13
to dhe...@google.com, google-prot...@googlegroups.com, re...@google-protorpc-review.appspotmail.com

dhe...@google.com

unread,
Mar 27, 2013, 4:23:07 PM3/27/13
to ra...@google.com, google-prot...@googlegroups.com, re...@google-protorpc-review.appspotmail.com
Reply all
Reply to author
Forward
0 new messages