Guice source code state?

321 views
Skip to first unread message

Tim Boudreau

unread,
Aug 30, 2012, 8:47:28 PM8/30/12
to google...@googlegroups.com
I have a problem that looks like it could be solved by ProvisionListener, which exists in Guice's sources but not in 3.0.  So I set up a continuous build of Guice to easily deploy daily builds from Jenkins into my Maven repo.

However, it appears that the trunk is unbuildable - guice core builds, but other parts fail.  The most recent commit I see is from three months ago:

commit 2804e19f307e9c23bdd3260b7a3eda1f3d45567f
Refs: master, <origin/HEAD>, <origin/master>
Author:     Sam Berlin <sa...@google.com>
AuthorDate: Thu May 31 19:54:44 2012 -0400

Should I be getting sources from somewhere other than https://code.google.com/p/google-guice/ ? Or has no development really happened since May?

Thanks,

Tim

Stuart McCulloch

unread,
Aug 30, 2012, 9:35:44 PM8/30/12
to google...@googlegroups.com
On 31 Aug 2012, at 01:47, Tim Boudreau wrote:

I have a problem that looks like it could be solved by ProvisionListener, which exists in Guice's sources but not in 3.0.  So I set up a continuous build of Guice to easily deploy daily builds from Jenkins into my Maven repo.

However, it appears that the trunk is unbuildable - guice core builds, but other parts fail.  The most recent commit I see is from three months ago:

Hi Tim,

Guice trunk builds fine for me locally using either the Maven or Ant build scripts - what JDK/OS are you using and what error/exception messages do you see?

I also resurrected my local CI build of vanilla Guice (it had stalled as it was polling the old SVN repo) and this is now deploying snapshots to:


--
Cheers, Stuart

commit 2804e19f307e9c23bdd3260b7a3eda1f3d45567f
Refs: master, <origin/HEAD>, <origin/master>
Author:     Sam Berlin <sa...@google.com>
AuthorDate: Thu May 31 19:54:44 2012 -0400

Should I be getting sources from somewhere other than https://code.google.com/p/google-guice/ ? Or has no development really happened since May?

Thanks,

Tim

--
You received this message because you are subscribed to the Google Groups "google-guice" group.
To view this discussion on the web visit https://groups.google.com/d/msg/google-guice/-/zHePsyb7gjUJ.
To post to this group, send email to google...@googlegroups.com.
To unsubscribe from this group, send email to google-guice...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/google-guice?hl=en.

Stuart McCulloch

unread,
Aug 30, 2012, 9:37:26 PM8/30/12
to google...@googlegroups.com
On 31 Aug 2012, at 02:35, Stuart McCulloch wrote:

On 31 Aug 2012, at 01:47, Tim Boudreau wrote:

I have a problem that looks like it could be solved by ProvisionListener, which exists in Guice's sources but not in 3.0.  So I set up a continuous build of Guice to easily deploy daily builds from Jenkins into my Maven repo.

However, it appears that the trunk is unbuildable - guice core builds, but other parts fail.  The most recent commit I see is from three months ago:

Hi Tim,

Guice trunk builds fine for me locally using either the Maven or Ant build scripts - what JDK/OS are you using and what error/exception messages do you see?

I also resurrected my local CI build of vanilla Guice (it had stalled as it was polling the old SVN repo) and this is now deploying snapshots to:


and just to clarify this CI job is building the master branch from the git repository at https://code.google.com/p/google-guice

Christian Gruber

unread,
Aug 30, 2012, 10:33:29 PM8/30/12
to google...@googlegroups.com
Yeah - I'm wondering if you're pulling from something else.  At any rate, I'm going to be setting up an "official"  jenkins instance, with snapshot repository, but there's a lot of behind-the-scenes stuff shifting in the guice project, so hopefully I'll get to it before you all get too impatient.  But trunk should always be building.  I'll try to hook up our internal CI (which doesn't use maven/ant by default) with a CI project based on the open-source project, to make sure we don't break anything, but we always build the open-source project before we push changes to git. 

Mark Derricutt

unread,
Aug 31, 2012, 3:21:09 AM8/31/12
to google...@googlegroups.com
A crazy question here...  if this is building from master/HEAD - why is it a 3.0-SNAPSHOT and not 3.1-SNAPSHOT?

Given 3.0 is already released....

Stuart McCulloch

unread,
Aug 31, 2012, 5:17:32 AM8/31/12
to google...@googlegroups.com
On 31 Aug 2012, at 08:21, Mark Derricutt wrote:

A crazy question here...  if this is building from master/HEAD - why is it a 3.0-SNAPSHOT and not 3.1-SNAPSHOT?

Just an oversight - as Christian mentioned they don't use Maven/Ant when building Guice internally, and since the release plugin wasn't used to do the release the pom versions weren't bumped.

I've used "mvn versions:set -DnewVersion=3.0.1-SNAPSHOT" to set the pom versions to the next maintenance version (and updated the mini and service poms manually since they're not currently part of the build)

Given 3.0 is already released....

On 31/08/2012, at 1:35 PM, Stuart McCulloch <mcc...@gmail.com> wrote:

I also resurrected my local CI build of vanilla Guice (it had stalled as it was polling the old SVN repo) and this is now deploying snapshots to:



--
You received this message because you are subscribed to the Google Groups "google-guice" group.

Stuart McCulloch

unread,
Aug 31, 2012, 5:24:22 AM8/31/12
to google...@googlegroups.com
On 31 Aug 2012, at 10:17, Stuart McCulloch wrote:

On 31 Aug 2012, at 08:21, Mark Derricutt wrote:

A crazy question here...  if this is building from master/HEAD - why is it a 3.0-SNAPSHOT and not 3.1-SNAPSHOT?

Just an oversight - as Christian mentioned they don't use Maven/Ant when building Guice internally, and since the release plugin wasn't used to do the release the pom versions weren't bumped.

I've used "mvn versions:set -DnewVersion=3.0.1-SNAPSHOT" to set the pom versions to the next maintenance version (and updated the mini and service poms manually since they're not currently part of the build)

Stuart McCulloch

unread,
Aug 31, 2012, 5:46:14 AM8/31/12
to google...@googlegroups.com
On 31 Aug 2012, at 10:17, Stuart McCulloch wrote:

On 31 Aug 2012, at 08:21, Mark Derricutt wrote:

A crazy question here...  if this is building from master/HEAD - why is it a 3.0-SNAPSHOT and not 3.1-SNAPSHOT?

Just an oversight - as Christian mentioned they don't use Maven/Ant when building Guice internally, and since the release plugin wasn't used to do the release the pom versions weren't bumped.

I've used "mvn versions:set -DnewVersion=3.0.1-SNAPSHOT" to set the pom versions to the next maintenance version (and updated the mini and service poms manually since they're not currently part of the build)

Need more tea this morning ( unfortunately can't take coffee these days :/ ) ... this should of course be 3.1.0-SNAPSHOT to reflect the addition of a couple of new features (ProvisionListener SPI)  



Anyway, onwards and upwards!

Christian Gruber

unread,
Aug 31, 2012, 11:12:50 AM8/31/12
to google...@googlegroups.com
I was going to say…  :D  

Tim Boudreau

unread,
Aug 31, 2012, 12:35:34 PM8/31/12
to google...@googlegroups.com
On Thursday, August 30, 2012 9:35:57 PM UTC-4, Stuart McCulloch wrote:
Hi Tim,

Guice trunk builds fine for me locally using either the Maven or Ant build scripts - what JDK/OS are you using and what error/exception messages do you see?

I also resurrected my local CI build of vanilla Guice (it had stalled as it was polling the old SVN repo) and this is now deploying snapshots to:


The problem building appears to have been JDK-7 specific (assertMapVisitor I think it was called, in Multibindings).

Thanks!

-Tim 

Mark Derricutt

unread,
Aug 31, 2012, 6:40:55 PM8/31/12
to google...@googlegroups.com
+1 on the version number
-1 on the inability to have coffee.  You poor man!

Christian Gruber

unread,
Sep 22, 2012, 1:27:53 PM9/22/12
to google...@googlegroups.com
My plan is to roll a release in q4.  Not a commitment but definitely my plan. 

Regards,
Christian

On Sep 22, 2012, at 6:01, ijuma <ism...@juma.me.uk> wrote:

Hi,

On Friday, 31 August 2012 03:33:37 UTC+1, Christian Gruber wrote:
Yeah - I'm wondering if you're pulling from something else.  At any rate, I'm going to be setting up an "official"  jenkins instance, with snapshot repository, but there's a lot of behind-the-scenes stuff shifting in the guice project, so hopefully I'll get to it before you all get too impatient.

Any update on this? I'm also interested on whether the behind-the-scenes stuff makes or more or less likely that we'll get a new release any time soon.

Best,
Ismael

--
You received this message because you are subscribed to the Google Groups "google-guice" group.
To view this discussion on the web visit https://groups.google.com/d/msg/google-guice/-/fXlhaGoKLF4J.

Christian Gruber

unread,
Oct 25, 2012, 1:21:39 PM10/25/12
to google...@googlegroups.com
Hi Ismael,

The truth is, we have no idea. Certainly there is no such plan at this
point.

Dagger is a promising project, inspired by Guice and developed by some
Guice authors and contributors as well as others. It solves some
problems differently, and the Guicey folks at Google are pretty excited
about it. But we don't know how it'll all shake out, and aren't trying
to pre-guess that.

Dagger was developed as a fit-to-purpose alternative for Square's
android needs, as they wanted a very similar pattern, but optimized for
their android cases, and they were awesome and included many of us at
Google early in its development. I think we can broaden its utility far
beyond the android case, but whether Dagger and Guice will converge
enough to call for Dagger to succeed Guice is way too far off to tell.
We're all committed to making kick-ass dependency-injection on Java and
related platforms, so we're just seeing where this all leads.

cheers,
Christian.


On 19 Oct 2012, at 14:39, ijuma wrote:

> Hi Chris,
>
> On Saturday, 22 September 2012 18:27:57 UTC+1, Christian Gruber wrote:
>
>> My plan is to roll a release in q4. Not a commitment but definitely
>> my
>> plan.
>>
>
> I've noticed that you've been contributing to Dagger (e.g.
> https://github.com/square/dagger/pull/67). Is the plan for Dagger to
> be the
> successor of Guice?
>
> Best,
> Ismael
>
> --
> You received this message because you are subscribed to the Google
> Groups "google-guice" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/google-guice/-/UQlwN46dPPcJ.
Reply all
Reply to author
Forward
0 new messages