MOE bug?

Thomas Broyer

unread,

Feb 15, 2014, 9:57:10 PM2/15/14

to googl...@googlegroups.com, Goktug Gokdogan

Hi,

I just noticed r277 (from MOE) reverted a couple changes from previous commits: https://code.google.com/p/google-gin/source/detail?r=277 (version="2.1.1" and target="1.5")

You might want to re-do them (at least use target=1.6 so as to not break people who haven't yet switched to GWT 2.6 and/or Java 7)

Goktug Gokdogan

unread,

Feb 18, 2014, 2:07:56 PM2/18/14

to ara...@gmail.com, googl...@googlegroups.com, Thomas Broyer

@Peter: Do you aware of this problem? It looks like you've overridden some external commits with MOE update.

Peter Schmitt

unread,

Feb 19, 2014, 2:33:44 PM2/19/14

to Goktug Gokdogan, Gin, Thomas Broyer

I can't trace back what exactly happened here (MOE isn't exactly the easiest system to use :) but I agree that the current state is backwards. I'll do a manual patch to the googlecode repository to fix this.

Peter Schmitt

unread,

Feb 19, 2014, 3:46:29 PM2/19/14

to Goktug Gokdogan, Gin, Thomas Broyer

Fixed in r281.

Reply all

Reply to author

Forward