Re: Issue 61 in google-gin: Provide a way to allow sub-injector instances

35 views
Skip to first unread message

googl...@googlecode.com

unread,
Mar 3, 2010, 2:48:20 AM3/3/10
to googl...@googlegroups.com

Comment #25 on issue 61 by philippe.beaudoin: Provide a way to allow
sub-injector instances
http://code.google.com/p/google-gin/issues/detail?id=61

@fazal.asim: I applied your patch to my version of GIN and it worked
perfectly. Thanks
a lot for dramatically simplifying the process of using GIN with code
splitting. Count
my vote for inclusion of this feature in GIN.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

googl...@googlecode.com

unread,
Mar 4, 2010, 1:08:37 AM3/4/10
to googl...@googlegroups.com

Comment #26 on issue 61 by second.c...@gmail.com: Provide a way to allow
sub-injector instances
http://code.google.com/p/google-gin/issues/detail?id=61

@philippe , rock !

googl...@googlecode.com

unread,
Mar 9, 2010, 6:34:26 PM3/9/10
to googl...@googlegroups.com

Comment #27 on issue 61 by urgisb: Provide a way to allow sub-injector
instances
http://code.google.com/p/google-gin/issues/detail?id=61

The AsyncProvider patch was priceless. It helped us to remove tons of code,
made the
design so much cleaner and lighter. No proxies, no multiple GIN
modules/ginjectors
needed.
We would really love to see it in the official GIN release.

googl...@googlecode.com

unread,
Mar 9, 2010, 9:16:04 PM3/9/10
to googl...@googlegroups.com

Comment #28 on issue 61 by fazal.asim: Provide a way to allow sub-injector
instances
http://code.google.com/p/google-gin/issues/detail?id=61

cool.. I will try to find some time this week to work on this.

googl...@googlecode.com

unread,
Mar 10, 2010, 5:49:20 AM3/10/10
to googl...@googlegroups.com

Comment #29 on issue 61 by spralle: Provide a way to allow sub-injector
instances
http://code.google.com/p/google-gin/issues/detail?id=61

I also would like to vote to get this into the official GIN releases. Can
anyone from
the team comment on a __rough__ schedule when this could be possible and
also if they
would consider including the patch?

googl...@googlecode.com

unread,
Mar 10, 2010, 7:55:06 AM3/10/10
to googl...@googlegroups.com

Comment #30 on issue 61 by andres.a.testi: Provide a way to allow
sub-injector instances
http://code.google.com/p/google-gin/issues/detail?id=61

AsyncProvider would too be useful to provide remote instances across RPC

googl...@googlecode.com

unread,
Mar 10, 2010, 2:39:29 PM3/10/10
to googl...@googlegroups.com
Updates:
Owner: aragos

Comment #31 on issue 61 by aragos: Provide a way to allow sub-injector
instances
http://code.google.com/p/google-gin/issues/detail?id=61

I'd be happy to include this, I'll work with Asim to get it into the code
base.

googl...@googlecode.com

unread,
Mar 19, 2010, 12:03:32 AM3/19/10
to googl...@googlegroups.com

Comment #32 on issue 61 by fazal.asim: Provide a way to allow sub-injector
instances
http://code.google.com/p/google-gin/issues/detail?id=61

ok, finally got it out for review:

http://codereview.appspot.com/646042

googl...@googlecode.com

unread,
Mar 29, 2010, 2:15:20 PM3/29/10
to googl...@googlegroups.com

Comment #33 on issue 61 by philippe.beaudoin: Provide a way to allow
sub-injector instances
http://code.google.com/p/google-gin/issues/detail?id=61

Any update on this? The code review has been stalled on some test failure
for a while.
I'd like to get it in my release of gwt-platform.

googl...@googlecode.com

unread,
Mar 29, 2010, 2:55:23 PM3/29/10
to googl...@googlegroups.com

Comment #34 on issue 61 by fazal.asim: Provide a way to allow sub-injector
instances
http://code.google.com/p/google-gin/issues/detail?id=61

The test failure was fixed, waiting on peter to try to patch it and try
again.

googl...@googlecode.com

unread,
Mar 29, 2010, 8:16:19 PM3/29/10
to googl...@googlegroups.com

Comment #35 on issue 61 by ross.m.smith: Provide a way to allow
sub-injector instances
http://code.google.com/p/google-gin/issues/detail?id=61

this should be invaluable to those of us doing GIN + runAsnyc, good work
guys and hope
to see it in a near future GIN build

googl...@googlecode.com

unread,
Mar 30, 2010, 9:16:03 AM3/30/10
to googl...@googlegroups.com

Comment #36 on issue 61 by koteskie: Provide a way to allow sub-injector
instances
http://code.google.com/p/google-gin/issues/detail?id=61

Any progress on the review / patch process?
No updates mentioned on the codereview page.
As a lot of people are really interested in this particluar fix it would be
nice if
we could move on to get this into trunk.

googl...@googlecode.com

unread,
Mar 30, 2010, 5:36:28 PM3/30/10
to googl...@googlegroups.com
Updates:
Status: Fixed

Comment #37 on issue 61 by aragos: Provide a way to allow sub-injector
instances
http://code.google.com/p/google-gin/issues/detail?id=61

Committed in r137. Many thanks to fazal.asim for submitting this patch!

googl...@googlecode.com

unread,
Mar 30, 2010, 7:28:00 PM3/30/10
to googl...@googlegroups.com

Comment #38 on issue 61 by philippe.beaudoin: Provide a way to allow
sub-injector instances
http://code.google.com/p/google-gin/issues/detail?id=61

Thanks so much to both of you! I simply replaced my old patched gin with
r137 and it
works like a charm. For anybody interested to get their hands on this
awesome feature I
packaged it in a jar at http://code.google.com/p/gwt-platform/

googl...@googlecode.com

unread,
Apr 6, 2010, 2:52:30 AM4/6/10
to googl...@googlegroups.com

Comment #39 on issue 61 by koteskie: Provide a way to allow sub-injector
instances
http://code.google.com/p/google-gin/issues/detail?id=61

Thanks a bunch. Great work & collaboration alltogether

googl...@googlecode.com

unread,
Apr 7, 2010, 5:16:14 AM4/7/10
to googl...@googlegroups.com

Comment #40 on issue 61 by sudhir.j: Provide a way to allow sub-injector
instances
http://code.google.com/p/google-gin/issues/detail?id=61

This was kick-ass work... can we get a quick note about async injectors
added to the wiki / tutorial page? With a
trunk-only disclaimer, of course. A quick explanation would be great.

googl...@googlecode.com

unread,
Apr 7, 2010, 9:01:01 AM4/7/10
to googl...@googlegroups.com

Comment #41 on issue 61 by fazal.asim: Provide a way to allow sub-injector
instances
http://code.google.com/p/google-gin/issues/detail?id=61

I plan to add some docs about this but haven't had the chance. stay tuned :)

googl...@googlecode.com

unread,
Apr 9, 2010, 9:03:00 PM4/9/10
to googl...@googlegroups.com

Comment #42 on issue 61 by philippe.beaudoin: Provide a way to allow
sub-injector instances
http://code.google.com/p/google-gin/issues/detail?id=61

I ran into a problem today where the development version of AsyncProvider
works well,
but the javascript version throws an Exception. I've documented it on the
forum:

http://groups.google.com/group/google-gin/browse_thread/thread/995db1ebccbc3104?hl=en
We may want to enter this as a separated bug, but I wasn't 100% sure it was
in
AsyncProvider.

googl...@googlecode.com

unread,
Jan 18, 2012, 9:41:32 PM1/18/12
to googl...@googlegroups.com

Comment #43 on issue 61 by Alexande...@gmail.com: Provide a way to allow
sub-injector instances
http://code.google.com/p/google-gin/issues/detail?id=61

Maybe I am wrong,I still can't figure out a way to share instance(for
example,EventBus) between multiple modules based on discussion of this
thread.Can anybody give an example,thanks in advance.

googl...@googlecode.com

unread,
Feb 17, 2012, 12:19:13 PM2/17/12
to googl...@googlegroups.com

Comment #44 on issue 61 by philipp....@gmail.com: Provide a way to allow
sub-injector instances
http://code.google.com/p/google-gin/issues/detail?id=61

I don't get it eather... how do I share the instance of the eventbus with a
child injector?

Thank you for any help!

googl...@googlecode.com

unread,
Feb 17, 2012, 12:49:30 PM2/17/12
to googl...@googlegroups.com

Comment #45 on issue 61 by fippi...@gmail.com: Provide a way to allow

googl...@googlecode.com

unread,
Apr 11, 2012, 12:05:08 AM4/11/12
to googl...@googlegroups.com

Comment #46 on issue 61 by Alexande...@gmail.com: Provide a way to allow
sub-injector instances
http://code.google.com/p/google-gin/issues/detail?id=61

Some guy provided a working
solution:http://www.amateurinmotion.com/articles/2009/11/02/async-with-gin.html,it
still works under(gwt 2.4+gin 1.5)

googl...@googlecode.com

unread,
Sep 10, 2014, 5:00:18 PM9/10/14
to googl...@googlegroups.com

Comment #47 on issue 61 by queen...@arcbees.com: Provide a way to allow
sub-injector instances
https://code.google.com/p/google-gin/issues/detail?id=61

Why is it that T is now a ? extends T?

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
Reply all
Reply to author
Forward
0 new messages