A lice-sized code review (wangxianzhu localrev 1313)

[phni...@gmail.com]

Hello james.su,

I'd like you to do a code review. Please review the following patch:

----------------------------------------------------------------------
r1313: (no author) | 2010-03-02 16:14:14 +0800

Fixed cmake unit test fails when compiled with new gcc compiler.
----------------------------------------------------------------------

=== cmake/TestSuite.cmake
==================================================================
--- cmake/TestSuite.cmake (revision 1312)
+++ cmake/TestSuite.cmake (revision 1313)
@@ -21,6 +21,10 @@
ENDMACRO(TEST_WRAPPER)
ELSE(WIN32)
MACRO(ADD_TEST_EXECUTABLE target)
+ IF(NOT ADD_TEST_EXECUTABLE_no_werror)
+ SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-extra -Wno-error")
+ SET(ADD_TEST_EXECUTABLE_no_werror TRUE)
+ ENDIF(NOT ADD_TEST_EXECUTABLE_no_werror)
ADD_EXECUTABLE("${target}" EXCLUDE_FROM_ALL ${ARGN})
ENDMACRO(ADD_TEST_EXECUTABLE)

Property changes on: extensions/html_flash_element
___________________________________________________________________
Name: svn:ignore
+Makefile.in
+

=== extensions/default_options/tests/CMakeLists.txt
==================================================================
--- extensions/default_options/tests/CMakeLists.txt (revision 1312)
+++ extensions/default_options/tests/CMakeLists.txt (revision 1313)
@@ -14,6 +14,6 @@
# limitations under the License.
#

-ADD_EXECUTABLE(default_options_test EXCLUDE_FROM_ALL default_options_test.cc)
+ADD_TEST_EXECUTABLE(default_options_test default_options_test.cc)
TARGET_LINK_LIBRARIES(default_options_test ggadget${GGL_EPOCH} gtest)
TEST_WRAPPER(default_options_test TRUE)
=== extensions/smjs_script_runtime/tests/CMakeLists.txt
==================================================================
--- extensions/smjs_script_runtime/tests/CMakeLists.txt (revision 1312)
+++ extensions/smjs_script_runtime/tests/CMakeLists.txt (revision 1313)
@@ -22,6 +22,7 @@
ggadget-js${GGL_EPOCH}
editline
ggadget-smjs
+ dl
${SMJS_LIBRARIES}
)

Property changes on: extensions/soup_xml_http_request/tests
___________________________________________________________________
Name: svn:ignore
+Makefile.in
+

Property changes on: extensions/soup_xml_http_request
___________________________________________________________________
Name: svn:ignore
+Makefile.in
+

This is a semiautomated message from "svkmail". Complaints or suggestions?
Mail edy...@gmail.com.

[James Su]

LGTM.

2010/3/2 <phni...@gmail.com>