A cockroach-sized code review (suzhe localrev 650)

1 view
Skip to first unread message

jame...@gmail.com

unread,
Jun 5, 2008, 11:29:18 PM6/5/08
to phni...@gmail.com, zhuan...@gmail.com, google-gadgets...@googlegroups.com
Hello phnixwxz, zhuang.dev,

I'd like you to do a code review. Please review the following patch:

----------------------------------------------------------------------
r650: suzhe | 2008-06-06 11:28:41 +0800

- Add missing header file.
- Add Simplified Chinese translation for rss_gadget and igoogle_gadget.
----------------------------------------------------------------------

=== rss_gadget/zh-CN (new directory)
==================================================================
=== rss_gadget/zh-CN/strings.xml
==================================================================
--- rss_gadget/zh-CN/strings.xml (revision 649)
+++ rss_gadget/zh-CN/strings.xml (revision 650)
@@ -0,0 +1,27 @@
+<!--
+ Copyright 2008 Google Inc.
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<strings>
+<GADGET_NAME>网络剪辑</GADGET_NAME>
+<GADGET_DESC>查看 RSS/Atom 供稿中的资讯.</GADGET_DESC>
+<GADGET_COPYRIGHT>Copyright 2008 Google Inc.</GADGET_COPYRIGHT>
+<GADGET_ABOUT>Google Gadgets for Linux</GADGET_ABOUT>
+<GADGET_URL>订阅 URL</GADGET_URL>
+<GADGET_REFRESH>刷新</GADGET_REFRESH>
+<GADGET_LOADING>正在加载...</GADGET_LOADING>
+<GADGET_ERROR>读取订阅时出错.</GADGET_ERROR>
+<GADGET_UNKNOWN>未知的订阅格式.</GADGET_UNKNOWN>
+</strings>
=== rss_gadget/en/strings.xml
==================================================================
--- rss_gadget/en/strings.xml (revision 649)
+++ rss_gadget/en/strings.xml (revision 650)
@@ -15,13 +15,13 @@
-->

<strings>
-<GADGET_NAME>Feed Reader</GADGET_NAME>
-<GADGET_DESC>View RSS and ATOM feeds.</GADGET_DESC>
+<GADGET_NAME>Web Clips</GADGET_NAME>
+<GADGET_DESC>View news from RSS/Atom feeds.</GADGET_DESC>
<GADGET_COPYRIGHT>Copyright 2008 Google Inc.</GADGET_COPYRIGHT>
<GADGET_ABOUT>Google Gadgets for Linux</GADGET_ABOUT>
<GADGET_URL>Feed URL</GADGET_URL>
<GADGET_REFRESH>Refresh</GADGET_REFRESH>
<GADGET_LOADING>Loading...</GADGET_LOADING>
-<GADGET_ERROR>Error reading feed</GADGET_ERROR>
-<GADGET_UNKNOWN>Unknown feed format</GADGET_UNKNOWN>
+<GADGET_ERROR>Error reading feed.</GADGET_ERROR>
+<GADGET_UNKNOWN>Unknown feed format.</GADGET_UNKNOWN>
</strings>
=== rss_gadget/gadget.gmanifest
==================================================================
--- rss_gadget/gadget.gmanifest (revision 649)
+++ rss_gadget/gadget.gmanifest (revision 650)
@@ -14,7 +14,7 @@
limitations under the License.
-->

-<gadget minimumGoogleDesktopVersion="4.2006.508.0">
+<gadget minimumGoogleDesktopVersion="5.7.0.0">
<about>
<id>F4C39E45-982B-4E2F-A43B-2DE80B567455</id>
<version>1.0.0.0</version>
=== rss_gadget/Makefile.am
==================================================================
--- rss_gadget/Makefile.am (revision 649)
+++ rss_gadget/Makefile.am (revision 650)
@@ -14,6 +14,7 @@
# limitations under the License.

RSS_GADGET_FILES= en/strings.xml \
+ zh-CN/strings.xml \
gadget.gmanifest \
large_rss_icon.png \
main.js \
=== igoogle_gadget/zh-CN (new directory)
==================================================================
=== igoogle_gadget/zh-CN/strings.xml
==================================================================
--- igoogle_gadget/zh-CN/strings.xml (revision 649)
+++ igoogle_gadget/zh-CN/strings.xml (revision 650)
@@ -0,0 +1,26 @@
+<!--
+ Copyright 2008 Google Inc.
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<strings>
+<GADGET_NAME>iGoogle Gadget</GADGET_NAME>
+<GADGET_DESC>Run iGoogle gadgets.</GADGET_DESC>
+<GADGET_REQUIRED>很抱歉, 在您提供所有需要的设置之前无法显示小工具.</GADGET_REQUIRED>
+<GADGET_SHOWOPTIONS>选项...</GADGET_SHOWOPTIONS>
+<GADGET_REFRESH>刷新</GADGET_REFRESH>
+<GADGET_LOADING>正在加载...</GADGET_LOADING>
+<GADGET_ERROR>加载小工具时出错.</GADGET_ERROR>
+<GADGET_NOTLOADED>正在加载选项...</GADGET_NOTLOADED>
+</strings>

Property changes on: igoogle_gadget/zh-CN/strings.xml
___________________________________________________________________
Name: svn:executable
+*

=== igoogle_gadget/en/strings.xml
==================================================================
--- igoogle_gadget/en/strings.xml (revision 649)
+++ igoogle_gadget/en/strings.xml (revision 650)
@@ -17,7 +17,7 @@
<strings>
<GADGET_NAME>iGoogle Gadget</GADGET_NAME>
<GADGET_DESC>Run iGoogle gadgets.</GADGET_DESC>
-<GADGET_REQUIRED>Sorry! Gadget cannot be displayed until all required settings are provided.</GADGET_REQUIRED>
+<GADGET_REQUIRED>Sorry, Gadget cannot be displayed until all required settings are provided.</GADGET_REQUIRED>
<GADGET_SHOWOPTIONS>Options...</GADGET_SHOWOPTIONS>
<GADGET_REFRESH>Refresh</GADGET_REFRESH>
<GADGET_LOADING>Loading...</GADGET_LOADING>
=== igoogle_gadget/gadget.gmanifest
==================================================================
--- igoogle_gadget/gadget.gmanifest (revision 649)
+++ igoogle_gadget/gadget.gmanifest (revision 650)
@@ -14,7 +14,7 @@
limitations under the License.
-->

-<gadget minimumGoogleDesktopVersion="4.2006.508.0">
+<gadget minimumGoogleDesktopVersion="5.7.0.0">
<about>
<id>570E7D97-1AC4-4AF5-A506-8D287C58FE47</id>
<version>1.0.0.0</version>
=== igoogle_gadget/Makefile.am
==================================================================
--- igoogle_gadget/Makefile.am (revision 649)
+++ igoogle_gadget/Makefile.am (revision 650)
@@ -14,6 +14,7 @@
# limitations under the License.

IGOOGLE_GADGET_FILES= en/strings.xml \
+ zh-CN/strings.xml \
gadget.gmanifest \
igoogle_32.gif \
main.js \
=== ggadget/basic_element.cc
==================================================================
--- ggadget/basic_element.cc (revision 649)
+++ ggadget/basic_element.cc (revision 650)
@@ -17,6 +17,7 @@
// Enable it to print verbose debug info
// #define EVENT_VERBOSE_DEBUG

+#include <cmath>
#include <cstdlib>
#include <vector>
#include "basic_element.h"

This is a semiautomated message from "svkmail". Complaints or suggestions?
Mail edy...@gmail.com.

Xianzhu Wang

unread,
Jun 6, 2008, 12:04:08 AM6/6/08
to jame...@gmail.com, zhuan...@gmail.com, google-gadgets...@googlegroups.com
Punctuations in Chinese text should use Chinese style ones.

在 08-6-6，jame...@gmail.com<jame...@gmail.com> 写道：

Jim Zhuang

unread,
Jun 6, 2008, 2:07:06 AM6/6/08
to jame...@gmail.com, phni...@gmail.com, google-gadgets...@googlegroups.com
why was the English text for GADGET_REQUIRED changed? The old text is
identical to that used in the Windows version.

2008/6/6 <jame...@gmail.com>:

Jim Zhuang

unread,
Jun 6, 2008, 2:10:05 AM6/6/08
to jame...@gmail.com, phni...@gmail.com, google-gadgets...@googlegroups.com
Plus, if the "!" is changed to "," then "Gadget" should be changed to "gadget"

2008/6/6 Jim Zhuang <zhuan...@gmail.com>:

Zhe Su

unread,
Jun 6, 2008, 2:11:23 AM6/6/08
to Jim Zhuang, phni...@gmail.com, google-gadgets...@googlegroups.com
I can't find the message in TC. And I think "," should be better. I'll change Gadget to lowercase.

2008/6/6 Jim Zhuang <zhuan...@gmail.com>:
why was the English text for GADGET_REQUIRED changed? The old text is
identical to that used in the Windows version.

Jim Zhuang

unread,
Jun 6, 2008, 2:12:32 AM6/6/08
to Zhe Su, phni...@gmail.com, google-gadgets...@googlegroups.com
Just add a gadget requiring user settings and you'll see the message.

2008/6/6 Zhe Su <jame...@gmail.com>:


> I can't find the message in TC. And I think "," should be better. I'll
> change Gadget to lowercase.
>
> 2008/6/6 Jim Zhuang <zhuan...@gmail.com>:
>>
>> why was the English text for GADGET_REQUIRED changed? The old text is
>> identical to that used in the Windows version.
>>

>> 2008/6/6 <jame...@gmail.com>:

Reply all
Reply to author
Forward
0 new messages