[ggl-dev] A lice-sized code review (wangxianzhu localrev 1321)

[phni...@gmail.com]

Hello james.su,

I'd like you to do a code review. Please review the following patch:

----------------------------------------------------------------------
r1321: (no author) | 2010-05-24 15:07:39 +0800

1. Avoid unexpected scrolling to top if ClearSelection() is called after SetSelectedItem() in the same loop;
2. Fix some build issues
----------------------------------------------------------------------

=== extensions/soup_xml_http_request/soup_xml_http_request.cc
==================================================================
--- extensions/soup_xml_http_request/soup_xml_http_request.cc (revision 1320)
+++ extensions/soup_xml_http_request/soup_xml_http_request.cc (revision 1321)
@@ -857,6 +857,9 @@

static void MessageCompleteCallback(SoupSession *session, SoupMessage *msg,
gpointer user_data) {
+ GGL_UNUSED(session);
+ GGL_UNUSED(msg);
+
XMLHttpRequest *request = static_cast<XMLHttpRequest *>(user_data);
#ifdef SOUP_XHR_VERBOSE
PrintMessageInfo(request, "MessageCompleteCallback", msg, NULL);
@@ -1073,6 +1076,11 @@
static void LoggerPrinter(SoupLogger *logger, SoupLoggerLogLevel level,
char direction, const char *data,
gpointer user_data) {
+ GGL_UNUSED(logger);
+ GGL_UNUSED(level);
+ GGL_UNUSED(direction);
+ GGL_UNUSED(data);
+ GGL_UNUSED(user_data);
DLOG("%c %s\n", direction, data);
}
#endif
@@ -1082,6 +1090,9 @@
SoupAuth *auth,
gboolean retrying,
gpointer user_data) {
+ GGL_UNUSED(session);
+ GGL_UNUSED(user_data);
+
XMLHttpRequest *request = static_cast<XMLHttpRequest *>(
g_object_get_data(G_OBJECT(msg), kSoupMessageXHRKey));
ASSERT(request);
@@ -1101,6 +1112,10 @@
SoupMessage *msg,
SoupSocket *socket,
gpointer user_data) {
+ GGL_UNUSED(session);
+ GGL_UNUSED(socket);
+ GGL_UNUSED(user_data);
+
XMLHttpRequest *request = static_cast<XMLHttpRequest *>(
g_object_get_data(G_OBJECT(msg), kSoupMessageXHRKey));
#ifdef SOUP_XHR_VERBOSE
=== extensions/soup_xml_http_request/tests/CMakeLists.txt
==================================================================
--- extensions/soup_xml_http_request/tests/CMakeLists.txt (revision 1320)
+++ extensions/soup_xml_http_request/tests/CMakeLists.txt (revision 1321)
@@ -17,12 +17,14 @@
IF(GGL_BUILD_SOUP_XML_HTTP_REQUEST)

APPLY_CONFIG(GTK2)
+APPLY_CONFIG(PTHREAD)

ADD_TEST_EXECUTABLE(soup_xml_http_request_test
soup_xml_http_request_test.cc
)
TARGET_LINK_LIBRARIES(soup_xml_http_request_test
${GTK2_LIBRARIES}
+ ${PTHREAD_LIBRARIES}
ggadget${GGL_EPOCH}
ggadget-gtk${GGL_EPOCH}
gtest
=== hosts/gtk/standalone_gtk_host.cc
==================================================================
--- hosts/gtk/standalone_gtk_host.cc (revision 1320)
+++ hosts/gtk/standalone_gtk_host.cc (revision 1321)
@@ -227,6 +227,7 @@
}

void RemoveGadget(Gadget *gadget, bool save_data) {
+ GGL_UNUSED(gadget);
GGL_UNUSED(save_data);
ASSERT(gadget && gadget == gadget_);
owner_->Exit();
=== ggadget/listbox_element.cc
==================================================================
--- ggadget/listbox_element.cc (revision 1320)
+++ ggadget/listbox_element.cc (revision 1321)
@@ -136,6 +136,10 @@
if (item->IsSelected()) {
result = true;
item->SetSelected(false);
+
+ // Clear pending scroll flag to avoid unexpected scrolling to
+ // the top of the list.
+ pending_scroll_ = 0;
}
} else {
LOG(kErrorItemExpected);
=== ggadget/gtk/view_widget_binder.cc
==================================================================
--- ggadget/gtk/view_widget_binder.cc (revision 1320)
+++ ggadget/gtk/view_widget_binder.cc (revision 1321)
@@ -827,7 +827,10 @@
guint info, guint time,
gpointer user_data) {
GGL_UNUSED(widget);
+ GGL_UNUSED(x);
+ GGL_UNUSED(y);
GGL_UNUSED(info);
+
Impl *impl = reinterpret_cast<Impl *>(user_data);
if (!impl->current_drag_event_) {
// There are some cases that multiple drag events are fired in one event

This is a semiautomated message from "svkmail". Complaints or suggestions?
Mail edy...@gmail.com.

[James Su]

LGTM

2010/5/24 <phni...@gmail.com>