A lice-sized code review (suzhe localrev 1604)

0 views
Skip to first unread message

jame...@gmail.com

unread,
Dec 3, 2009, 3:49:21 AM12/3/09
to phni...@gmail.com, google-gadgets...@googlegroups.com
Hello phnixwxz,

I'd like you to do a code review. Please review the following patch:

----------------------------------------------------------------------
r1604: suzhe | 2009-12-03 16:48:55 +0800

- Fix a failure test.
- Fix two build issues.
----------------------------------------------------------------------

=== ggadget/dbus/tests/Makefile.am
==================================================================
--- ggadget/dbus/tests/Makefile.am (revision 1603)
+++ ggadget/dbus/tests/Makefile.am (revision 1604)
@@ -24,6 +24,7 @@
LDADD = $(top_builddir)/unittest/libgtest.la \
$(top_builddir)/ggadget/libggadget@GGL_EPOCH@.la \
$(top_builddir)/ggadget/dbus/libggadget-dbus@GGL_EPOCH@.la \
+ $(DBUS_LIBS) \
$(PTHREAD_LIBS)

check_PROGRAMS = dbus_test \
=== ggadget/tests/scriptable_helper_test.cc
==================================================================
--- ggadget/tests/scriptable_helper_test.cc (revision 1603)
+++ ggadget/tests/scriptable_helper_test.cc (revision 1604)
@@ -395,8 +395,8 @@
"SCONSTANT9", "SetCallback", "SignalResult", "NativeOwned", "ObjectMethod",
"MethodDouble2", "ClearBuffer", "VALUE_0", "VALUE_1", "VALUE_2",
"VariantProperty", "length", "my_ondelete", "onlunch", "onsupper",
- "ontest", "time", "oncomplex", "FireComplexSignal", "ComplexSignalData",
- "IntProperty", ""
+ "ontest", "time", "oncomplex", "FireComplexSignal", "FireDynamicSignal",
+ "ComplexSignalData", "IntProperty", ""
};
std::set<std::string> expected;
for (size_t i = 0; i < arraysize(property_names); ++i)
=== ggadget/gtk/tests/Makefile.am
==================================================================
--- ggadget/gtk/tests/Makefile.am (revision 1603)
+++ ggadget/gtk/tests/Makefile.am (revision 1604)
@@ -35,6 +35,9 @@
$(top_builddir)/ggadget/libggadget@GGL_EPOCH@.la \
$(top_builddir)/ggadget/gtk/libggadget-gtk@GGL_EPOCH@.la

+if GTK2_TARGET_X11
+ LDADD += $(X_LIBS)
+endif

check_PROGRAMS = cairo_canvas_test \
cairo_graphics_test \

This is a semiautomated message from "svkmail". Complaints or suggestions?
Mail edy...@gmail.com.

Xianzhu Wang

unread,
Dec 3, 2009, 3:51:16 AM12/3/09
to jame...@gmail.com, google-gadgets...@googlegroups.com
LGTM

2009/12/3 <james.su@gmail.com>
Reply all
Reply to author
Forward
0 new messages