A lice-sized code review (suzhe localrev 1617)

0 views
Skip to first unread message

jame...@gmail.com

unread,
Jan 14, 2010, 8:56:11 PM1/14/10
to phni...@gmail.com, google-gadgets...@googlegroups.com
Hello phnixwxz,

I'd like you to do a code review. Please review the following patch:

----------------------------------------------------------------------
r1617: suzhe | 2010-01-15 09:55:44 +0800

Fix a typo.

----------------------------------------------------------------------

=== gadgets/digital_alarm_clock/options.js
==================================================================
--- gadgets/digital_alarm_clock/options.js (revision 1616)
+++ gadgets/digital_alarm_clock/options.js (revision 1617)
@@ -24,7 +24,7 @@
/**
* Method called when options are opened
*/
-function onOpen() {
+function _onOpen() {
oString1.innerText = ALARM_SET;
oString2.innerText = DEFAULT_ALARM;
oString3.innerText = USE_FILE;

This is a semiautomated message from "svkmail". Complaints or suggestions?
Mail edy...@gmail.com.

Xianzhu Wang

unread,
Jan 14, 2010, 11:25:25 PM1/14/10
to jame...@gmail.com, google-gadgets...@googlegroups.com
LGTM.

2010/1/15 <jame...@gmail.com>:

Reply all
Reply to author
Forward
0 new messages