A lice-sized code review (wangxianzhu localrev 1299)

[Xianzhu Wang]

From: phni...@gmail.com
To: jame...@gmail.com
Cc: google-gadgets...@googlegroups.com
Bcc: phni...@gmail.com
Subject: A lice-sized code review (wangxianzhu localrev 1299)

Hello james.su,

I'd like you to do a code review. Please review the following patch:

----------------------------------------------------------------------
r1299: (no author) | 2010-01-15 14:01:43 +0800

Let ongotourl signal hook to any new url opened for new window on
inside the window.
----------------------------------------------------------------------

=== extensions/gtkmoz_browser_element/browser_element.cc
==================================================================
--- extensions/gtkmoz_browser_element/browser_element.cc (revision 1298)
+++ extensions/gtkmoz_browser_element/browser_element.cc (revision 1299)
@@ -1087,14 +1087,15 @@
LOG("%s feedback needs 3 parameters, but only %zu is given",
kOpenURLFeedback, param_count);
} else {
- result = OpenURL(params[2]) ? '1' : '0';
+ result = ongotourl_signal_(params[2], true) || OpenURL(params[2]) ?
+ '1' : '0';
}
} else if (strcmp(type, kGoToURLFeedback) == 0) {
if (param_count != 3) {
LOG("%s feedback needs 3 parameters, but only %zu is given",
kGoToURLFeedback, param_count);
} else {
- result = ongotourl_signal_(params[2]) ? '1' : '0';
+ result = ongotourl_signal_(params[2], false) ? '1' : '0';
}
} else if (strcmp(type, kNetErrorFeedback) == 0) {
if (param_count != 3) {
@@ -1142,7 +1143,7 @@
Connection *minimized_connection_, *restored_connection_,
*popout_connection_, *popin_connection_,
*dock_connection_, *undock_connection_;
- Signal1<bool, const char *> ongotourl_signal_;
+ Signal2<bool, const char *, bool> ongotourl_signal_;
Signal1<bool, const char *> onerror_signal_;
};

[James Su]

LGTM.

2010/1/15 Xianzhu Wang <phni...@gmail.com>

[phni...@gmail.com]

Hello james.su,

This is a semiautomated message from "svkmail". Complaints or suggestions?
Mail edy...@gmail.com.