patch to fix broken IE6/7 support

151 views
Skip to first unread message

Felipe Gasper

unread,
Mar 15, 2010, 1:06:39 PM3/15/10
to google-...@googlegroups.com
Change 71 appears to have broken IE6/7 support; at least, the IE6 and
IE7 VMs that I maintain aren�t working with the latest trunk revision.

The following patch appears to fix it:

--------------------------------
Index: excanvas.js
===================================================================
--- excanvas.js (revision 71)
+++ excanvas.js (working copy)
@@ -91,12 +91,7 @@

function addNamespace(doc, prefix, urn) {
if (!doc.namespaces[prefix]) {
- if (IE_VERSION >= 7) {
- doc.namespaces.add(prefix, urn).doImport('#default#VML');
- } else {
- // IE6 cannot handle the third argument.
- doc.namespaces.add(prefix, urn);
- }
+ doc.namespaces.add(prefix, urn, '#default#VML');
}
}
---------------------------------------

What is the best way to submit this?

-FG

--
Felipe M. L. Gasper
http://felipegasper.com

"Wisdom can never learn enough. Ignorance is sufficient unto itself."
-Mechtild of Magdeburg

"Dad always thought laughter was the best medicine,
which I guess is why several of us died of tuberculosis."
-Jack Handey

Fabien Ménager

unread,
Mar 15, 2010, 1:14:50 PM3/15/10
to google-excanvas
Hello, the best way to submit this is to star this issue :
http://code.google.com/p/explorercanvas/issues/detail?id=66
;)

On Mar 15, 6:06 pm, Felipe Gasper <fgas...@freeshell.org> wrote:
> Change 71 appears to have broken IE6/7 support; at least, the IE6 and

> IE7 VMs that I maintain aren t working with the latest trunk revision.


>
> The following patch appears to fix it:
>
> --------------------------------
> Index: excanvas.js
> ===================================================================
> --- excanvas.js (revision 71)
> +++ excanvas.js (working copy)
> @@ -91,12 +91,7 @@
>
>     function addNamespace(doc, prefix, urn) {
>       if (!doc.namespaces[prefix]) {
> -      if (IE_VERSION >= 7) {
> -        doc.namespaces.add(prefix, urn).doImport('#default#VML');
> -      } else {
> -        // IE6 cannot handle the third argument.
> -        doc.namespaces.add(prefix, urn);
> -      }
> +      doc.namespaces.add(prefix, urn, '#default#VML');
>       }
>     }
> ---------------------------------------
>
> What is the best way to submit this?
>
> -FG
>
> --

> Felipe M. L. Gasperhttp://felipegasper.com

Reply all
Reply to author
Forward
0 new messages