Issue 4857 in support: Looking at commit changes it sometimes says the whole file was new
sup...@googlecode.com
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 4857 by fam....@live.nl: Looking at commit changes it sometimes
says the whole file was new
http://code.google.com/p/support/issues/detail?id=4857
What steps will reproduce the problem?
Step 1. Go to http://code.google.com/p/adblockforchrome/source/detail?r=1607
Step 2. Click the + button to expand the code changes
Step 3. Notice it says the whole file is new. However, that's not true, as
the file also existed in r1606 and earlier.
What is the expected output? What do you see instead?
Expected: changes only should be green.
Instead: whole file is marked as new
What browser (or hg/svn client) are you using? On what operating system?
Windows 7, Chrome 10
sup...@googlecode.com
Status: Accepted
Owner: jaco...@google.com
Labels: -Priority-Medium Priority-Low Component-SourceBrowsing
Comment #1 on issue 4857 by jac...@google.com: Looking at commit changes
it sometimes says the whole file was new
http://code.google.com/p/support/issues/detail?id=4857
The svn command line gets it right, so this is probably our bug. Likely
related:
http://code.google.com/p/adblockforchrome/source/browse/branches/issue-4986/options/blacklist.html?r=1607
doesn't show the revision info that is normally present.
~$ svn diff -c 1607 http://adblockforchrome.googlecode.com/svn
Index: branches/issue-4986/options/blacklist.html
===================================================================
--- branches/issue-4986/options/blacklist.html (revision 1606)
+++ branches/issue-4986/options/blacklist.html (revision 1607)
@@ -87,7 +87,7 @@
var blockDomain = $("#txtBlockUrlDomain").val().trim();
if (blockDomain == '*')
blockDomain = '';
- else if (blockDomain)
+ if (blockDomain)
blockDomain = '$domain=' + blockDomain;
var ok = false;
try {