Issue 1111 in google-caja: "use subset" grammar in ES5 spec changed from what we implemented.

0 views
Skip to first unread message

googl...@googlecode.com

unread,
Oct 21, 2009, 10:26:21 PM10/21/09
to google-ca...@googlegroups.com

Comment #5 on issue 1111 by mikesamuel: "use subset" grammar in ES5 spec
changed from what we implemented.
http://code.google.com/p/google-caja/issues/detail?id=1111

This requires
(1) changing UseSubsetDirective to DirectivePrologue.
The former contains a set of strings like "strict" or "cajita".
DirectivePrologue should contain a set of strings like "use strict"
and
"use cajita" and should have a boolean uses(String name) method.
The set is the raw text of the strings parsed minus quotation marks.
(2) changing the parser to produce DirectivePrologues instead
of UseSubsetDirectives and update clients.
(3) changing the render method. The render method is problematic, since
where escape sequences appear is significant in use subset directives,
but we need to be able to normalize string literals, so our render
method
should just omit any parts for which the properly escaped version is
not
the same as the string.
(3) updating all uses of the old syntax.
(4) change quasiliteral uses of the UseSubsetDirective.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

googl...@googlecode.com

unread,
Oct 29, 2009, 5:00:26 PM10/29/09
to google-ca...@googlegroups.com
Updates:
Status: Pending

Comment #6 on issue 1111 by ihab.awad: "use subset" grammar in ES5 spec

Pending in http://codereview.appspot.com/136053/

googl...@googlecode.com

unread,
Nov 13, 2009, 4:49:59 PM11/13/09
to google-ca...@googlegroups.com
Updates:
Status: Fixed

Comment #7 on issue 1111 by ihab.awad: "use subset" grammar in ES5 spec
Fixed in r3846.
Reply all
Reply to author
Forward
0 new messages