[google-caja] r4890 committed - shorten the top-level var warning...

3 views
Skip to first unread message

googl...@googlecode.com

unread,
May 25, 2012, 1:58:34 AM5/25/12
to caja....@gmail.com
Revision: 4890
Author: fel...@gmail.com
Date: Thu May 24 22:58:18 2012
Log: shorten the top-level var warning
http://codereview.appspot.com/6244054

When building caja, one of the warning messages starts

[transform] LINT : css-defs.js:46+1 - 777+7: Top level variable
declarations incompatiable with Caja. Please rewrite as
window[ 'cssSchema' ] = (function () {

and continues for 730 lines.

There are several messages like this. The one for Domado is 4328 lines.

This change omits the rhs of these warning messages.

R=meta...@gmail.com

http://code.google.com/p/google-caja/source/detail?r=4890

Modified:
/trunk/src/com/google/caja/parser/quasiliteral/ES53Rewriter.java

=======================================
--- /trunk/src/com/google/caja/parser/quasiliteral/ES53Rewriter.java Tue
May 8 16:20:51 2012
+++ /trunk/src/com/google/caja/parser/quasiliteral/ES53Rewriter.java Thu
May 24 22:58:18 2012
@@ -17,7 +17,6 @@
import static com.google.caja.parser.js.SyntheticNodes.s;

import com.google.caja.lexer.FilePosition;
-import com.google.caja.lexer.TokenConsumer;
import com.google.caja.parser.ParseTreeNode;
import com.google.caja.parser.ParseTreeNodeContainer;
import com.google.caja.parser.js.ArrayConstructor;
@@ -65,14 +64,10 @@
import com.google.caja.parser.js.TryStmt;
import com.google.caja.parser.js.UncajoledModule;
import com.google.caja.parser.js.ValueProperty;
-import com.google.caja.render.Concatenator;
-import com.google.caja.render.JsMinimalPrinter;
-import com.google.caja.render.JsPrettyPrinter;
import com.google.caja.reporting.BuildInfo;
import com.google.caja.reporting.MessageLevel;
import com.google.caja.reporting.MessagePart;
import com.google.caja.reporting.MessageQueue;
-import com.google.caja.reporting.RenderContext;
import com.google.caja.util.Lists;
import com.google.caja.util.Sets;

@@ -1001,9 +996,8 @@
RewriterMessageType.TOP_LEVEL_VAR_INCOMPATIBLE_WITH_CAJA,
node.getFilePosition(),
MessagePart.Factory.valueOf(
- render(QuasiBuilder.substV("window['@v'] = @r",
- "v", v,
- "r", r))));
+ render(QuasiBuilder.substV("window['@v']", "v", v))
+ + " = ..."));
return newExprStmt((Expression) substV(
"v", v,
"r", expand(nymize(r, vname, "var"), scope)));
Reply all
Reply to author
Forward
0 new messages