Issue 303 in google-breakpad: Patch for better version handling in minidump for Mac binaries

[codesite...@google.com]

Status: New
Owner: ----

New issue 303 by cedric.luthi: Patch for better version handling in
minidump for Mac binaries
http://code.google.com/p/google-breakpad/issues/detail?id=303

This patch extracts and sets the version of the main executable if present
in the __TEXT __version
section. It also handle versions when we're in the same process as the
crashed process.

Attachments:
breakpad_mac_version.patch 5.6 KB

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

[codesite...@google.com]

Updates:
Cc: nealsid

Comment #1 on issue 303 by ted.mielczarek: Patch for better version

handling in minidump for Mac binaries
http://code.google.com/p/google-breakpad/issues/detail?id=303

Hi cedric, I'm interested in taking your patch (sorry for the delay!) Do
you have a
contributor agreement on file with Google? If not, could you fill out the
form (you
can do it on the webpage):
http://code.google.com/legal/individual-cla-v1.0.html

Google needs to have this on file for everyone we take non-trivial patches
from.

Thanks!

[codesite...@google.com]

Comment #2 on issue 303 by cedric.luthi: Patch for better version handling

in minidump for Mac binaries
http://code.google.com/p/google-breakpad/issues/detail?id=303

I just agreed to the CLA.

Also, after further testing, I changed the __version to go to the __DATA
segment instead of the __TEXT segment.
You should replace SEG_TEXT with SEG_DATA and __TEXT with __DATA in the
patch. I don't remember the exact
problem, but it was definitely not working well when in the __TEXT segment.