Issue 325 in google-breakpad: CustomInfoEntry crash (windows)

5 views
Skip to first unread message

codesite...@google.com

unread,
Jun 26, 2009, 4:59:10 PM6/26/09
to google-brea...@googlegroups.com
Status: New
Owner: ----

New issue 325 by c...@chromium.org: CustomInfoEntry crash (windows)
http://code.google.com/p/google-breakpad/issues/detail?id=325

google_breakpad::CustomInfoEntry::set_name and set_value use safe_wcscpy()
which crashes (calls invalid_param_handler) if the length is bigger than
64.

From msdn
"If strDestination or strSource is a null pointer, or if the destination
string is too small, the invalid parameter handler is invoked as described
in Parameter Validation. If execution is allowed to continue, these
functions return EINVAL and set errno to EINVAL."

The breakpad header (string_utils) says that this should not fail (line 75)

I think it should truncate and not raise a fatal error as the documentation
states. Basically use safe_wcsncpy.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

codesite...@google.com

unread,
Jun 26, 2009, 5:03:13 PM6/26/09
to google-brea...@googlegroups.com
Updates:
Owner: doshimun

Comment #1 on issue 325 by nsylvain: CustomInfoEntry crash (windows)
http://code.google.com/p/google-breakpad/issues/detail?id=325

Munjal, can you take a look please?

Thanks

Nicolas

Reply all
Reply to author
Forward
0 new messages