Issue 341 in google-breakpad: Using explicit unicode strings with non explicit unicode api

[codesite...@google.com]

Status: New
Owner: ----

New issue 341 by daher.alfawares: Using explicit unicode strings with non
explicit unicode api
http://code.google.com/p/google-breakpad/issues/detail?id=341

A comment on the code and the use of the Win32 API.

The source files assumes UNICODE to be globally defined. It uses
LoadLibrary() with explicit L"unicode" strings.

Since LoadLibrary is either LoadLibraryA or LoadLibraryW .. then the use
of L"" explicitly takes out this API flexibility.

I suggest using _T("") or _TEXT("") for a wider range of users. I.E. Those
who does not globally accept UNICODE to be defined.

Another option is
{{{
#ifndef UNICODE
#define UNICODE
#endif
}}}
before including windows headers.

Thanks for maintaining this project.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings