Code review: Use "%" PRIx64 instead of "%llx" (#241)

[Mark Mentovai]

bryner,

I've got a patch to switch us away from %llx when PRIx64 is available:

http://code.google.com/p/google-breakpad/issues/detail?id=241

Review appreciated. Thanks in advance,
Mark

[Brian Ryner]

Looks good to me.  We may want to make similar changes for the client libraries and tools, too.

Thanks,

--
-Brian

[Mark Mentovai]

Also LGTM on the missed llx.

[Brian Ryner]

Found one you missed:

Index: src/processor/minidump_stackwalk.cc
===================================================================
--- src/processor/minidump_stackwalk.cc (revision 242)
+++ src/processor/minidump_stackwalk.cc (working copy)
@@ -268,7 +268,7 @@
        ++module_sequence) {
     const CodeModule *module = modules->GetModuleAtSequence(module_sequence);
     u_int64_t base_address = module->base_address();
-    printf("0x%08llx - 0x%08llx  %s  %s%s\n",
+    printf("0x%08" PRIx64 " - 0x%08" PRIx64 "  %s  %s%s\n",
            base_address, base_address + module->size() - 1,
            PathnameStripper::File(module->code_file()).c_str(),
            module->version().empty() ? "???" : module->version().c_str(),
@@ -298,7 +298,7 @@
        ++module_sequence) {
     const CodeModule *module = modules->GetModuleAtSequence(module_sequence);
     u_int64_t base_address = module->base_address();
-    printf("Module%c%s%c%s%c%s%c%s%c0x%08llx%c0x%08llx%c%d\n",
+    printf("Module%c%s%c%s%c%s%c%s%c0x%08" PRIx64 "%c0x%08" PRIx64 "%c%d\n",
            kOutputSeparator,
            StripSeparator(PathnameStripper::File(module->code_file())).c_str(),
            kOutputSeparator, StripSeparator(module->version()).c_str(),

--
-Brian