the...@chromium.org
unread,May 15, 2012, 4:14:44 PM5/15/12Sign in to reply to author
Sign in to forward
You do not have permission to delete messages in this group
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to c...@chromium.org, c...@chromium.org, google-br...@googlegroups.com, re...@breakpad-hr.appspotmail.com
Reviewers: Cris Neckar,
cpu_chromium.org,
Message:
Coverity complains about this variable being uninitialized after r961. I
think this should fix it, but I'm doing this blindly since I'm not on
Windows.
Description:
Initialize a CustomClientInfo variable. (Coverity)
Please review this at
https://breakpad.appspot.com/390003/
Affected files:
M src/client/windows/crash_generation/crash_generation_client.cc
Index: src/client/windows/crash_generation/crash_generation_client.cc
===================================================================
--- src/client/windows/crash_generation/crash_generation_client.cc
(revision 965)
+++ src/client/windows/crash_generation/crash_generation_client.cc (working
copy)
@@ -173,7 +173,7 @@
return false;
}
- CustomClientInfo custom_info;
+ CustomClientInfo custom_info = {NULL, 0};
ProtocolMessage msg(MESSAGE_TAG_UPLOAD_REQUEST, crash_id,
static_cast<MINIDUMP_TYPE>(NULL), NULL, NULL, NULL,
custom_info, NULL, NULL, NULL);