RISC-V contribution on breakpad

42 views
Skip to first unread message

Iacopo Colonnelli

unread,
Aug 28, 2022, 7:09:16 AM8/28/22
to Google Breakpad Development
Hello,
I'd like to submit a contribution that extends breakpad compatibility to RISC-V architectures.
I just signed the Individual CLA as requested. Which are the next steps? There are unit/integration tests that I should run to verify my implementation before submission?

Mike Frysinger

unread,
Aug 28, 2022, 7:37:32 AM8/28/22
to google-br...@googlegroups.com
make sure `make check` passes

--
You received this message because you are subscribed to the Google Groups "Google Breakpad Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-breakpad...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-breakpad-dev/92af549c-2ffc-428e-8227-96d0826cf7d4n%40googlegroups.com.

Iacopo Colonnelli

unread,
Sep 5, 2022, 6:42:58 AM9/5/22
to Google Breakpad Development
Hi,
Finally all make check tests passed.
I just submitted the change request to the chromium-review platform. This is the link i received
Now the doc says that I should manually add reviewers, but I have no idea which people will be in charge of reviewing that particular code.
Do you know how I should proceed?

Mike Frysinger

unread,
Sep 6, 2022, 1:33:30 AM9/6/22
to google-br...@googlegroups.com
hit "start review" and then "suggest owners" in the UI

the CL most likely should be broken up into smaller pieces
-mike

Reply all
Reply to author
Forward
0 new messages