[RFC PATCH] Fixup configure.ac

27 views
Skip to first unread message

Marc Gonzalez

unread,
Jul 4, 2023, 9:54:27 AM7/4/23
to google-br...@googlegroups.com, Mike Frysinger
Autotools noob speaking.
Wondering whether these changes make any sense.
(The original lines produce warnings on my system.)
---
configure.ac | 8 ++------
1 file changed, 1 insertions(+), 5 deletions(-)

diff --git a/configure.ac b/configure.ac
index 40394689..d21fd058 100644
--- a/configure.ac
+++ b/configure.ac
@@ -37,7 +37,7 @@ AC_CONFIG_MACRO_DIR([m4])
AC_CANONICAL_HOST

AM_INIT_AUTOMAKE(subdir-objects tar-ustar 1.13)
-AM_CONFIG_HEADER(src/config.h)
+AC_CONFIG_HEADERS(src/config.h)
AM_MAINTAINER_MODE

AM_PROG_AR
@@ -59,10 +59,6 @@ if test "x$enable_m32" = xyes; then
CXXFLAGS="${CXXFLAGS} -m32"
fi

-m4_warn([obsolete],
-[The preprocessor macro `STDC_HEADERS' is obsolete.
- Except in unusual embedded environments, you can safely include all
- ISO C90 headers unconditionally.])dnl
# Autoupdate added the next two lines to ensure that your configure
# script's behavior did not change. They are probably safe to remove.
AC_CHECK_INCLUDES_DEFAULT
--
2.34.1

Mike Frysinger

unread,
Jul 5, 2023, 10:41:09 AM7/5/23
to Marc Gonzalez, google-br...@googlegroups.com
thanks for the patches, but we don't use the mailing list to merge things.  please follow:

Marc Gonzalez

unread,
Jul 6, 2023, 9:53:16 AM7/6/23
to Mike Frysinger, google-br...@googlegroups.com
On 05/07/2023 16:40, Mike Frysinger wrote:

> thanks for the patches, but we don't use the mailing list to merge things.  please follow:
> https://chromium.googlesource.com/chromium/src/+/main/docs/contributing.md#Uploading-a-change-for-review

Roger that.
https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4668734

Regards.


Reply all
Reply to author
Forward
0 new messages