time off script Approve and Deny not working

[Hala Jalkh]

I followed the instructions posted online on how to activate the time off request for vacation script. i followed all the steps correctly.

i receive an email when a form is submitted however when i click on approve or deny the url is not found.

Any assistance.

Thks

[Alixe Lobato]

I have the same problem, did you find the solution?

[Andrew Roberts]

Can you give me a link to the tutorial and I'll take a look.

--
You received this message because you are subscribed to the Google Groups "Google Apps Script Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-apps-script-c...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-apps-script-community/b593df2a-853b-4608-8f13-f6c2b9d6dbebn%40googlegroups.com.

[Jim Willeke]

here is a link to the "original" script and doc.

https://docs.google.com/document/d/1y6x90S_q_cwdl4LGVDDSqMyuikx1zmPFyVQfSlYsKLk/edit

[Andrew Roberts]

This is an issue with the way web app URLs are created with the new editor: ScriptApp.getService().getUrl() no longer works (line 291). Go ahead and star the issue!

You can take a copy of this working version , which I've updated to get the web app URL out of the Settings tab. So everytime you deploy a new version of the web app you have to copy the new URL into the Settings tab.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-apps-script-community/ab3c10d6-74f4-4955-90d0-f2afdfd5a3d1n%40googlegroups.com.

[Jim Willeke]

Tell us what you have tried and show logs or results and 

• what URL is in the code for the "SCRIPT_URL" value in your Apps Script file?
• what is the URL you receive?

[Andrew Roberts]

Once you have deployed your copy of the script as a web app copy the URL (ending in /exec) into the WEB_APP_URL field in the __Settings tab.

On Fri, 7 Oct 2022 at 15:00, Joseph Martinez <jos...@mail.fresnostate.edu> wrote:

Hello, I am trying to accomplish my own automated time off request process as well and am having the same aforementioned difficulties with approval and denial of the requests. I have made a copy of your working version and linked it to my form accordingly, but I am not sure what you mean by copying the URL when creating the deployment as I can not edit the deployment URL that already exists. If you could offer any insight as to how I can resolve this issue I would greatly appreciate it!

To view this discussion on the web visit https://groups.google.com/d/msgid/google-apps-script-community/eaacb83e-d10b-4209-a764-0277ed14e5c8n%40googlegroups.com.

[Joseph Martinez]

Thank you Andrew! After doing this I was able to approve and deny the time off requests. I have now however run into another problem in the process, that of which being I can not see the requests populate in the calendar I have created. I made sure to link the calendar ID in the sheet, I also tried linking an existing calendar that has been used for the current manual time off requests just due to the fact that the calendar domain name of that one was different (it included our college's specific domain as it was created by a staff, I am merely a student assistant so my email address domain is slightly different) and that did not show the approved request either. Do you know what may be causing this issue?

To view this discussion on the web visit https://groups.google.com/d/msgid/google-apps-script-community/CAN1QPJStcSAU3CvWw7OeXMbUfxuyGJQG2pXysT%3DD6O0OScO0%3Dg%40mail.gmail.com.

[Andrew Roberts]

If you have the correct ID here, I'm afraid I couldn't know what the issue is without debugging. Have you checked the log?

On Tue, 11 Oct 2022 at 13:19, Joseph Martinez <jos...@mail.fresnostate.edu> wrote:

Hello, I am trying to accomplish my own automated time off request process as well and am having the same aforementioned difficulties with approval and denial of the requests. I have made a copy of your working version and linked it to my form accordingly, but I am not sure what you mean by copying the URL when creating the deployment as I can not edit the deployment URL that already exists. If you could offer any insight as to how I can resolve this issue I would greatly appreciate it!

--

You received this message because you are subscribed to the Google Groups "Google Apps Script Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-apps-script-c...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-apps-script-community/54f64ba5-66d5-469a-a595-dc6d5c9bef1en%40googlegroups.com.

[Joseph Martinez]

I shared the sheet with you in the hopes you might be able to figure out what the issue is in the script.

https://calendar.google.com/calendar/u/0?cid=Y18zMmU1ZWI4YmE3ZGQwNzU0MjFmMTRkY2M4MDYyOGZjODY1NGI2MGM2MzVkOTVlZGRkYjBkMjZiODBkNjljODBhQGdyb3VwLmNhbGVuZGFyLmdvb2dsZS5jb20

To view this discussion on the web visit https://groups.google.com/d/msgid/google-apps-script-community/CAN1QPJQnHV8zfVOtRhpQXUg6Nu41UP_FHjzsLZ2iscWHYgqSpw%40mail.gmail.com.

[Andrew Roberts]

It was a silent and deadly bug! When the event was created it was using "leaveStartDate" and "leaveEndDate", whereas these properties were actually called "startDate" and "endDate".

Even though the dates were "undefined" the event was still being created without throwing an error, but with no valid dates it wasn't being displayed. 

So use "Manage Deployments" to update the web app URL and you should be good to go!

[Andrew Roberts]

Although, this may of not actually been a bug, but that the code was using the header names in the form response to derive the object properties, and changing these broke the code as "leavingStartDate" was hard-coded.

[Joseph Martinez]

I have changed all of the "startDate" and "endDate" fields in the forms, sheet, and script to "leaveStartDate" and "leaveEndDate" and I am still receiving the same error message. The state and identifier fields do not populate with "pending" or identifier code.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-apps-script-community/a7b34639-10cf-4523-ab08-9c1a0f14e9fbn%40googlegroups.com.

[Andrew Roberts]

Those two are ok now as  "start date" and "end date" as that is what is in the code now. Compare the other field names with those on the original sheet you took a copy of.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-apps-script-community/CAEgEsrO5HMB7bOmqSKMQ8%2BH3va41cuM219%2B1K%3DejS35VFkYNKA%40mail.gmail.com.

[Joseph Martinez]

The other fields had been correctly changed. I had never gotten the script failure email before, are you sure you maybe didn’t edit the script incorrectly?

To view this discussion on the web visit https://groups.google.com/d/msgid/google-apps-script-community/CAN1QPJT9Dp17nQ9j2eSWFLo%2ByumX95btHpJRfYY4tK1iZb%3DpWg%40mail.gmail.com.

[Andrew Roberts]

There were bugs in the code that were being overlooked by the old interpreter (Rhino), but now the code runs on V8 (an upgrade I had to do to debug it) they were being flagged up.

I fixed that latest issue (the manager's email was being returned as an array rather than a string), along with various variables that were being unnecessarily being left as global and did a test run on this sheet. Try it now.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-apps-script-community/CAEgEsrNDx57aij1ozWNUkYyB95mOYpX7_OB91BmBXTfwPADmJA%40mail.gmail.com.

[Joseph Martinez]

Everything works smoothly! I had suspected the interpreter was outdated, but I was not sure how to upgrade this or what to even upgrade it to. Like I said, I have never coded before so I would not have been able to recognize the problems you did. Thank you for the assistance, I greatly appreciate it!

To view this discussion on the web visit https://groups.google.com/d/msgid/google-apps-script-community/CAN1QPJQFbGwwReHUn2fLM2Y9%3D%3DgCr3yYaYfcue_WH-2-N%3DkLnw%40mail.gmail.com.