URLFetch API Stub broken in GCloud SDK [with patch]

94 views
Skip to first unread message

Josh Whelchel (Loudr)

unread,
Jul 6, 2015, 10:09:01 PM7/6/15
to google-a...@googlegroups.com
There is an active issue with urlfetch_stub.py in the SDK where the FULL URL is being sent to the HTTP server as the path.


Basically, it's connecting like this:

Oh hey, http://localhost, we're connected, HI!
Now that we're connected, can you give me URI "http://localhost"
Wait what, that's not right?? ooh.


We found this while working on our elasticsearch integration, which was hilarious to debug.
Imagine trying to find out why you have a new index named "http:"

Karl MacMillan

unread,
Jul 6, 2015, 10:24:54 PM7/6/15
to google-a...@googlegroups.com, google-a...@googlegroups.com
I’ve seen this as well and submitted a support ticket. I did not find the debugging hilarious, but it’s nice to see someone else handle things with better humor than me.

Karl

-- 
You received this message because you are subscribed to the Google Groups "Google App Engine" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-appengi...@googlegroups.com.
To post to this group, send email to google-a...@googlegroups.com.
Visit this group at http://groups.google.com/group/google-appengine.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-appengine/74688f8c-27f1-42fa-a706-ee83dc5de299%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Aaron Madison

unread,
Jul 7, 2015, 2:12:42 PM7/7/15
to google-a...@googlegroups.com
Looks like a bug was filed yesterday. I'll update the SO post to reference this bug so hopefully more people can star it.



On Monday, July 6, 2015 at 9:24:54 PM UTC-5, Karl MacMillan wrote:
I’ve seen this as well and submitted a support ticket. I did not find the debugging hilarious, but it’s nice to see someone else handle things with better humor than me.

Karl

On Jul 6, 2015, at 10:09 PM, Josh Whelchel (Loudr) <jo...@loudr.fm> wrote:

There is an active issue with urlfetch_stub.py in the SDK where the FULL URL is being sent to the HTTP server as the path.


Basically, it's connecting like this:

Oh hey, http://localhost, we're connected, HI!
Now that we're connected, can you give me URI "http://localhost"
Wait what, that's not right?? ooh.


We found this while working on our elasticsearch integration, which was hilarious to debug.
Imagine trying to find out why you have a new index named "http:"

-- 
You received this message because you are subscribed to the Google Groups "Google App Engine" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-appengine+unsub...@googlegroups.com.

Karl MacMillan

unread,
Jul 7, 2015, 3:56:24 PM7/7/15
to google-a...@googlegroups.com, google-a...@googlegroups.com
I got a confirmation this morning from support of this issue and a suggestion that it will be fixed in a subsequent release.

Can I just ask some Googlers - how on earth did this issue slip by? This is the second serious SDK issue I’ve seen in recent months that would have been caught by the most obvious test in the world (the other was cloud storage being largely broken in the SDK).

I don’t want to hammer too much, but seriously, do you not have tests at all for parts of the SDK? This is not a corner case - this is the most basic functionality being broken. I find it very, very concerning that your QA procedures are not catching such obvious bugs.

Karl



To unsubscribe from this group and stop receiving emails from it, send an email to google-appengi...@googlegroups.com.

To post to this group, send email to google-a...@googlegroups.com.
Visit this group at http://groups.google.com/group/google-appengine.

Josh Whelchel (Loudr)

unread,
Jul 7, 2015, 4:18:21 PM7/7/15
to google-a...@googlegroups.com
This issue was so hard to find, and related to the outgoing request, I believe a test-case would have been hard-pressed to find it.

That said, the bug is on the stub implementation of the urlfetch API - I'd expect some request header tests as well.

*shrug*

can't catch 'em all

Karl MacMillan

unread,
Jul 7, 2015, 5:36:30 PM7/7/15
to google-a...@googlegroups.com, google-a...@googlegroups.com

On Jul 7, 2015, at 4:18 PM, Josh Whelchel (Loudr) <jo...@loudr.fm> wrote:

This issue was so hard to find, and related to the outgoing request, I believe a test-case would have been hard-pressed to find it.


Why? All outgoing http requests are broken as far as I can tell.

That said, the bug is on the stub implementation of the urlfetch API - I'd expect some request header tests as well.

*shrug*

can't catch 'em all


And I wouldn’t be complaining if this was the first, but it’s not.

Karl

On Tuesday, July 7, 2015 at 12:56:24 PM UTC-7, Karl MacMillan wrote:
I got a confirmation this morning from support of this issue and a suggestion that it will be fixed in a subsequent release.

Can I just ask some Googlers - how on earth did this issue slip by? This is the second serious SDK issue I’ve seen in recent months that would have been caught by the most obvious test in the world (the other was cloud storage being largely broken in the SDK).

I don’t want to hammer too much, but seriously, do you not have tests at all for parts of the SDK? This is not a corner case - this is the most basic functionality being broken. I find it very, very concerning that your QA procedures are not catching such obvious bugs.

Karl



On Jul 7, 2015, at 2:12 PM, Aaron Madison <aaron....@imtapps.com> wrote:

Looks like a bug was filed yesterday. I'll update the SO post to reference this bug so hopefully more people can star it.

https://code.google.com/p/googleappengine/issues/detail?id=12123


On Monday, July 6, 2015 at 9:24:54 PM UTC-5, Karl MacMillan wrote:
I’ve seen this as well and submitted a support ticket. I did not find the debugging hilarious, but it’s nice to see someone else handle things with better humor than me.

Karl

On Jul 6, 2015, at 10:09 PM, Josh Whelchel (Loudr) <jo...@loudr.fm> wrote:

There is an active issue with urlfetch_stub.py in the SDK where the FULL URL is being sent to the HTTP server as the path.


Basically, it's connecting like this:

Oh hey, http://localhost, we're connected, HI!
Now that we're connected, can you give me URI "http://localhost"
Wait what, that's not right?? ooh.


We found this while working on our elasticsearch integration, which was hilarious to debug.
Imagine trying to find out why you have a new index named "http:"


-- 
You received this message because you are subscribed to the Google Groups "Google App Engine" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-appengi...@googlegroups.com.
To post to this group, send email to google-a...@googlegroups.com.
Visit this group at http://groups.google.com/group/google-appengine.
Reply all
Reply to author
Forward
0 new messages