Issue 62 in google-app-engine-oil: Code review request: [5cbe319ccb] Introduces the gaeodoc.py for generating pydocs for source codes
google-app...@googlecode.com
Owner: ericsk
Labels: Type-Review Priority-Medium
New issue 62 by ping.nsr...@gmail.com: Code review request: [5cbe319ccb]
Introduces the gaeodoc.py for generating pydocs for source codes
http://code.google.com/p/google-app-engine-oil/issues/detail?id=62
Please feel free to re-assign this request to other members if you like.
Purpose of code changes on this branch: See commit log of revision
5cbe319ccb.
When reviewing my code changes, please focus on: If the gaeodoc.py is
useful, and if it does what it claims to do properly. You can pull the
changeset and run
$ gaeodoc.py oildrum/lib/gaeo/controller.py
or any files in that directory to see how it works.
After the review, I'll merge this branch into:
/trunk
p.s. Somehow gaeodoc.py complains "No module named django" when working
with oildrum/lib/gaeo/view/filters.py. I can't find where django is
imported. Any hint on how to solve this is appreciated.
google-app...@googlecode.com
Comment #1 on issue 62 by ping.nsr...@gmail.com: Code review request:
codes
http://code.google.com/p/google-app-engine-oil/issues/detail?id=62
I have fixed the hardcoded App Engine PATH in gaeodoc.py in revision
645a5fec4e.
google-app...@googlecode.com
Comment #2 on issue 62 by ping.nsr...@gmail.com: Code review request:
codes
http://code.google.com/p/google-app-engine-oil/issues/detail?id=62
I've further separated the logic of identifying App Engine PATH and GAEO
PATH to a library lib/gaeo_path_util.py in revision 8e06fe21a9 because it
will be re-used by unit tests. Please take a look there as well. Thanks!
google-app...@googlecode.com
Status: Done
Comment #3 on issue 62 by ericsk: Code review request: [5cbe319ccb]
Introduces the gaeodoc.py for generating pydocs for source codes
http://code.google.com/p/google-app-engine-oil/issues/detail?id=62
This revision has been reviewed and can be merged into trunk. Thanks.