Comment on revision r87102ba2b4859f82a13ca1bfbd605d608a38532e in google-app-engine-oil

[google-app...@googlecode.com]

Comment by ericsk:

Score: Neutral

General Comment:
I think that the test script should not be put in the lib directory. I
prefer the test scripts could be put in other directory, like
```$PROJECT_ROOT/test```. Thus, the test scripts can be easily ignored to
deploy by configure the app.yaml.

For more information:
http://code.google.com/p/google-app-engine-oil/source/detail?r=87102ba2b4859f82a13ca1bfbd605d608a38532e

[google-app...@googlecode.com]

Comment by ping.nsr...@gmail.com:

General Comment:
That's a valid point. However, the unit tests of the framework don't need
to be copied to project's source tree. That would require changing gaeo.py.

A merit of keeping unit tests in a separate directory is that the framework
is using the same way to locate modules in unit tests as the projects. That
means the framework can provide libraries for a project's unit tests. That
can be a nice feature of the framework.

I'd like to move the unit tests to the test/ directory of the top of GAEO
source tree. Please let me know if you think this is not the best path.

[google-app...@googlecode.com]

Comment by ericsk:

Score: Neutral

General Comment:
Agree. Please put the skeleton of test scripts on the top of GAEO source
tree, and copy them into the project (e.g., eva) source tree. One is test
the GAEO; the other is for the project. It means that $GAEO_ROOT/test/ dir
and $PROJECT/test/ will exist in the future version of GAEO projects.

[google-app...@googlecode.com]

Comment by ping.nsr...@gmail.com:

General Comment:
Moved in revision de2e9fb7b6.