Issue 63 in google-app-engine-oil: Code review request: [87102ba2b4] Add unit tests of GaeoRequest class of oildrum/lib/gaeo/app.py.

[google-app...@googlecode.com]

Status: New
Owner: ericsk
Labels: Type-Review Priority-Medium

New issue 63 by ping.nsr...@gmail.com: Code review request: [87102ba2b4]
Add unit tests of GaeoRequest class of oildrum/lib/gaeo/app.py.
http://code.google.com/p/google-app-engine-oil/issues/detail?id=63

This is revision 87102ba2b4.

Purpose of code changes on this branch: Add the first unit test to GAEO
library modules.

To run unit tests, please easy_install unittest2 and run "python
app_test.py" or "nosetests app_test.py" if you have nose installed.

When reviewing my code changes, please focus on:

1. The directory structure. I put unit test and module under test in the
same directory -- is it the preferred way? This simplifies the test module
because it doesn't need to locate the module under test in another
directory. Besides, it becomes trivial to spot the modules that are missing
tests.

2. The import structure. I ran unit tests stand-alone and utilized the
gaeo_path_util library to gain access to App Engine modules and GAEO
modules in unit tests -- are there better ways to run the unit tests? I've
tried NoseGAE (http://code.google.com/p/nose-gae/) and decided not to use
it because it needs an app.yaml and has difficulties in locating gaeo and
unittest2 modules. However, I'm open to discussions.

After the review, I'll merge this branch into:
/trunk

[google-app...@googlecode.com]

Updates:
Status: Started
Owner: ping.nsr.yeh

Comment #1 on issue 63 by ericsk: Code review request: [87102ba2b4] Add

unit tests of GaeoRequest class of oildrum/lib/gaeo/app.py.
http://code.google.com/p/google-app-engine-oil/issues/detail?id=63

I've reviewed and left a review for the directory issue.