Issue 61 in google-app-engine-oil: Code review request: Document the rest of codes in oildrum/lib/gaeo

2 views
Skip to first unread message

google-app...@googlecode.com

unread,
Nov 26, 2010, 10:49:42 AM11/26/10
to google-app...@googlegroups.com
Status: New
Owner: ericsk
Labels: Type-Review Priority-Medium

New issue 61 by ping.nsr...@gmail.com: Code review request: Document the
rest of codes in oildrum/lib/gaeo
http://code.google.com/p/google-app-engine-oil/issues/detail?id=61

Purpose of code changes on this branch:
Document the rest of codes in oildrum/lib/gaeo, with TODO added for
functions/methods that I don't understand. This is revision 456f959fba.

When reviewing my code changes, please focus on:
Validity and style of docstrings.

After the review, I'll merge this branch into:
/trunk

This is the last of the series of docstrings for oildrum/lib/gaeo. I didn't
complete all docstrings because I don't understand all
functions/methods/arguments/returns. I'll merge it into trunk after this
review.

google-app...@googlecode.com

unread,
Nov 27, 2010, 10:07:31 PM11/27/10
to google-app...@googlegroups.com
Updates:
Status: Done

Comment #1 on issue 61 by ericsk: Code review request: Document the rest of

Reviewed. I will complete the remain TODOs.

google-app...@googlecode.com

unread,
Nov 28, 2010, 12:00:08 AM11/28/10
to google-app...@googlegroups.com

Comment #2 on issue 61 by ping.nsr...@gmail.com: Code review request:
Document the rest of codes in oildrum/lib/gaeo
http://code.google.com/p/google-app-engine-oil/issues/detail?id=61

Thanks for the review, I've merged this changeset to the trunk as revision
d2542c3463.

Reply all
Reply to author
Forward
0 new messages