date_default_timezone_set call in apiClient.php

[Santiago]

Hello!

on apiClient.php line 27 the default timezone is changed to UTC

if (function_exists('date_default_timezone_set')) {
date_default_timezone_set('UTC');
}

my application relies on the current established timezone, and
naturally this presents a problem for me. Why is the default
timezone being changed here? I see no important calls to date
functions to justify this, so I'd like to know why this is needed and
if I can remove it safely.

Thanks!

[Chirag Shah]

Hey Santiago,

Thank you for reporting this issue.  I've committed a change so date_default_timezone_set('UTC') only gets called when date.timezone isn't populated.

It is also available in google-api-php-client-0.4.8.2.

http://code.google.com/p/google-api-php-client/downloads/detail?name=google-api-php-client-0.4.8.2.tar.gz

On Thu, Jan 12, 2012 at 7:16 AM, Santiago <santiag...@gmail.com> wrote:

Hello!

on apiClient.php line 27 the default timezone is changed to UTC

if (function_exists('date_default_timezone_set')) {
 date_default_timezone_set('UTC');
}

my application relies on the current established timezone, and
naturally this presents a problem for me.   Why is the default
timezone being changed here?   I see no important calls to date

I received several complaints about php complaining about "it is not safe to rely on the system's timezone settings. You are required to use the date.timezone setting..."

and several people had issues updating their php.ini file, etc.

We need date.timezone because we use strtotime to parse the Expires HTTP header.

 

functions to justify this, so I'd like to know why this is needed and
if I can remove it safely.

You can remove it safely.

Thanks!

[Marko Tukiainen]

Hello,

Sorry to resurrect an old thread, but having just spent several hours debugging what seemed to be the bogeyman changing the timezone setting and causing quite a lot of complaints I finally tracked down the culprit to this. 

I would like to suggest that this be changed so that the timezone change is automatically reset back to the original setting. None of the php.ini files on any of my servers set date.timezone, instead the system default is used. So, when this library calls date_default_timezone_set('UTC') bad things start to happen. 

Thanks, 

Marko