Re: Issue 6: Create an ASP.Net MVC Sample (issue 194980043 by jmcgrew@google.com)
31 views
Skip to first unread message
laur...@gmail.com
Jun 26, 2015, 7:04:58 AM6/26/15
to jmc...@google.com, pel...@google.com, cl...@google.com, google-api-d...@googlegroups.com, re...@codereview-hr.appspotmail.com
On 2015/04/08 13:36:20, peleyal wrote:
> Sorry it takes forever :)
> Just I still didn't get if the client library can already store your
credential
> (like we discussed offline).
> Besides that LGTM
> Can you also attach some screenshots of screen to CL description?
> Thanks!
https://codereview.appspot.com/194980043/diff/30001/Calendar.ASP.NET.MVC5/App_Start/IdentityConfig.cs
> File Calendar.ASP.NET.MVC5/App_Start/IdentityConfig.cs (right):
https://codereview.appspot.com/194980043/diff/30001/Calendar.ASP.NET.MVC5/App_Start/IdentityConfig.cs#newcode103
> Calendar.ASP.NET.MVC5/App_Start/IdentityConfig.cs:103: var
googleRefreshToken =
> externalIdentity.FindFirst(MyClaimTypes.GoogleRefreshToken);
> On 2015/04/06 23:01:52, jmcgrew wrote:
> > On 2015/03/07 00:17:43, peleyal wrote:
> > > Why do we need to save the access and refresh token here? They
should be
> > stored
> > > in the auth library (using the data store)? It looks like I'm
missing
> > something
> >
> > These tokens are returned in the OAuth login response to the MVC
third-party
> > login provider. At Startup.Auth.cs:86, we copy them into a temporary
identity,
> > and then here we copy them from the temporary identity to the real
identity
> > where they'll be stored alongside the rest of the user's MVC
profile. Is there
> > an advantage to storing them in the API client's data store instead?
> It just that the client library already stored all those values
(except user id)
> for you, so why do we need to store them in two different places?
Was this released? I have someone on my website looking for some help
with MVC / owin / client lib mix authentication.
https://codereview.appspot.com/194980043/
> Sorry it takes forever :)
> Just I still didn't get if the client library can already store your
credential
> (like we discussed offline).
> Besides that LGTM
> Can you also attach some screenshots of screen to CL description?
> Thanks!
https://codereview.appspot.com/194980043/diff/30001/Calendar.ASP.NET.MVC5/App_Start/IdentityConfig.cs
> File Calendar.ASP.NET.MVC5/App_Start/IdentityConfig.cs (right):
https://codereview.appspot.com/194980043/diff/30001/Calendar.ASP.NET.MVC5/App_Start/IdentityConfig.cs#newcode103
> Calendar.ASP.NET.MVC5/App_Start/IdentityConfig.cs:103: var
googleRefreshToken =
> externalIdentity.FindFirst(MyClaimTypes.GoogleRefreshToken);
> On 2015/04/06 23:01:52, jmcgrew wrote:
> > On 2015/03/07 00:17:43, peleyal wrote:
> > > Why do we need to save the access and refresh token here? They
should be
> > stored
> > > in the auth library (using the data store)? It looks like I'm
missing
> > something
> >
> > These tokens are returned in the OAuth login response to the MVC
third-party
> > login provider. At Startup.Auth.cs:86, we copy them into a temporary
identity,
> > and then here we copy them from the temporary identity to the real
identity
> > where they'll be stored alongside the rest of the user's MVC
profile. Is there
> > an advantage to storing them in the API client's data store instead?
> It just that the client library already stored all those values
(except user id)
> for you, so why do we need to store them in two different places?
Was this released? I have someone on my website looking for some help
with MVC / owin / client lib mix authentication.
https://codereview.appspot.com/194980043/
Eyal Peled
Jun 26, 2015, 3:11:30 PM6/26/15
to jmc...@google.com, cl...@google.com, laur...@gmail.com, google-api-d...@googlegroups.com, re...@codereview-hr.appspotmail.com
Be aware that I'm going to release a new library in two weeks from now... so if you are going to push it next week it will be awesome!
On Fri, Jun 26, 2015 at 2:33 PM <jmc...@google.com> wrote:
It hasn't been released yet - the migration to Github caught me at a
busy time so I haven't had much of a chance to push it through the new
release process. I've added it to my todo list for next week.
https://codereview.appspot.com/194980043/
LindaLawton
Jun 29, 2015, 5:12:53 AM6/29/15
to Eyal Peled, jmc...@google.com, cl...@google.com, google-api-d...@googlegroups.com, re...@codereview-hr.appspotmail.com
I sent the link to someone anyway, it helped him fix his problem. Thought you would like to know that :)
I am still MVC nub so pointing him at your tutorial worked.
Linda
Reply all
Reply to author
Forward
0 new messages