My app is crashing on [GADBannerWebViewDelegate webViewDidFinishLoad:]

[cs...@tagged.com]

My iOS app is using GoogleAdMobAdsSdk 6.7.0 to retrieve the ads from AdMob. In our recent released version, we are getting the ads from AdMob ad network mediation. Recently we are getting hundreds of crash reports happening on GoogleAd SDK. Attached is the crash log

[Eric Leichtenschlag]

Hello,

This crash may occur if your bannerView.delegate is pointing to an object that has been deallocated. How are you setting your delegate? And are you nilling it out when your view controller is deallocated?

Thanks,
Eric

[cs...@tagged.com]

Hi,

I'm setting the bannerView.delegate to my view controller. I didn't nil the bannerView.delegate out when my view controller is deallocated. I think the delegate should be a weak property so do I need to nil it out explicitly?

Also, I couldn't reproduce this crash by deallocating the view controller before the ads completes loading. I just collected the crash reports from our app users. So it looks that this problem is not always reproducable.

Thanks,

Chenglei

[Eric Leichtenschlag]

Hey Chenglei,

The SDK still supports iOS 4.3 and as such doesn't use ARC yet. From GADBannerView.h, the delegate property is set as assign, so it's still holding onto a memory address that has been deallocated. So you should explicitly nil it out in dealloc.

Thanks,
Eric

[Chenglei Shen]

Okay.

I'll try it.

Thanks,

Chenglei

--
 
---
You received this message because you are subscribed to a topic in the Google Groups "Google AdMob Ads Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-admob-ads-sdk/3C4WRygCv1U/unsubscribe.
To unsubscribe from this group and all its topics, send an email to google-admob-ads...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.