Issue 39 in goobook: Patch for goobook-1.4 with hcs_utils >=1.3

2 views
Skip to first unread message

goo...@googlecode.com

unread,
Jul 8, 2013, 12:58:40 PM7/8/13
to goobook...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 39 by j...@stormlord.ca: Patch for goobook-1.4 with hcs_utils
>=1.3
http://code.google.com/p/goobook/issues/detail?id=39

Goobook-1.4 currently doesn't run with hcs_utils >=1.3 (failing to pickle
the Storage object), which is a fairly easy fix (using
storageify/unstorageify when storing/retrieving cache). Attached is a patch
to make it work appropriately (at least with hcs_utils 1.3 and 1.4_rc5).

A small note: I arbitrarily picked CACHE_FORMAT_VERSION = '4.0', since it
seemed as good a value as any other for the change in cache format.

Originally reported and fixed in Gentoo here:
https://bugs.gentoo.org/show_bug.cgi?id=449916

Attachments:
goobook-1.4-hcs-utils-1.3.patch 2.4 KB

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

goo...@googlecode.com

unread,
Jul 16, 2013, 4:01:01 PM7/16/13
to goobook...@googlegroups.com
Updates:
Status: Fixed
Owner: h...@furuvik.net

Comment #1 on issue 39 by h...@furuvik.net: Patch for goobook-1.4 with
hcs_utils >=1.3
http://code.google.com/p/goobook/issues/detail?id=39

Patch applied and fix available in release branch, if you can, please test.

goo...@googlecode.com

unread,
Jul 16, 2013, 6:00:02 PM7/16/13
to goobook...@googlegroups.com

Comment #2 on issue 39 by j...@stormlord.ca: Patch for goobook-1.4 with
hcs_utils >=1.3
http://code.google.com/p/goobook/issues/detail?id=39

Tested it, and it works. Thanks!

goo...@googlecode.com

unread,
Jul 17, 2013, 2:05:02 AM7/17/13
to goobook...@googlegroups.com
Updates:
Status: Verified

Comment #3 on issue 39 by h...@furuvik.net: Patch for goobook-1.4 with
hcs_utils >=1.3
http://code.google.com/p/goobook/issues/detail?id=39

(No comment was entered for this change.)
Reply all
Reply to author
Forward
0 new messages