Issue 21 in goobook: Cache file never expires

2 views
Skip to first unread message

goo...@googlecode.com

unread,
Sep 17, 2010, 7:33:50 PM9/17/10
to goobook...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 21 by kevin.mccarthy: Cache file never expires
http://code.google.com/p/goobook/issues/detail?id=21

I've noticed my cache file never seems to expire. I've set it to 72 hours
in my config, but google is never re-queried.

After some debugging, the problem seems to be that
self.__config.cache_expiry_hours is of type String.

Therefore, the line doing the comparison in goobook.py:
(self.__config.cache_expiry_hours * 60 * 60)
is actually doing a string operation which creates "72727272727.......".

Attached is a patch converting cache_expiry_hours to an int before doing
the multiplication.

Attachments:
goobook.patch 707 bytes

goo...@googlecode.com

unread,
Sep 24, 2010, 2:25:40 AM9/24/10
to goobook...@googlegroups.com
Updates:
Status: Fixed

Comment #1 on issue 21 by h...@furuvik.net: Cache file never expires
http://code.google.com/p/goobook/issues/detail?id=21

Ouch, fixed

Reply all
Reply to author
Forward
0 new messages